Skip to content

Conversation

obeis
Copy link
Contributor

@obeis obeis commented Feb 25, 2023

migrate rustc_hir_analysis to session diagnostic (part two)
files list:

  • rustc_hir_analysis/variance/*
  • rustc_hir_analysis/missing_cast_for_variadic_arg.rs
  • rustc_hir_analysis/sized_unsized_cast.rs

Updates #100717

@rustbot
Copy link
Collaborator

rustbot commented Feb 25, 2023

r? @spastorino

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Feb 25, 2023
@bors
Copy link
Collaborator

bors commented Feb 25, 2023

☔ The latest upstream changes (presumably #108450) made this pull request unmergeable. Please resolve the merge conflicts.

@obeis obeis force-pushed the hir-analysis-migrate-diagnostics-2 branch 2 times, most recently from 871f701 to 3abf98f Compare February 26, 2023 18:33
@bors
Copy link
Collaborator

bors commented Mar 3, 2023

☔ The latest upstream changes (presumably #108707) made this pull request unmergeable. Please resolve the merge conflicts.

part two
files list:
rustc_hir_analysis/variance/*
rustc_hir_analysis/missing_cast_for_variadic_arg.rs
rustc_hir_analysis/sized_unsized_cast.rs
@obeis obeis force-pushed the hir-analysis-migrate-diagnostics-2 branch from 3abf98f to 44eb974 Compare March 4, 2023 21:02
@spastorino spastorino removed their assignment Mar 6, 2023
@spastorino
Copy link
Member

Leaving this up to @compiler-errors or @davidtwco maybe?

@compiler-errors
Copy link
Member

r? @compiler-errors @bors r+

@bors
Copy link
Collaborator

bors commented Mar 7, 2023

📌 Commit 44eb974 has been approved by compiler-errors

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 7, 2023
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 7, 2023
…iaskrgr

Rollup of 7 pull requests

Successful merges:

 - rust-lang#108460 (migrate `rustc_hir_analysis` to session diagnostic [Part Two])
 - rust-lang#108581 (Add a new config flag, dist.include-mingw-linker.)
 - rust-lang#108583 (Account for binders correctly when adding default RPITIT method assumption)
 - rust-lang#108783 (Sync rustc_codegen_gcc 2023/03/04)
 - rust-lang#108793 (Append to existing `PYTHONPATH` in compiletest instead of overwriting)
 - rust-lang#108822 (Remove references to PassManagerBuilder)
 - rust-lang#108866 (Force to use the stage 2 compiler  when config.download_rustc is set)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 14260c8 into rust-lang:master Mar 8, 2023
@rustbot rustbot added this to the 1.70.0 milestone Mar 8, 2023
@obeis obeis deleted the hir-analysis-migrate-diagnostics-2 branch May 13, 2023 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants