Skip to content

fix type suggestions in match arms #109613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 27, 2023
Merged

fix type suggestions in match arms #109613

merged 1 commit into from
Mar 27, 2023

Conversation

lukas-code
Copy link
Member

fix #109586

@rustbot
Copy link
Collaborator

rustbot commented Mar 25, 2023

r? @eholk

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Mar 25, 2023
@compiler-errors
Copy link
Member

🤦

this code really shouldn't live here at all, it's probably better if it lives in rustc_hir_typeck -- but that's probably better for a different refactoring.

r? @compiler-errors @bors r+ rollup

@bors
Copy link
Collaborator

bors commented Mar 26, 2023

📌 Commit 08f3deb has been approved by compiler-errors

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented Mar 26, 2023

🌲 The tree is currently closed for pull requests below priority 100. This pull request will be tested once the tree is reopened.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 26, 2023
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request Mar 27, 2023
@Dylan-DPC
Rollup merge of rust-lang#109613 - lukas-code:match-str-to-char-sugge…
ac61f26 
…stion, r=compiler-errors

fix type suggestions in match arms

fix rust-lang#109586
@Dylan-DPC Dylan-DPC mentioned this pull request Mar 27, 2023
Closed
@matthiaskrgr matthiaskrgr mentioned this pull request Mar 27, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 27, 2023
@bors
Auto merge of rust-lang#109652 - matthiaskrgr:rollup-pbw3hi3, r=matth…
553ecbe 
…iaskrgr

Rollup of 8 pull requests

Successful merges:

 - rust-lang#97506 (Stabilize `nonnull_slice_from_raw_parts`)
 - rust-lang#98651 (Follow C-RW-VALUE in std::io::Cursor example)
 - rust-lang#102742 (Remove unnecessary raw pointer in __rust_start_panic arg)
 - rust-lang#109587 (Use an IndexVec to debug fingerprints.)
 - rust-lang#109613 (fix type suggestions in match arms)
 - rust-lang#109633 (Fix "Directly go to item in search if there is only one result" setting)
 - rust-lang#109635 (debuginfo: Get pointer size/align from tcx.data_layout instead of layout_of)
 - rust-lang#109641 (Don't elaborate non-obligations into obligations)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 04b8523 into rust-lang:master Mar 27, 2023
@rustbot rustbot added this to the 1.70.0 milestone Mar 27, 2023
@lukas-code lukas-code deleted the match-str-to-char-suggestion branch March 27, 2023 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@compiler-errors compiler-errors

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.70.0
Development

Successfully merging this pull request may close these issues.

Rust should suggest single quotes when expecting char
5 participants
@lukas-code @rustbot @compiler-errors @bors @eholk