Suggest Replacing Comma with Semicolon in Incorrect Repeat Expressions #128110

veera-sivarajan · 2024-07-23T17:57:41Z

This PR detects typos in repeat expressions like ["_", 10] and vec![String::new(), 10] and suggests replacing comma with semicolon.

Also, improves code in other place by adding doc comments and making use of a helper function to check if a type implements Clone.

References:

For vec![T; N]: https://doc.rust-lang.org/std/macro.vec.html
For [T; N]: https://doc.rust-lang.org/std/primitive.array.html

rustbot · 2024-07-23T17:57:49Z

r? @petrochenkov

rustbot has assigned @petrochenkov.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

petrochenkov · 2024-07-24T12:09:43Z

r? compiler

bors · 2024-07-29T06:02:13Z

☔ The latest upstream changes (presumably #125443) made this pull request unmergeable. Please resolve the merge conflicts.

veera-sivarajan · 2024-08-26T12:21:50Z

@fmease friendly bump

veera-sivarajan · 2024-10-05T12:17:26Z

r? compiler

fmease

Ah, let me post what I had pending

compiler/rustc_hir_typeck/messages.ftl

compiler/rustc_trait_selection/src/infer.rs

bors · 2024-10-15T08:04:45Z

☔ The latest upstream changes (presumably #131724) made this pull request unmergeable. Please resolve the merge conflicts.

compiler/rustc_hir_typeck/src/fn_ctxt/suggestions.rs

cjgillot · 2025-01-08T20:19:15Z

Thanks for your patience.
@bors r+ rollup

bors · 2025-01-08T20:19:18Z

📌 Commit 98cc345 has been approved by cjgillot

It is now in the queue for this repository.

…gillot Suggest Replacing Comma with Semicolon in Incorrect Repeat Expressions Fixes rust-lang#80173 This PR detects typos in repeat expressions like `["_", 10]` and `vec![String::new(), 10]` and suggests replacing comma with semicolon. Also, improves code in other place by adding doc comments and making use of a helper function to check if a type implements `Clone`. References: 1. For `vec![T; N]`: https://doc.rust-lang.org/std/macro.vec.html 2. For `[T; N]`: https://doc.rust-lang.org/std/primitive.array.html

…iaskrgr Rollup of 6 pull requests Successful merges: - rust-lang#128110 (Suggest Replacing Comma with Semicolon in Incorrect Repeat Expressions) - rust-lang#134609 (Add new `{x86_64,i686}-win7-windows-gnu` targets) - rust-lang#134875 (Implement `const Destruct` in old solver) - rust-lang#135221 (Include rustc and rustdoc book in replace-version-placeholder) - rust-lang#135231 (bootstrap: Add more comments to some of the test steps) - rust-lang#135256 (Move `mod cargo` below the import statements) Failed merges: - rust-lang#135195 (Make `lit_to_mir_constant` and `lit_to_const` infallible) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of rust-lang#128110 - veera-sivarajan:bugfix-80173, r=cjgillot Suggest Replacing Comma with Semicolon in Incorrect Repeat Expressions Fixes rust-lang#80173 This PR detects typos in repeat expressions like `["_", 10]` and `vec![String::new(), 10]` and suggests replacing comma with semicolon. Also, improves code in other place by adding doc comments and making use of a helper function to check if a type implements `Clone`. References: 1. For `vec![T; N]`: https://doc.rust-lang.org/std/macro.vec.html 2. For `[T; N]`: https://doc.rust-lang.org/std/primitive.array.html

rustbot assigned petrochenkov Jul 23, 2024

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jul 23, 2024

veera-sivarajan force-pushed the bugfix-80173 branch from 21132fb to 88be2cb Compare July 23, 2024 18:15