Try enabling precondition checks on ptr::{read,write} #129498

saethlin · 2024-08-24T04:04:47Z

The overhead here is probably too much, but let's have the measurement anyway.

Ralf says: If we keep this attribute, the docs on the intrinsic should be updated.

saethlin · 2024-08-24T04:04:54Z

bors · 2024-08-24T04:06:05Z

⌛ Trying commit 0a65e30 with merge aadda4d...

…, r=<try> Try enabling precondition checks on ptr::{read,write} The overhead here is probably too much, but let's have the measurement anyway. This will fail at least one codegen test. r? `@ghost`

bors · 2024-08-24T05:50:51Z

☀️ Try build successful - checks-actions
Build commit: aadda4d (aadda4d695969f6a5337d0bf19f1e6572bd67922)

rust-timer · 2024-08-24T07:07:18Z

Finished benchmarking commit (aadda4d): comparison URL.

Overall result: ❌✅ regressions and improvements - ACTION NEEDED

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.7%	[0.2%, 1.9%]	52
Regressions ❌ (secondary)	2.0%	[0.2%, 6.3%]	32
Improvements ✅ (primary)	-0.6%	[-0.9%, -0.4%]	3
Improvements ✅ (secondary)	-1.3%	[-1.3%, -1.3%]	1
All ❌✅ (primary)	0.6%	[-0.9%, 1.9%]	55

Max RSS (memory usage)

Results (primary 0.3%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	3.1%	[0.6%, 5.0%]	4
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-3.3%	[-3.7%, -2.8%]	3
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.3%	[-3.7%, 5.0%]	7

Cycles

Results (primary 1.5%, secondary 3.3%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	1.5%	[0.7%, 2.1%]	6
Regressions ❌ (secondary)	3.3%	[2.1%, 5.3%]	8
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	1.5%	[0.7%, 2.1%]	6

Binary size

Results (primary 0.6%, secondary 0.6%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.7%	[0.0%, 6.1%]	77
Regressions ❌ (secondary)	3.2%	[1.1%, 3.7%]	12
Improvements ✅ (primary)	-0.3%	[-0.5%, -0.1%]	11
Improvements ✅ (secondary)	-0.2%	[-3.1%, -0.0%]	43
All ❌✅ (primary)	0.6%	[-0.5%, 6.1%]	88

Bootstrap: 751.449s -> 756.74s (0.70%)
Artifact size: 339.00 MiB -> 338.92 MiB (-0.02%)

saethlin · 2024-08-28T00:44:37Z

@bors try @rust-timer queue

…, r=<try> Try enabling precondition checks on ptr::{read,write} The overhead here is probably too much, but let's have the measurement anyway. This will fail at least one codegen test. r? `@ghost`

bors · 2024-08-28T00:45:48Z

⌛ Trying commit 3b756c6 with merge 4091821...

bors · 2024-08-28T02:29:28Z

☀️ Try build successful - checks-actions
Build commit: 4091821 (40918219c81cfdde936a6a9166876866d77b7d1f)

rust-timer · 2024-08-28T04:40:37Z

Finished benchmarking commit (4091821): comparison URL.

Overall result: ❌✅ regressions and improvements - ACTION NEEDED

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.5%	[0.2%, 1.6%]	32
Regressions ❌ (secondary)	0.9%	[0.2%, 2.4%]	7
Improvements ✅ (primary)	-0.5%	[-0.5%, -0.5%]	2
Improvements ✅ (secondary)	-1.6%	[-1.6%, -1.6%]	1
All ❌✅ (primary)	0.5%	[-0.5%, 1.6%]	34

Max RSS (memory usage)

Results (primary 1.1%, secondary -2.3%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	9.5%	[5.0%, 14.0%]	2
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-3.2%	[-4.1%, -2.4%]	4
Improvements ✅ (secondary)	-2.3%	[-3.4%, -1.7%]	6
All ❌✅ (primary)	1.1%	[-4.1%, 14.0%]	6

Cycles

Results (primary 1.6%, secondary 1.7%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	1.6%	[1.1%, 2.4%]	7
Regressions ❌ (secondary)	2.5%	[2.0%, 2.9%]	4
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-1.5%	[-1.5%, -1.5%]	1
All ❌✅ (primary)	1.6%	[1.1%, 2.4%]	7

Binary size

Results (primary 0.4%, secondary 0.6%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.6%	[0.0%, 6.2%]	62
Regressions ❌ (secondary)	1.2%	[0.3%, 3.8%]	14
Improvements ✅ (primary)	-0.2%	[-0.4%, -0.0%]	15
Improvements ✅ (secondary)	-0.4%	[-3.1%, -0.0%]	9
All ❌✅ (primary)	0.4%	[-0.4%, 6.2%]	77

Bootstrap: 752.135s -> 753.574s (0.19%)
Artifact size: 338.76 MiB -> 338.74 MiB (-0.01%)

RalfJung · 2024-08-28T06:12:51Z

compiler/rustc_mir_transform/src/instsimplify.rs

        };
        let preserve_ub_checks =
            attr::contains_name(tcx.hir().krate_attrs(), sym::rustc_preserve_ub_checks);
+        let remove_ub_checks = tcx.has_attr(def_id, sym::rustc_no_ubchecks);


If we keep this attribute, the docs on the intrinsic should be updated.

compiler/rustc_feature/src/builtin_attrs.rs

bors · 2025-03-16T05:35:08Z

☔ The latest upstream changes (presumably #138548) made this pull request unmergeable. Please resolve the merge conflicts.

bors · 2025-04-10T23:44:22Z

☔ The latest upstream changes (presumably #137412) made this pull request unmergeable. Please resolve the merge conflicts.

bors · 2025-04-11T23:37:34Z

☔ The latest upstream changes (presumably #139689) made this pull request unmergeable. Please resolve the merge conflicts.

bors · 2025-07-22T22:09:38Z

☔ The latest upstream changes (presumably #144249) made this pull request unmergeable. Please resolve the merge conflicts.

saethlin · 2025-11-23T14:26:17Z

@bors try @rust-timer queue

Try enabling precondition checks on ptr::{read,write}

saethlin · 2025-11-23T14:56:05Z

@bors try cancel

rust-bors · 2025-11-23T14:56:08Z

Try build cancelled. Cancelled workflows:

https://github.com/rust-lang/rust/actions/runs/19612603418

saethlin · 2025-11-23T14:56:24Z

@bors try @rust-timer queue

Try enabling precondition checks on ptr::{read,write}

rust-bors · 2025-11-23T17:11:40Z

☀️ Try build successful (CI)
Build commit: b11b745 (b11b745213c55006c47ff931896c2b1a5cc1a260, parent: 23f708107b459ed551a860ef0bf8b61bc80b48b4)

rust-timer · 2025-11-23T19:46:20Z

Finished benchmarking commit (b11b745): comparison URL.

Overall result: ❌✅ regressions and improvements - please read the text below

Benchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please do so in sufficient writing along with @rustbot label: +perf-regression-triaged. If not, please fix the regressions and do another perf run. If its results are neutral or positive, the label will be automatically removed.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	0.5%	[0.2%, 1.5%]	43
Regressions ❌ (secondary)	0.5%	[0.0%, 1.3%]	15
Improvements ✅ (primary)	-0.9%	[-1.2%, -0.6%]	2
Improvements ✅ (secondary)	-0.2%	[-0.2%, -0.2%]	1
All ❌✅ (primary)	0.4%	[-1.2%, 1.5%]	45

Max RSS (memory usage)

Results (primary 1.0%, secondary 3.3%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	3.6%	[2.5%, 4.9%]	6
Regressions ❌ (secondary)	3.8%	[0.7%, 7.1%]	10
Improvements ✅ (primary)	-4.1%	[-6.8%, -1.8%]	3
Improvements ✅ (secondary)	-2.0%	[-2.0%, -2.0%]	1
All ❌✅ (primary)	1.0%	[-6.8%, 4.9%]	9

Cycles

Results (primary 2.0%, secondary -0.5%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	2.0%	[2.0%, 2.0%]	1
Regressions ❌ (secondary)	3.7%	[1.8%, 5.0%]	5
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-3.9%	[-6.6%, -1.3%]	6
All ❌✅ (primary)	2.0%	[2.0%, 2.0%]	1

Binary size

Results (primary 0.3%, secondary 0.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	0.3%	[0.0%, 1.0%]	60
Regressions ❌ (secondary)	0.2%	[0.1%, 0.3%]	13
Improvements ✅ (primary)	-0.3%	[-0.7%, -0.0%]	3
Improvements ✅ (secondary)	-0.4%	[-0.7%, -0.2%]	3
All ❌✅ (primary)	0.3%	[-0.7%, 1.0%]	63

Bootstrap: 469.836s -> 468.624s (-0.26%)
Artifact size: 386.24 MiB -> 388.11 MiB (0.48%)

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Aug 24, 2024

This comment has been minimized.

Sign in to view

rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Aug 24, 2024

This comment has been minimized.

Sign in to view

rustbot added perf-regression Performance regression. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels Aug 24, 2024

workingjubilee mentioned this pull request Aug 24, 2024

Pass fmt::Arguments by reference to PanicInfo and PanicMessage #129491

Merged

saethlin added S-experimental Status: Ongoing experiment that does not require reviewing and won't be merged in its current state. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 24, 2024

saethlin force-pushed the ptr-read-write-precondition branch from 0a65e30 to 3b756c6 Compare August 28, 2024 00:42

This comment has been minimized.

Sign in to view

rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Aug 28, 2024

saethlin mentioned this pull request Aug 28, 2024

Disabling particular unsafe precondition checks under -Cdebug-assertions=y #120969

Open

This comment has been minimized.

Sign in to view

rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Aug 28, 2024

RalfJung reviewed Aug 28, 2024

View reviewed changes

ojeda mentioned this pull request Aug 28, 2024

Rust wanted features Rust-for-Linux/linux#354

Open

47 tasks

saethlin force-pushed the ptr-read-write-precondition branch from 3b756c6 to d527afc Compare August 29, 2024 22:32

saethlin force-pushed the ptr-read-write-precondition branch from ddf0f53 to 579bfbd Compare March 14, 2025 17:00

scottmcm reviewed Mar 14, 2025

View reviewed changes

compiler/rustc_feature/src/builtin_attrs.rs Show resolved Hide resolved

saethlin force-pushed the ptr-read-write-precondition branch from 579bfbd to e374e85 Compare March 17, 2025 23:45

saethlin force-pushed the ptr-read-write-precondition branch from e374e85 to 038234b Compare April 11, 2025 11:18

saethlin force-pushed the ptr-read-write-precondition branch from 038234b to 73dc4d4 Compare April 12, 2025 01:13

saethlin force-pushed the ptr-read-write-precondition branch from 73dc4d4 to 3094d95 Compare November 23, 2025 14:25

This comment has been minimized.

Sign in to view

rust-bors bot added a commit that referenced this pull request Nov 23, 2025

Auto merge of #129498 - saethlin:ptr-read-write-precondition, r=<try>

ed1b5f2

Try enabling precondition checks on ptr::{read,write}

rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Nov 23, 2025

This comment has been minimized.

Sign in to view

Try enabling precondition checks on ptr::{read,write}

a416efa

saethlin force-pushed the ptr-read-write-precondition branch from 3094d95 to a416efa Compare November 23, 2025 14:55

This comment has been minimized.

Sign in to view

rust-bors bot added a commit that referenced this pull request Nov 23, 2025

Auto merge of #129498 - saethlin:ptr-read-write-precondition, r=<try>

b11b745

Try enabling precondition checks on ptr::{read,write}

This comment has been minimized.

Sign in to view

Bless

4af3fb6

rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Nov 23, 2025

Try enabling precondition checks on ptr::{read,write} #129498

Are you sure you want to change the base?

Try enabling precondition checks on ptr::{read,write} #129498

Conversation

saethlin commented Aug 24, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

saethlin commented Aug 24, 2024

Uh oh!

This comment has been minimized.

bors commented Aug 24, 2024

Uh oh!

bors commented Aug 24, 2024

Uh oh!

This comment has been minimized.

rust-timer commented Aug 24, 2024

Overall result: ❌✅ regressions and improvements - ACTION NEEDED

Uh oh!

saethlin commented Aug 28, 2024

Uh oh!

This comment has been minimized.

bors commented Aug 28, 2024

Uh oh!

This comment has been minimized.

bors commented Aug 28, 2024

Uh oh!

This comment has been minimized.

rust-timer commented Aug 28, 2024

Overall result: ❌✅ regressions and improvements - ACTION NEEDED

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

bors commented Mar 16, 2025

Uh oh!

bors commented Apr 10, 2025

Uh oh!

bors commented Apr 11, 2025

Uh oh!

bors commented Jul 22, 2025

Uh oh!

saethlin commented Nov 23, 2025

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

saethlin commented Nov 23, 2025

Uh oh!

rust-bors bot commented Nov 23, 2025

Uh oh!

saethlin commented Nov 23, 2025

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

rust-bors bot commented Nov 23, 2025

Uh oh!

This comment has been minimized.

rust-timer commented Nov 23, 2025

Overall result: ❌✅ regressions and improvements - please read the text below

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

saethlin commented Aug 24, 2024 •

edited

Loading