Skip to content

Conversation

RalfJung
Copy link
Member

As far as I can tell, even back when this was added it never enabled any optimizations. It just indicates that the FFI compat lint should accept those types for NPO.

@rustbot
Copy link
Collaborator

rustbot commented Sep 22, 2024

r? @nnethercote

rustbot has assigned @nnethercote.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Sep 22, 2024
@rustbot
Copy link
Collaborator

rustbot commented Sep 22, 2024

Some changes occurred to the CTFE / Miri interpreter

cc @rust-lang/miri

@rust-log-analyzer

This comment has been minimized.

Copy link
Member

@jieyouxu jieyouxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, r=me after reblessing the tests

@jieyouxu jieyouxu assigned jieyouxu and unassigned nnethercote Sep 22, 2024
@RalfJung RalfJung force-pushed the rustc_nonnull_optimization_guaranteed branch from 38900f5 to 8103505 Compare September 22, 2024 08:00
@RalfJung
Copy link
Member Author

RalfJung commented Sep 22, 2024 via email

@bors
Copy link
Collaborator

bors commented Sep 22, 2024

📌 Commit 8103505 has been approved by jieyouxu

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 22, 2024
@bors
Copy link
Collaborator

bors commented Sep 22, 2024

⌛ Testing commit 8103505 with merge 4ae36d9...

@bors
Copy link
Collaborator

bors commented Sep 22, 2024

☀️ Test successful - checks-actions
Approved by: jieyouxu
Pushing 4ae36d9 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Sep 22, 2024
@bors bors merged commit 4ae36d9 into rust-lang:master Sep 22, 2024
7 checks passed
@rustbot rustbot added this to the 1.83.0 milestone Sep 22, 2024
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (4ae36d9): comparison URL.

Overall result: ❌ regressions - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
1.9% [1.9%, 1.9%] 1
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) - - 0

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

Results (primary -1.7%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
0.5% [0.5%, 0.5%] 1
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-3.8% [-3.8%, -3.8%] 1
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) -1.7% [-3.8%, 0.5%] 2

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 769.195s -> 770.728s (0.20%)
Artifact size: 341.55 MiB -> 341.56 MiB (0.00%)

@RalfJung RalfJung deleted the rustc_nonnull_optimization_guaranteed branch September 23, 2024 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants