[DO NOT MERGE] bootstrap with `-Znext-solver=globally` #133502

lcnr · 2024-11-26T15:26:47Z

A revival of #124812. See

Current status:

~~./x.py b --stage 2 passes 🎉~~

try builds succeed 🎉 🎉 🎉

crater

This does not detect hangs or memory issues.

date	#crates	#regressions
2025.04.11	100	2
2025.04.11	1000	27
2025.04.17	10000	456
2025.04.18	10000	437
2025.04.24	10000	164
2025.04.26	10000	108
2025.04.28	10000	91
2025.05.01	10000	145 woops
2025.05.03	624228¹	1585²
2025.05.05	8964³	931²
2025.05.06	4401³	726²
2025.05.07	2704³	668²
2025.05.09	2345³	664²
2025.09.20	701952¹	4739 + 7039 spurious
2025.10.02	11712³	2568 + 2014 spurious
2025.10.04	4582³	1173 + 1147 spurious²

in-flight changes

r? @ghost

a complete crater run ↩ ↩²
with doubled recursion_limit when evaluating goals ↩ ↩² ↩³ ↩⁴ ↩⁵ ↩⁶
only testing crates which may have regressed from the above run ↩ ↩² ↩³ ↩⁴ ↩⁵ ↩⁶

compiler-errors · 2024-11-27T04:03:51Z

@bors try

[DO NOT MERGE] bootstrap with `-Znext-solver=globally` A revival of rust-lang#124812. Current status, we're failing in: - failing in `rustc_next_trait_solver` with 126 instances of the following error ``` error[E0311]: the parameter type `I` may not live long enough | help: consider adding an explicit lifetime bound --> compiler/rustc_next_trait_solver/src/solve/trait_goals.rs:624:53 | 624 ~ fn consider_structural_builtin_unsize_candidates<'a>( 625 ~ ecx: &mut EvalCtxt<'a, D>, 626 | goal: Goal<I, Self>, 627 ~ ) -> Vec<Candidate<I>> where I: 'a { ``` - `itertools` hangs, we're already encountered this hang in our previous attempt due to large type sizes. I believe that it's simply caused by a missing cache somewhere, potentially in `wf.rs`, but other visitors may also be responsible. See rust-itertools/itertools#945 for more details ### commits - rust-lang#133501 - rust-lang#133493 - 9456bfe and b21b116 reimplement candidate preference based on rust-lang#132325, not yet a separate PR - c3ef9cd is a rebased version of rust-lang#125334, unsure whether I actually want to land this PR for now r? `@ghost`

bors · 2024-11-27T04:05:03Z

⌛ Trying commit f631ca8 with merge ca04381...

compiler-errors · 2024-11-27T04:05:17Z

I also pushed:

I think this is sufficient to make the compiler build, or at least ./x.py build --stage=2 completes successfully on my local branch.

bors · 2024-11-27T06:15:40Z

💔 Test failed - checks-actions

bors · 2024-11-27T10:43:04Z

☔ The latest upstream changes (presumably #133527) made this pull request unmergeable. Please resolve the merge conflicts.

lqd · 2024-11-27T11:42:49Z

Next failure is on color-print-proc-macro-0.3.6 while building cargo.

pub fn repro() -> impl FnMut() {
    if true {
        || ()
    } else {
        || ()
    }
}

godbolt

compiler-errors · 2024-11-27T17:49:50Z

@bors try

[DO NOT MERGE] bootstrap with `-Znext-solver=globally` A revival of rust-lang#124812. Current status: `./x.py b --stage 2` passes 🎉 ### commits - rust-lang#133501 - rust-lang#133493 - 9456bfe and b21b116 reimplement candidate preference based on rust-lang#132325, not yet a separate PR - c3ef9cd is a rebased version of rust-lang#125334, unsure whether I actually want to land this PR for now - rust-lang#133517 * rust-lang#133518 * rust-lang#133519 * rust-lang#133520 * rust-lang#133521 * rust-lang#133524 r? `@ghost`

bors · 2024-11-27T17:51:02Z

⌛ Trying commit 6210ed3 with merge ac5ccad...

bors · 2024-11-27T20:03:42Z

💔 Test failed - checks-actions

compiler-errors · 2024-11-27T20:15:22Z

@bors try

[DO NOT MERGE] bootstrap with `-Znext-solver=globally` A revival of rust-lang#124812. Current status: `./x.py b --stage 2` passes 🎉 ### commits - rust-lang#133501 - rust-lang#133493 - 9456bfe and b21b116 reimplement candidate preference based on rust-lang#132325, not yet a separate PR - c3ef9cd is a rebased version of rust-lang#125334, unsure whether I actually want to land this PR for now - rust-lang#133517 * rust-lang#133518 * rust-lang#133519 * rust-lang#133520 * rust-lang#133521 * rust-lang#133524 r? `@ghost`

bors · 2024-11-27T20:16:33Z

⌛ Trying commit 8fa8f40 with merge 550ae0d...

lqd · 2024-11-27T20:26:10Z

I was reducing the new failure but you've already fixed it ^^

lcnr · 2025-10-02T10:24:03Z

@bors try

[DO NOT MERGE] bootstrap with `-Znext-solver=globally`

bors · 2025-10-02T11:30:37Z

☔ The latest upstream changes (presumably #147138) made this pull request unmergeable. Please resolve the merge conflicts.

we should not get the certainty from the current result of the provisional cache entry

…pre-fallback where we equate hidden types but do not report errors

rust-log-analyzer · 2025-10-02T12:14:04Z

The job aarch64-gnu-llvm-20-2 failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)

failures:

---- tests::test_unstable_options_tracking_hash stdout ----

thread 'tests::test_unstable_options_tracking_hash' (49929) panicked at compiler/rustc_interface/src/tests.rs:833:5:
assertion `left != right` failed
  left: NextSolverConfig { coherence: true, globally: true }
 right: NextSolverConfig { coherence: true, globally: true }
stack backtrace:
   0: __rustc::rust_begin_unwind
   1: core::panicking::panic_fmt
   2: core::panicking::assert_failed_inner
   3: core::panicking::assert_failed::<rustc_session::config::NextSolverConfig, rustc_session::config::NextSolverConfig>

rust-bors · 2025-10-02T12:37:51Z

☀️ Try build successful (CI)
Build commit: 149edce (149edce6c6ee840adb602803b96d083101ef3592, parent: 42b384ec0dfcd528d99a4db0a337d9188a9eecaa)

lcnr · 2025-10-02T12:40:12Z

@bors check crates=https://crater-reports.s3.amazonaws.com/pr-133502-15/retry-regressed-list.txt p=2

lcnr · 2025-10-02T12:40:23Z

@craterbot check crates=https://crater-reports.s3.amazonaws.com/pr-133502-15/retry-regressed-list.txt p=2

craterbot · 2025-10-02T12:40:32Z

👌 Experiment pr-133502-16 created and queued.
🤖 Automatically detected try build 149edce
⚠️ Try build based on commit 028c9a4, but latest commit is e3b862a. Did you forget to make a new try build?
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

lcnr · 2025-10-02T12:41:13Z

@craterbot p=1

craterbot · 2025-10-02T12:41:16Z

📝 Configuration of the pr-133502-16 experiment changed.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

craterbot · 2025-10-04T02:33:54Z

🚧 Experiment pr-133502-16 is now running

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

craterbot · 2025-10-04T04:57:09Z

🎉 Experiment pr-133502-16 is completed!
📊 1173 regressed and 0 fixed (4582 total)
📊 1147 spurious results on the retry-regessed-list.txt, consider a retry¹ if this is a significant amount.
📰 Open the summary report.

⚠️ If you notice any spurious failure please add them to the denylist!
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

re-run the experiment with crates=https://crater-reports.s3.amazonaws.com/pr-133502-16/retry-regressed-list.txt ↩

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver) labels Nov 26, 2024