Skip to content

Delete cat-and-grep-sanity-check #134762

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Delete cat-and-grep-sanity-check #134762

wants to merge 1 commit into from

Conversation

@jieyouxu
Copy link
Member

BLOCKED: should only be merged after all Makefile-based run-make tests are ported.

They were helper tests to check cat and grep behavior because
Makefile tests were relying on those utils. Now that we don't use
these tools, this test is no longer relevant.

Partially supersedes #129156.

r? @ghost

@jieyouxu @Oneirical
tests: delete cat-and-grep-sanity-check
162c747 
They were helper tests to check `cat` and `grep` behavior because
`Makefile` tests were relying on those utils. Now that we don't use
these tools, this test is no longer relevant.

Co-authored-by: Oneirical <manchot@videotron.ca>
@rustbot rustbot added A-run-make Area: port run-make Makefiles to rmake.rs A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Dec 25, 2024
@jieyouxu jieyouxu added S-blocked Status: Blocked on something else such as an RFC or other implementation work. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 25, 2024
@jieyouxu jieyouxu mentioned this pull request Dec 25, 2024
Closed
@bors
Copy link
Collaborator

bors commented Dec 28, 2024

☔ The latest upstream changes (presumably #134844) made this pull request unmergeable. Please resolve the merge conflicts.

@jieyouxu
Copy link
Member Author

I'm dumb and opened a new PR.

@jieyouxu jieyouxu closed this Jan 21, 2025
@jieyouxu jieyouxu deleted the delete-meow branch January 21, 2025 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

A-run-make Area: port run-make Makefiles to rmake.rs A-testsuite Area: The testsuite used to check the correctness of rustc S-blocked Status: Blocked on something else such as an RFC or other implementation work. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jieyouxu @bors @rustbot