Skip to content

Make (unstable API) UniqueRc invariant for soundness #135379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 12, 2025
Merged

Make (unstable API) UniqueRc invariant for soundness #135379

merged 1 commit into from
Jan 12, 2025

Conversation

@steffahn
Copy link
Member

@steffahn steffahn commented Jan 11, 2025

Add test case from #133572 (comment) (comment in review of UniqueArc), and fix the issue for UniqueRc.

@rustbot
Copy link
Collaborator

rustbot commented Jan 11, 2025

r? @estebank

rustbot has assigned @estebank.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jan 11, 2025
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@steffahn steffahn mentioned this pull request Jan 11, 2025
Open
5 tasks
@compiler-errors
Copy link
Member

compiler-errors commented Jan 11, 2025

lol, triagebot auto-rolled someone from compiler bc of the ui test

r? libs cc @eholk @Mark-Simulacrum (for the original pr)

@rustbot rustbot assigned cuviper and unassigned estebank Jan 11, 2025
@Mark-Simulacrum
Copy link
Member

Mark-Simulacrum commented Jan 11, 2025

@bors r+

Seems right.

@bors
Copy link
Collaborator

bors commented Jan 11, 2025

📌 Commit df57d65 has been approved by Mark-Simulacrum

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 11, 2025
@compiler-errors
Copy link
Member

compiler-errors commented Jan 11, 2025

Yeah, this is definitely right. Conceptually this is like having a mutex that you can pre-reserve a read guard.

@jhpratt jhpratt mentioned this pull request Jan 12, 2025
Closed
@matthiaskrgr matthiaskrgr mentioned this pull request Jan 12, 2025
Merged
@bors bors merged commit 89a7282 into rust-lang:master Jan 12, 2025
6 checks passed
@rustbot rustbot added this to the 1.86.0 milestone Jan 12, 2025
@RalfJung
Copy link
Member

RalfJung commented Jan 16, 2025

Do we have a corresponding test for UniqueArc?

@steffahn
Copy link
Member Author

steffahn commented Jan 16, 2025

We don’t have UniqueArc.

@RalfJung
Copy link
Member

RalfJung commented Jan 16, 2025

Ah. :) I didn't realize this is an Rc-only feature.

@steffahn
Copy link
Member Author

steffahn commented Jan 16, 2025

I should have added a “…yet”. UniqueArc is not implemented yet… the PR that contains an implementation is actually where I had shared this test case originally (as linked in this PR’s description).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@cuviper cuviper

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.86.0

Development

Successfully merging this pull request may close these issues.

9 participants

@steffahn @rustbot @rust-log-analyzer @compiler-errors @Mark-Simulacrum @bors @RalfJung @cuviper @estebank