Skip to content

Conversation

weihanglo
Copy link
Member

10 commits in 307cbfda3119f06600e43cd38283f4a746fe1f8b..a6c604d1b8a2f2a8ff1f3ba6092f9fda42f4b7e9
2025-03-20 20:00:39 +0000 to 2025-03-26 18:11:00 +0000

r? ghost

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 26, 2025
@rustbot
Copy link
Collaborator

rustbot commented Mar 26, 2025

Some changes occurred in src/tools/cargo

cc @ehuss

@weihanglo
Copy link
Member Author

@bors r+ rollup=never p=1

@bors
Copy link
Collaborator

bors commented Mar 27, 2025

📌 Commit 8f735d0 has been approved by weihanglo

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 27, 2025
@bors
Copy link
Collaborator

bors commented Mar 27, 2025

⌛ Testing commit 8f735d0 with merge 2216f26...

@bors
Copy link
Collaborator

bors commented Mar 27, 2025

☀️ Test successful - checks-actions
Approved by: weihanglo
Pushing 2216f26 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Mar 27, 2025
@bors bors merged commit 2216f26 into rust-lang:master Mar 27, 2025
7 checks passed
@rustbot rustbot added this to the 1.87.0 milestone Mar 27, 2025
Copy link
Contributor

What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 1644cb0 (parent) -> 2216f26 (this PR)

Test differences

Show 32944 test diffs

Stage 1

  • errors::verify_passes_cannot_stabilize_deprecated_153: pass -> [missing] (J0)
  • errors::verify_passes_invalid_macro_export_arguments_too_many_items_97: pass -> [missing] (J0)
  • lints::verify_lint_custom_inner_attribute_unstable_123: pass -> [missing] (J0)
  • persist::fs::tests::test_all_except_most_recent: pass -> [missing] (J0)
  • spec::tests::armv7_unknown_linux_musleabi: pass -> [missing] (J0)
  • spec::tests::thumbv7a_pc_windows_msvc: pass -> [missing] (J0)
  • tests::test_invalid_start: pass -> [missing] (J0)
  • unescape::tests::test_unescape_byte_bad: pass -> [missing] (J0)
  • arc::shared_from_iter_trustedlen_panic: pass -> [missing] (J1)
  • collections::linked_list::tests::test_iterator_double_end: pass -> [missing] (J1)
  • fmt::test_estimated_capacity: pass -> [missing] (J1)
  • io::buffered::tests::line_write_all: pass -> [missing] (J1)
  • io::tests::take_eof: pass -> [missing] (J1)
  • misc_tests::f64_slice: pass -> [missing] (J1)
  • mpsc_sync::port_gone_concurrent: pass -> [missing] (J1)
  • num::ieee754::neg_infinity_to_str: pass -> [missing] (J1)
  • option::test_ord: pass -> [missing] (J1)
  • rc::into_from_weak_raw: pass -> [missing] (J1)
  • rc::test_clone: pass -> [missing] (J1)
  • rwlock::test_rw_arc_poison_mapped_w_r: pass -> [missing] (J1)
  • slice::swap_panics::index_b_greater_than_len: pass -> [missing] (J1)
  • slice::test_array_chunks_nth_back: pass -> [missing] (J1)
  • slice::test_clear: pass -> [missing] (J1)
  • slice::test_rchunks_mut_nth_back: pass -> [missing] (J1)
  • sort::tests::stable::panic_retain_orig_set_cell_i32_random_z1: pass -> [missing] (J1)
  • sort::tests::unstable::fixed_seed: pass -> [missing] (J1)
  • test_checked_add: pass -> [missing] (J1)
  • vec::test_extend_from_within_zst: pass -> [missing] (J1)
  • btree::map::first_and_last_0_nightly: pass -> [missing] (J2)
  • char::methods::bench_ascii_char_to_uppercase: pass -> [missing] (J2)
  • fs::tests::canonicalize_works_simple: pass -> [missing] (J2)
  • hash::sip::bench_str_over_8_bytes: pass -> [missing] (J2)
  • iter::bench_skip_while_ref_sum: pass -> [missing] (J2)
  • linked_list::bench_iter: pass -> [missing] (J2)
  • num::bench_i32_from_str_radix_2: pass -> [missing] (J2)
  • sort::tests::stable::correct_string_ascending: pass -> [missing] (J2)
  • sort::tests::unstable::deterministic_string_ascending: pass -> [missing] (J2)
  • str::contains_bang_char::short_mixed: pass -> [missing] (J2)
  • str::starts_with_unichar::short_mixed: pass -> [missing] (J2)
  • tests::parse_include_ignored_flag: pass -> [missing] (J2)

Stage 2

  • clean::types::tests::is_same_generic: [missing] -> pass (J0)
  • edit_distance::tests::test_find_best_match_for_name: [missing] -> pass (J0)
  • errors::verify_ast_passes_extern_fn_qualifiers_23: [missing] -> pass (J0)
  • errors::verify_codegen_ssa_invalid_monomorphization_cannot_return_120: [missing] -> pass (J0)
  • errors::verify_codegen_ssa_metadata_object_file_write_86: [missing] -> pass (J0)
  • errors::verify_expand_duplicate_matcher_binding_35: [missing] -> pass (J0)
  • errors::verify_expand_empty_delegation_mac_39: [missing] -> pass (J0)
  • errors::verify_incremental_hard_link_failed_25: [missing] -> pass (J0)
  • errors::verify_incremental_not_dirty_10: [missing] -> pass (J0)
  • errors::verify_parse_assignment_else_not_allowed_39: [missing] -> pass (J0)
  • errors::verify_parse_left_arrow_operator_28: [missing] -> pass (J0)
  • errors::verify_passes_rustc_allow_const_fn_unstable_82: [missing] -> pass (J0)
  • errors::verify_session_unsupported_dwarf_version_18: [missing] -> pass (J0)
  • html::render::ordered_json::tests::string: [missing] -> pass (J0)
  • html::render::sorted_template::tests::blank_js: [missing] -> pass (J0)
  • interval::tests::last_set_before_adjacent: [missing] -> pass (J0)
  • lints::verify_lint_raw_prefix_131: [missing] -> pass (J0)
  • parser::tests::multiple_labels_secondary_without_message: [missing] -> pass (J0)
  • spec::tests::hexagon_unknown_none_elf: [missing] -> pass (J0)
  • spec::tests::xtensa_esp32_none_elf: [missing] -> pass (J0)
  • alloc::layout_array_edge_cases: [missing] -> pass (J1)
  • collections::btree::map::tests::test_append_17: [missing] -> pass (J1)
  • collections::hash::map::tests::test_entry: [missing] -> pass (J1)
  • collections::hash::map::tests::test_values: [missing] -> pass (J1)
  • f16::test_zero: [missing] -> pass (J1)
  • f32::test_minimum: [missing] -> pass (J1)
  • future::test_join_function_like_value_arg_semantics::join_lets_control_flow_effects_such_as_try_flow_through: [missing] -> pass (J1)
  • io::cursor::tests::test_buf_writer: [missing] -> pass (J1)
  • io::tests::io_slice_as_slice: [missing] -> pass (J1)
  • iter::adapters::peekable::test_iterator_peekable_fold: [missing] -> pass (J1)
  • mpsc::smoke_shared_port_gone2: [missing] -> pass (J1)
  • num::dec2flt::inf: [missing] -> pass (J1)
  • num::i64::test_signed_checked_div: [missing] -> pass (J1)
  • num::test_try_i64i64: [missing] -> pass (J1)
  • rc::test_simple: [missing] -> pass (J1)
  • slice::test_flatten_size_overflow: [missing] -> pass (J1)
  • slice::test_iter_ref_consistency: [missing] -> pass (J1)
  • slice::test_last_mut: [missing] -> pass (J1)
  • sort::tests::stable::correct_i32_pipe_organ: [missing] -> pass (J1)
  • str::test_iterator_advance: [missing] -> pass (J1)
  • string::test_str_clear: [missing] -> pass (J1)
  • sync::test_dead: [missing] -> pass (J1)
  • sync::try_unwrap: [missing] -> pass (J1)
  • test_uint_to_str_overflow: [missing] -> pass (J1)
  • thread::tests::test_unnamed_thread: [missing] -> pass (J1)
  • btree::map::clone_slim_10k_and_drain_all: [missing] -> pass (J2)
  • btree::set::clone_100_and_remove_all: [missing] -> pass (J2)
  • btree::set::intersection_10k_pos_vs_10k_neg: [missing] -> pass (J2)
  • fs::tests::file_lock_blocking: [missing] -> pass (J2)
  • fs::tests::read_large_dir: [missing] -> pass (J2)
  • num::bench_i8_from_str_radix_10: [missing] -> pass (J2)
  • process::tests::test_process_output_output: [missing] -> pass (J2)
  • sort::tests::stable::correct_u128_ascending: [missing] -> pass (J2)
  • sort::tests::unstable::observable_is_less_random_d20: [missing] -> pass (J2)
  • sort::tests::unstable::self_cmp_i32_descending: [missing] -> pass (J2)
  • sort::tests::unstable::violate_ord_retain_orig_set_string_random: [missing] -> pass (J2)
  • str::char_count::ru_medium::case02_iter_increment: [missing] -> pass (J2)
  • vec::bench_clone_0100: [missing] -> pass (J2)
  • num::flt2dec::strategy::grisu::exact_sanity_test: [missing] -> ignore (J3)
  • sort::tests::stable::deterministic_string_ascending: [missing] -> ignore (J3)

(and 16374 additional test diffs)

Additionally, 16470 doctest diffs were found. These are ignored, as they are noisy.

Job group index

  • J0: aarch64-apple, x86_64-apple-1
  • J1: aarch64-apple, test-various, x86_64-apple-1, x86_64-gnu-aux
  • J2: aarch64-apple, test-various, x86_64-apple-1
  • J3: x86_64-gnu-aux

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (2216f26): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (primary 1.3%, secondary -0.1%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
1.3% [1.3%, 1.3%] 1
Regressions ❌
(secondary)
2.4% [2.4%, 2.4%] 1
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-2.6% [-2.6%, -2.6%] 1
All ❌✅ (primary) 1.3% [1.3%, 1.3%] 1

Cycles

Results (primary 2.1%, secondary -2.2%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
2.1% [2.1%, 2.1%] 1
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-2.2% [-2.8%, -1.6%] 11
All ❌✅ (primary) 2.1% [2.1%, 2.1%] 1

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 777.476s -> 778.377s (0.12%)
Artifact size: 365.76 MiB -> 365.79 MiB (0.01%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants