Introduce debuginfo to statements in MIR #142771

dianqk · 2025-06-20T07:16:46Z

Not ready for reviewing. Something known:

Retain debuginfo when concatenating bbs
Document about when to drop debuginfos (don't be worse than the optimized LLVM IR)
Missing tests

r? ghost

compiler/rustc_middle/src/mir/mod.rs

dianqk · 2025-06-20T10:52:57Z

@bors2 try @rust-timer queue

rust-bors · 2025-06-20T10:53:00Z

⌛ Trying commit 51576e7 with merge eb83156…

To cancel the try build, run the command @bors2 try cancel.

Introduce debuginfo to statements in MIR Not ready for reviewing. Something known: - [ ] Retain debuginfo when concatenating bbs - [ ] Document about when to drop debuginfos (don't be worse than the optimized LLVM IR) - [ ] Missing tests r? ghost

rust-bors · 2025-06-20T13:23:31Z

☀️ Try build successful (CI)
Build commit: eb83156 (eb83156169ae3bbdd1385d498455dbc44283f5ff, parent: 18491d5be00eb3ed2f1ccee2ac5b792694f2a7a0)

rust-timer · 2025-06-20T23:32:50Z

Finished benchmarking commit (eb83156): comparison URL.

Overall result: ❌✅ regressions and improvements - please read the text below

Benchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please do so in sufficient writing along with @rustbot label: +perf-regression-triaged. If not, please fix the regressions and do another perf run. If its results are neutral or positive, the label will be automatically removed.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	0.9%	[0.2%, 14.5%]	51
Regressions ❌ (secondary)	0.8%	[0.1%, 1.6%]	52
Improvements ✅ (primary)	-0.4%	[-2.1%, -0.2%]	35
Improvements ✅ (secondary)	-0.3%	[-0.5%, -0.2%]	39
All ❌✅ (primary)	0.4%	[-2.1%, 14.5%]	86

Max RSS (memory usage)

Results (primary 2.3%, secondary 3.4%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	2.3%	[0.8%, 4.7%]	54
Regressions ❌ (secondary)	3.6%	[0.7%, 7.4%]	38
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-3.3%	[-3.3%, -3.3%]	1
All ❌✅ (primary)	2.3%	[0.8%, 4.7%]	54

Cycles

Results (primary 3.2%, secondary 2.5%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	3.9%	[1.1%, 14.4%]	7
Regressions ❌ (secondary)	2.5%	[2.0%, 3.3%]	3
Improvements ✅ (primary)	-2.0%	[-2.0%, -2.0%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	3.2%	[-2.0%, 14.4%]	8

Binary size

Results (primary 0.5%, secondary 0.3%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	0.7%	[0.0%, 2.2%]	123
Regressions ❌ (secondary)	1.1%	[0.0%, 3.5%]	59
Improvements ✅ (primary)	-0.9%	[-6.5%, -0.1%]	11
Improvements ✅ (secondary)	-0.5%	[-13.0%, -0.1%]	55
All ❌✅ (primary)	0.5%	[-6.5%, 2.2%]	134

Bootstrap: 691.482s -> 692.445s (0.14%)
Artifact size: 371.94 MiB -> 372.12 MiB (0.05%)

dianqk · 2025-06-21T02:59:42Z

@bors2 try @rust-timer queue

rust-bors · 2025-06-21T02:59:46Z

⌛ Trying commit e72c3ae with merge 77d5c6a…

To cancel the try build, run the command @bors2 try cancel.

Introduce debuginfo to statements in MIR Not ready for reviewing. Something known: - [ ] Retain debuginfo when concatenating bbs - [ ] Document about when to drop debuginfos (don't be worse than the optimized LLVM IR) - [ ] Missing tests r? ghost

rust-bors · 2025-06-21T05:28:30Z

☀️ Try build successful (CI)
Build commit: 77d5c6a (77d5c6a20a77fabdee3790a412618b82178e9ab4, parent: 15c701fbc995eb6c5b3a86021c18185f8eee020d)

rust-timer · 2025-06-21T09:26:06Z

Finished benchmarking commit (77d5c6a): comparison URL.

Overall result: ❌✅ regressions and improvements - please read the text below

Benchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please do so in sufficient writing along with @rustbot label: +perf-regression-triaged. If not, please fix the regressions and do another perf run. If its results are neutral or positive, the label will be automatically removed.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	0.9%	[0.1%, 14.5%]	53
Regressions ❌ (secondary)	0.8%	[0.1%, 1.6%]	50
Improvements ✅ (primary)	-0.4%	[-3.0%, -0.2%]	46
Improvements ✅ (secondary)	-0.3%	[-0.5%, -0.2%]	41
All ❌✅ (primary)	0.3%	[-3.0%, 14.5%]	99

Max RSS (memory usage)

Results (primary 2.4%, secondary 3.4%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	2.4%	[0.5%, 5.7%]	38
Regressions ❌ (secondary)	4.2%	[1.3%, 6.2%]	25
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-1.7%	[-3.0%, -1.1%]	4
All ❌✅ (primary)	2.4%	[0.5%, 5.7%]	38

Cycles

Results (primary 2.1%, secondary 0.5%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	3.0%	[0.8%, 14.1%]	10
Regressions ❌ (secondary)	3.3%	[2.3%, 4.3%]	2
Improvements ✅ (primary)	-2.3%	[-2.9%, -1.7%]	2
Improvements ✅ (secondary)	-2.2%	[-2.6%, -1.9%]	2
All ❌✅ (primary)	2.1%	[-2.9%, 14.1%]	12

Binary size

Results (primary 0.5%, secondary 0.3%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	0.7%	[0.0%, 3.0%]	122
Regressions ❌ (secondary)	1.1%	[0.0%, 3.5%]	59
Improvements ✅ (primary)	-0.7%	[-4.9%, -0.0%]	15
Improvements ✅ (secondary)	-0.5%	[-12.7%, -0.0%]	55
All ❌✅ (primary)	0.5%	[-4.9%, 3.0%]	137

Bootstrap: 690.617s -> 691.47s (0.12%)
Artifact size: 371.83 MiB -> 372.01 MiB (0.05%)

bors · 2025-06-25T18:27:45Z

☔ The latest upstream changes (presumably #142870) made this pull request unmergeable. Please resolve the merge conflicts.

rust-bors · 2025-06-26T12:59:34Z

☀️ Try build successful (CI)
Build commit: 41dabab (41dabab6772d7c4c5eda8fbba8b6d17bd79b457f, parent: 1e838527f18cd24c81547ce6fbef6815032a80a7)

rust-timer · 2025-06-27T01:17:52Z

Finished benchmarking commit (41dabab): comparison URL.

Overall result: ❌✅ regressions and improvements - please read the text below

Benchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please do so in sufficient writing along with @rustbot label: +perf-regression-triaged. If not, please fix the regressions and do another perf run. If its results are neutral or positive, the label will be automatically removed.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	0.8%	[0.1%, 14.6%]	53
Regressions ❌ (secondary)	0.8%	[0.2%, 1.4%]	43
Improvements ✅ (primary)	-0.3%	[-1.7%, -0.2%]	48
Improvements ✅ (secondary)	-0.3%	[-1.0%, -0.2%]	58
All ❌✅ (primary)	0.3%	[-1.7%, 14.6%]	101

Max RSS (memory usage)

Results (primary 2.4%, secondary 3.9%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	2.6%	[0.6%, 11.0%]	64
Regressions ❌ (secondary)	3.9%	[1.1%, 5.9%]	31
Improvements ✅ (primary)	-5.7%	[-5.7%, -5.7%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	2.4%	[-5.7%, 11.0%]	65

Cycles

Results (primary 3.4%, secondary 2.3%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	4.5%	[1.2%, 14.2%]	5
Regressions ❌ (secondary)	2.3%	[2.1%, 2.7%]	3
Improvements ✅ (primary)	-1.9%	[-1.9%, -1.9%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	3.4%	[-1.9%, 14.2%]	6

Binary size

Results (primary 0.4%, secondary 0.3%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	0.7%	[0.0%, 2.2%]	113
Regressions ❌ (secondary)	1.1%	[0.0%, 3.5%]	58
Improvements ✅ (primary)	-0.4%	[-6.5%, -0.1%]	37
Improvements ✅ (secondary)	-0.5%	[-12.7%, -0.1%]	56
All ❌✅ (primary)	0.4%	[-6.5%, 2.2%]	150

Bootstrap: 691.88s -> 689.868s (-0.29%)
Artifact size: 372.13 MiB -> 372.10 MiB (-0.01%)

dianqk · 2025-06-29T12:13:07Z

Probably most of the results are from inlining, as I have removed all debuginfos for dead statements. I will continue the remaining content.

Use the `new` method for `BasicBlockData` and `Statement` This is the NFC part of rust-lang#142771. I split it to make it easier to review for rust-lang#142771. Even without rust-lang#142771, I think this change is worthwhile.

Rollup merge of #143190 - dianqk:new-method, r=oli-obk Use the `new` method for `BasicBlockData` and `Statement` This is the NFC part of #142771. I split it to make it easier to review for #142771. Even without #142771, I think this change is worthwhile.

bors · 2025-06-30T18:44:33Z

☔ The latest upstream changes (presumably #143233) made this pull request unmergeable. Please resolve the merge conflicts.

Ensure they are always created using constructors.

`-Copt-level=0` (`-Zmir-opt-level=1`) is preferred for debugging.

Use the `new` method for `BasicBlockData` and `Statement` This is the NFC part of rust-lang/rust#142771. I split it to make it easier to review for rust-lang/rust#142771. Even without rust-lang/rust#142771, I think this change is worthwhile.

rust-log-analyzer · 2025-07-01T13:35:47Z

The job x86_64-gnu-llvm-19 failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)

 - LegacyKeyValueFormat: "ENV key=value" should be used instead of legacy "ENV key value" format (line 48)
 - LegacyKeyValueFormat: "ENV key=value" should be used instead of legacy "ENV key value" format (line 51)
 - LegacyKeyValueFormat: "ENV key=value" should be used instead of legacy "ENV key value" format (line 68)
##[endgroup]
Setting extra environment values for docker:  --env ENABLE_GCC_CODEGEN=1 --env GCC_EXEC_PREFIX=/usr/lib/gcc/
[CI_JOB_NAME=x86_64-gnu-llvm-19]
[CI_JOB_NAME=x86_64-gnu-llvm-19]
debug: `DISABLE_CI_RUSTC_IF_INCOMPATIBLE` configured.
---
sccache: Listening on address 127.0.0.1:4226
##[group]Configure the build
configure: processing command line
configure: 
configure: build.configure-args := ['--build=x86_64-unknown-linux-gnu', '--llvm-root=/usr/lib/llvm-19', '--enable-llvm-link-shared', '--set', 'rust.randomize-layout=true', '--set', 'rust.thin-lto-import-instr-limit=10', '--set', 'build.print-step-timings', '--enable-verbose-tests', '--set', 'build.metrics', '--enable-verbose-configure', '--enable-sccache', '--disable-manage-submodules', '--enable-locked-deps', '--enable-cargo-native-static', '--set', 'rust.codegen-units-std=1', '--set', 'dist.compression-profile=balanced', '--dist-compression-formats=xz', '--set', 'rust.lld=false', '--disable-dist-src', '--release-channel=nightly', '--enable-debug-assertions', '--enable-overflow-checks', '--enable-llvm-assertions', '--set', 'rust.verify-llvm-ir', '--set', 'rust.codegen-backends=llvm,cranelift,gcc', '--set', 'llvm.static-libstdcpp', '--set', 'gcc.download-ci-gcc=true', '--enable-new-symbol-mangling']
configure: build.build          := x86_64-unknown-linux-gnu
configure: target.x86_64-unknown-linux-gnu.llvm-config := /usr/lib/llvm-19/bin/llvm-config
configure: llvm.link-shared     := True
configure: rust.randomize-layout := True
configure: rust.thin-lto-import-instr-limit := 10
---
  Number of decisions:   4439
  longest path:          1159 (code:    152)
  longest backtrack:       66 (code:    428)
Shared 87642 out of 154040 states by creating 14936 new states, saving 72706
/checkout/obj/build/x86_64-unknown-linux-gnu/gcc/src/gcc/expmed.cc: In function ‘rtx_def* extract_bit_field_1(rtx, poly_uint64, poly_uint64, int, rtx, machine_mode, machine_mode, bool, bool, rtx_def**)’:
/checkout/obj/build/x86_64-unknown-linux-gnu/gcc/src/gcc/expmed.cc:1864:45: warning: ‘*(unsigned int*)((char*)&imode + offsetof(scalar_int_mode, scalar_int_mode::m_mode))’ may be used uninitialized [-Wmaybe-uninitialized]
 1864 |       rtx sub = extract_bit_field_as_subreg (mode1, op0, imode,
      |                 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~
 1865 |                                              bitsize, bitnum);
      |                                              ~~~~~~~~~~~~~~~~
/checkout/obj/build/x86_64-unknown-linux-gnu/gcc/src/gcc/expmed.cc:1824:19: note: ‘*(unsigned int*)((char*)&imode + offsetof(scalar_int_mode, scalar_int_mode::m_mode))’ was declared here
 1824 |   scalar_int_mode imode;
      |                   ^~~~~
/checkout/obj/build/x86_64-unknown-linux-gnu/gcc/src/gcc/gimple-range-gori.cc: In member function ‘void range_def_chain::dump(FILE*, basic_block, const char*)’:
/checkout/obj/build/x86_64-unknown-linux-gnu/gcc/src/gcc/gimple-range-gori.cc:318:19: warning: format not a string literal and no format arguments [-Wformat-security]
  318 |           fprintf (f, prefix);
      |           ~~~~~~~~^~~~~~~~~~~
---
                 from /checkout/obj/build/x86_64-unknown-linux-gnu/gcc/src/gcc/analyzer/region-model.h:33,
                 from /checkout/obj/build/x86_64-unknown-linux-gnu/gcc/src/gcc/analyzer/access-diagram.cc:38:
In constructor ‘ana::byte_range::byte_range(ana::byte_offset_t, ana::byte_size_t)’,
    inlined from ‘virtual text_art::table ana::string_literal_spatial_item::make_table(const ana::bit_to_table_map&, text_art::style_manager&) const’ at /checkout/obj/build/x86_64-unknown-linux-gnu/gcc/src/gcc/analyzer/access-diagram.cc:1811:18:
/checkout/obj/build/x86_64-unknown-linux-gnu/gcc/src/gcc/analyzer/store.h:312:5: warning: ‘size_in_bytes.generic_wide_int<fixed_wide_int_storage<128> >::fixed_wide_int_storage<128>.fixed_wide_int_storage<128>::val[1]’ may be used uninitialized [-Wmaybe-uninitialized]
  312 |     m_size_in_bytes (size_in_bytes)
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/checkout/obj/build/x86_64-unknown-linux-gnu/gcc/src/gcc/analyzer/access-diagram.cc: In member function ‘virtual text_art::table ana::string_literal_spatial_item::make_table(const ana::bit_to_table_map&, text_art::style_manager&) const’:
/checkout/obj/build/x86_64-unknown-linux-gnu/gcc/src/gcc/analyzer/access-diagram.cc:1807:28: note: ‘size_in_bytes.generic_wide_int<fixed_wide_int_storage<128> >::fixed_wide_int_storage<128>.fixed_wide_int_storage<128>::val[1]’ was declared here
 1807 |                byte_size_t size_in_bytes
      |                            ^~~~~~~~~~~~~
/checkout/obj/build/x86_64-unknown-linux-gnu/gcc/src/gcc/diagnostic.cc: In function ‘void fancy_abort(const char*, int, const char*)’:
/checkout/obj/build/x86_64-unknown-linux-gnu/gcc/src/gcc/diagnostic.cc:1729:15: warning: format not a string literal and no format arguments [-Wformat-security]
 1729 |       fnotice (stderr, diagnostic_kind_text[DK_ICE]);
---
/checkout/obj/build/x86_64-unknown-linux-gnu/gcc/src/gcc/gcc.cc:7938:9: warning: ignoring return value of ‘ssize_t write(int, const void*, size_t)’ declared with attribute ‘warn_unused_result’ [-Wunused-result]
 7938 |   write (fd, "\n\n", 2);
      |   ~~~~~~^~~~~~~~~~~~~~~
/checkout/obj/build/x86_64-unknown-linux-gnu/gcc/src/gcc/gcc.cc: In member function ‘void driver::final_actions() const’:
/checkout/obj/build/x86_64-unknown-linux-gnu/gcc/src/gcc/gcc.cc:9315:13: warning: ignoring return value of ‘int truncate(const char*, __off_t)’ declared with attribute ‘warn_unused_result’ [-Wunused-result]
 9315 |     truncate(totruncate_file, 0);
      |     ~~~~~~~~^~~~~~~~~~~~~~~~~~~~
/checkout/obj/build/x86_64-unknown-linux-gnu/gcc/src/gcc/lto/lto-common.cc: In function ‘void lto_resolution_read(splay_tree, FILE*, lto_file*)’:
/checkout/obj/build/x86_64-unknown-linux-gnu/gcc/src/gcc/lto/lto-common.cc:2095:10: warning: ignoring return value of ‘int fscanf(FILE*, const char*, ...)’ declared with attribute ‘warn_unused_result’ [-Wunused-result]
 2095 |   fscanf (resolution, " ");   /* Read white space.  */
      |   ~~~~~~~^~~~~~~~~~~~~~~~~
/checkout/obj/build/x86_64-unknown-linux-gnu/gcc/src/gcc/lto/lto-common.cc:2097:9: warning: ignoring return value of ‘size_t fread(void*, size_t, size_t, FILE*)’ declared with attribute ‘warn_unused_result’ [-Wunused-result]
 2097 |   fread (obj_name, sizeof (char), name_len, resolution);
      |   ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/checkout/obj/build/x86_64-unknown-linux-gnu/gcc/src/gcc/lto/lto-common.cc:2117:10: warning: ignoring return value of ‘int fscanf(FILE*, const char*, ...)’ declared with attribute ‘warn_unused_result’ [-Wunused-result]
 2117 |   fscanf (resolution, "%u", &num_symbols);
      |   ~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/checkout/obj/build/x86_64-unknown-linux-gnu/gcc/src/gcc/../libgcc/libgcov-util.c: In function ‘gcov_info* gcov_read_profile_dir(const char*, int)’:
---
Applying io_quotes_use            to linux/blkzoned.h
Applying io_quotes_use            to linux/aspeed-p2a-ctrl.h
Applying io_quotes_use            to linux/vduse.h
Applying io_quotes_use            to linux/blkpg.h
Applying io_quotes_use            to linux/tps6594_pfsm.h
Applying io_quotes_use            to linux/uinput.h
Applying io_quotes_use            to linux/sockios.h
Applying io_quotes_use            to linux/usb/tmc.h
Applying io_quotes_use            to linux/nbd.h
Applying io_quotes_def            to linux/version.h
---
Applying io_quotes_def            to sudo_plugin.h
Applying io_quotes_use            to sudo_plugin.h
Applying io_quotes_use            to video/sisfb.h
Applying io_quotes_use            to scsi/cxlflash_ioctl.h
Applying io_quotes_use            to misc/mrvl_cn10k_dpi.h
Applying io_quotes_use            to misc/ocxl.h
Applying io_quotes_use            to misc/xilinx_sdfec.h
Applying io_quotes_use            to misc/cxl.h
Applying sun_malloc               to malloc.h
Applying machine_name             to openssl/e_os2.h
Applying io_quotes_use            to drm/exynos_drm.h
Applying io_quotes_use            to drm/qaic_accel.h
Applying io_quotes_use            to drm/amdgpu_drm.h
Applying io_quotes_use            to drm/xe_drm.h
Applying io_quotes_use            to drm/lima_drm.h
Applying io_quotes_use            to drm/omap_drm.h
Applying io_quotes_use            to drm/msm_drm.h
Applying io_quotes_use            to drm/vgem_drm.h
Applying io_quotes_use            to drm/vc4_drm.h
Applying io_quotes_use            to drm/drm.h
Applying io_quotes_use            to drm/tegra_drm.h
Applying io_quotes_use            to drm/habanalabs_accel.h
Applying io_quotes_use            to drm/v3d_drm.h
Applying io_quotes_use            to drm/etnaviv_drm.h
Applying io_quotes_use            to drm/i915_drm.h
Applying io_quotes_use            to drm/radeon_drm.h
Applying io_quotes_use            to drm/nouveau_drm.h
Applying io_quotes_use            to drm/panfrost_drm.h
Applying io_quotes_use            to drm/pvr_drm.h
Applying io_quotes_use            to sys/epoll.h
Applying machine_name             to sys/rseq.h
Applying io_quotes_use            to sys/raw.h
Applying io_quotes_use            to sys/mount.h
Applying machine_name             to sys/mount.h
---
---- [mir-opt] tests/mir-opt/inline/inline_diverging.rs stdout ----

error: compilation failed!
status: exit status: 101
command: env -u RUSTC_LOG_COLOR RUSTC_ICE="0" RUST_BACKTRACE="short" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/tests/mir-opt/inline/inline_diverging.rs" "-Zthreads=1" "-Zsimulate-remapped-rust-src-base=/rustc/FAKE_PREFIX" "-Ztranslate-remapped-path-to-local-path=no" "-Z" "ignore-directory-in-diagnostics-source-blocks=/cargo" "-Z" "ignore-directory-in-diagnostics-source-blocks=/checkout/vendor" "--sysroot" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2" "--target=i686-unknown-linux-gnu" "--check-cfg" "cfg(test,FALSE)" "-O" "-Copt-level=1" "-Zdump-mir=Inline | Inline | Inline" "-Zvalidate-mir" "-Zlint-mir" "-Zdump-mir-exclude-pass-number" "-Zmir-include-spans=false" "--crate-type=rlib" "-Zmir-opt-level=4" "-Zmir-enable-passes=+ReorderBasicBlocks,+ReorderLocals" "-Zdump-mir-dir=/checkout/obj/build/x86_64-unknown-linux-gnu/test/mir-opt/inline/inline_diverging" "--emit" "mir" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/mir-opt/inline/inline_diverging" "-A" "internal_features" "-Crpath" "-Zinline-mir-hint-threshold=1000" "-C" "debuginfo=full"
stdout: none
--- stderr -------------------------------
invalid expression
!DIExpression(4096, 0, 32, 159)
rustc-LLVM ERROR: Broken module found, compilation aborted!

rustbot added A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jun 20, 2025

This comment has been minimized.

Sign in to view

dianqk force-pushed the mir-stmt-debuginfo branch from 15c968a to 6b013d4 Compare June 20, 2025 08:01

This comment has been minimized.

Sign in to view

bjorn3 reviewed Jun 20, 2025

View reviewed changes

compiler/rustc_middle/src/mir/mod.rs Show resolved Hide resolved

dianqk force-pushed the mir-stmt-debuginfo branch from 6b013d4 to 51576e7 Compare June 20, 2025 09:23

This comment has been minimized.

Sign in to view

rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jun 20, 2025

This comment has been minimized.

Sign in to view

rustbot added perf-regression Performance regression. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels Jun 20, 2025

dianqk force-pushed the mir-stmt-debuginfo branch from 51576e7 to e72c3ae Compare June 21, 2025 02:31

This comment has been minimized.

Sign in to view

rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jun 21, 2025

This comment has been minimized.

Sign in to view

rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jun 21, 2025

This comment has been minimized.

Sign in to view

rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jun 27, 2025

dianqk force-pushed the mir-stmt-debuginfo branch from a8787f9 to 09baa30 Compare June 29, 2025 12:13

This comment has been minimized.

Sign in to view

dianqk mentioned this pull request Jun 29, 2025

Use the new method for BasicBlockData and Statement #143190

Merged

dianqk added 2 commits July 1, 2025 07:14

mir: Mark Statement and BasicBlockData as #[non_exhaustive]

90e0835

Ensure they are always created using constructors.

mir: Introduce an empty StmtDebugInfo

e14f065

dianqk force-pushed the mir-stmt-debuginfo branch from 09baa30 to c9f55c8 Compare June 30, 2025 23:28

dianqk added 5 commits July 1, 2025 07:34

mir-opt: Eliminate dead ref statements

faaedfd

mir-opt: Eliminate trivial unnecessary storage annotations

1e8f98b

codegen: Generate dbg_value for the ref statement

c4192d6

mir-opt: Eliminate statements need debuginfo when mir-opt-level >= 2

edce7af

`-Copt-level=0` (`-Zmir-opt-level=1`) is preferred for debugging.

inline: Drop debuginfos if drop var debuginfos

de6058a

dianqk force-pushed the mir-stmt-debuginfo branch from c9f55c8 to de6058a Compare June 30, 2025 23:34

This comment has been minimized.

Sign in to view

debuginfo: Add a test case for dead statements

4b6b459

rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Jul 1, 2025

This comment has been minimized.

Sign in to view

dianqk force-pushed the mir-stmt-debuginfo branch from 2517556 to 4b6b459 Compare July 1, 2025 12:43

dianqk removed A-testsuite Area: The testsuite used to check the correctness of rustc T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Jul 1, 2025

Introduce debuginfo to statements in MIR #142771

Are you sure you want to change the base?

Introduce debuginfo to statements in MIR #142771

Conversation

dianqk commented Jun 20, 2025

Uh oh!

This comment has been minimized.

This comment has been minimized.

Uh oh!

This comment has been minimized.

dianqk commented Jun 20, 2025

Uh oh!

This comment has been minimized.

rust-bors bot commented Jun 20, 2025

Uh oh!

rust-bors bot commented Jun 20, 2025

Uh oh!

This comment has been minimized.

rust-timer commented Jun 20, 2025

Overall result: ❌✅ regressions and improvements - please read the text below

Uh oh!

dianqk commented Jun 21, 2025

Uh oh!

This comment has been minimized.

rust-bors bot commented Jun 21, 2025

Uh oh!

This comment has been minimized.

rust-bors bot commented Jun 21, 2025

Uh oh!

This comment has been minimized.

rust-timer commented Jun 21, 2025

Overall result: ❌✅ regressions and improvements - please read the text below

Uh oh!

bors commented Jun 25, 2025

Uh oh!

rust-bors bot commented Jun 26, 2025

Uh oh!

This comment has been minimized.

rust-timer commented Jun 27, 2025

Overall result: ❌✅ regressions and improvements - please read the text below

Uh oh!

dianqk commented Jun 29, 2025

Uh oh!

This comment has been minimized.

bors commented Jun 30, 2025

Uh oh!

This comment has been minimized.

This comment has been minimized.

rust-log-analyzer commented Jul 1, 2025

Uh oh!

Uh oh!