Skip to content

rustdoc new default faviocon #143178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

eeshvardasikcm
Copy link

@eeshvardasikcm eeshvardasikcm commented Jun 29, 2025

#143154
default favicon now appears to be the new behavior, instead of no favicon.

@rustbot rustbot added the T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. label Jun 29, 2025
@eeshvardasikcm eeshvardasikcm changed the title Update the-doc-attribute.md (#1) Update the-doc-attribute.md Jun 29, 2025
@eeshvardasikcm eeshvardasikcm changed the title Update the-doc-attribute.md new default faviocon Jun 29, 2025
@eeshvardasikcm eeshvardasikcm marked this pull request as ready for review June 29, 2025 09:08
@rustbot
Copy link
Collaborator

rustbot commented Jun 29, 2025

r? @notriddle

rustbot has assigned @notriddle.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 29, 2025
@rustbot
Copy link
Collaborator

rustbot commented Jun 29, 2025

⚠️ Warning ⚠️

  • There are issue links (such as #123) in the commit messages of the following commits.
    Please move them to the PR description, to avoid spamming the issues with references to the commit, and so this bot can automatically canonicalize them to avoid issues with subtree.

@eeshvardasikcm
Copy link
Author

eeshvardasikcm commented Jun 29, 2025

I think this is the correct branch. I don't have authorization to push here. The issue that prompted this pull request said this is an easy task for new rust contributors. Maybe someone has permissions for this to get it merged. I reeearched a little bit and master branch appears correct. Just following instructions.

@eeshvardasikcm eeshvardasikcm changed the title new default faviocon rustdoc new default faviocon Jun 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants