Skip to content

Constify Try, From, TryFrom and relevant traits #143768

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 21, 2025
Merged

Constify Try, From, TryFrom and relevant traits #143768

merged 1 commit into from
Jul 21, 2025

Conversation

Randl
Copy link
Contributor

@Randl Randl commented Jul 11, 2025

No description provided.

@rustbot
Copy link
Collaborator

rustbot commented Jul 11, 2025

r? @davidtwco

rustbot has assigned @davidtwco.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jul 11, 2025
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@Randl
Copy link
Contributor Author

Randl commented Jul 11, 2025

I can reproduce the fail locally but I do not understand why it happens and how it is related to the changes.

@bors
Copy link
Collaborator

bors commented Jul 13, 2025

☔ The latest upstream changes (presumably #143888) made this pull request unmergeable. Please resolve the merge conflicts.

oli-obk
oli-obk reviewed Jul 17, 2025
View reviewed changes
oli-obk
oli-obk reviewed Jul 17, 2025
View reviewed changes
oli-obk
oli-obk reviewed Jul 18, 2025
View reviewed changes
@Randl
Copy link
Contributor Author

Randl commented Jul 19, 2025

r? @oli-obk

@rustbot rustbot assigned oli-obk and unassigned davidtwco Jul 19, 2025
@Randl Randl mentioned this pull request Jul 20, 2025
Open
@oli-obk
Copy link
Contributor

oli-obk commented Jul 20, 2025

Please squash the commits when CI is green

oli-obk
oli-obk reviewed Jul 21, 2025
View reviewed changes
oli-obk
oli-obk reviewed Jul 21, 2025
View reviewed changes
oli-obk
oli-obk reviewed Jul 21, 2025
View reviewed changes
oli-obk
oli-obk reviewed Jul 21, 2025
View reviewed changes
oli-obk
oli-obk reviewed Jul 21, 2025
View reviewed changes
oli-obk
oli-obk reviewed Jul 21, 2025
View reviewed changes
oli-obk
oli-obk reviewed Jul 21, 2025
View reviewed changes
@oli-obk
Copy link
Contributor

oli-obk commented Jul 21, 2025

Please squash when the last comment has been addressed

@oli-obk oli-obk mentioned this pull request Jul 18, 2025
Open
3 tasks
@oli-obk
Copy link
Contributor

oli-obk commented Jul 21, 2025

Thanks!

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Jul 21, 2025

📌 Commit 3c76e3d has been approved by oli-obk

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 21, 2025
jieyouxu added a commit to jieyouxu/rust that referenced this pull request Jul 21, 2025
@jieyouxu
Rollup merge of rust-lang#143768 - Randl:const-try, r=oli-obk
fcb6d9f 
Constify Try, From, TryFrom and relevant traits
@jieyouxu jieyouxu mentioned this pull request Jul 21, 2025
Closed
jieyouxu added a commit to jieyouxu/rust that referenced this pull request Jul 21, 2025
@jieyouxu
Rollup merge of rust-lang#143768 - Randl:const-try, r=oli-obk
4e76990 
Constify Try, From, TryFrom and relevant traits
@jieyouxu jieyouxu mentioned this pull request Jul 21, 2025
Closed
bors added a commit that referenced this pull request Jul 21, 2025
@bors
Auto merge of #144262 - jieyouxu:rollup-wxgtyr0, r=jieyouxu
006f365 
Rollup of 15 pull requests

Successful merges:

 - #142097 (gpu offload host code generation)
 - #143430 (Lower extra lifetimes before normal generic params.)
 - #143672 (Fix Box allocator drop elaboration)
 - #143768 (Constify Try, From, TryFrom and relevant traits)
 - #143816 (Implement `check` for compiletest and RA using tool macro)
 - #143985 (rustc_public: de-StableMIR-ize)
 - #144027 (clippy: make tests work in stage 1)
 - #144080 (Mitigate `#[align]` name resolution ambiguity regression with a rename)
 - #144176 (Add approval blocking labels for new bors)
 - #144187 (fix handling of base address for TypeId allocations)
 - #144212 (Remove the ptr_unique lang item)
 - #144243 (Subtree update of `rust-analyzer`)
 - #144246 (Don't use another main test file as auxiliary)
 - #144251 (rustc-dev-guide subtree update)
 - #144254 (opt-dist: make `artifact-dir` an absolute path for `opt-dist local`)

r? `@ghost`
`@rustbot` modify labels: rollup
@jieyouxu jieyouxu mentioned this pull request Jul 21, 2025
Merged
bors added a commit that referenced this pull request Jul 21, 2025
@bors
Auto merge of #144269 - jieyouxu:rollup-137ysl2, r=jieyouxu
9748d87 
Rollup of 14 pull requests

Successful merges:

 - #142097 (gpu offload host code generation)
 - #143430 (Lower extra lifetimes before normal generic params.)
 - #143768 (Constify Try, From, TryFrom and relevant traits)
 - #143816 (Implement `check` for compiletest and RA using tool macro)
 - #143985 (rustc_public: de-StableMIR-ize)
 - #144027 (clippy: make tests work in stage 1)
 - #144080 (Mitigate `#[align]` name resolution ambiguity regression with a rename)
 - #144176 (Add approval blocking labels for new bors)
 - #144187 (fix handling of base address for TypeId allocations)
 - #144212 (Remove the ptr_unique lang item)
 - #144243 (Subtree update of `rust-analyzer`)
 - #144246 (Don't use another main test file as auxiliary)
 - #144251 (rustc-dev-guide subtree update)
 - #144254 (opt-dist: make `artifact-dir` an absolute path for `opt-dist local`)

r? `@ghost`
`@rustbot` modify labels: rollup
@oli-obk oli-obk mentioned this pull request Jul 21, 2025
Closed
3 tasks
@bors bors merged commit 1f8b531 into rust-lang:master Jul 21, 2025
11 checks passed
@rustbot rustbot added this to the 1.90.0 milestone Jul 21, 2025
rust-timer added a commit that referenced this pull request Jul 21, 2025
@rust-timer
Unrolled build for #143768
6bcbf85 
Rollup merge of #143768 - Randl:const-try, r=oli-obk

Constify Try, From, TryFrom and relevant traits
github-actions bot pushed a commit to rust-lang/miri that referenced this pull request Jul 22, 2025
@bors
Auto merge of #144269 - jieyouxu:rollup-137ysl2, r=jieyouxu
44b1876 
Rollup of 14 pull requests

Successful merges:

 - rust-lang/rust#142097 (gpu offload host code generation)
 - rust-lang/rust#143430 (Lower extra lifetimes before normal generic params.)
 - rust-lang/rust#143768 (Constify Try, From, TryFrom and relevant traits)
 - rust-lang/rust#143816 (Implement `check` for compiletest and RA using tool macro)
 - rust-lang/rust#143985 (rustc_public: de-StableMIR-ize)
 - rust-lang/rust#144027 (clippy: make tests work in stage 1)
 - rust-lang/rust#144080 (Mitigate `#[align]` name resolution ambiguity regression with a rename)
 - rust-lang/rust#144176 (Add approval blocking labels for new bors)
 - rust-lang/rust#144187 (fix handling of base address for TypeId allocations)
 - rust-lang/rust#144212 (Remove the ptr_unique lang item)
 - rust-lang/rust#144243 (Subtree update of `rust-analyzer`)
 - rust-lang/rust#144246 (Don't use another main test file as auxiliary)
 - rust-lang/rust#144251 (rustc-dev-guide subtree update)
 - rust-lang/rust#144254 (opt-dist: make `artifact-dir` an absolute path for `opt-dist local`)

r? `@ghost`
`@rustbot` modify labels: rollup
@jieyouxu
Copy link
Member

Hi bors this already merged
@bors r-

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 22, 2025
@jieyouxu jieyouxu added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. merged-by-bors This PR was explicitly merged by bors. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 22, 2025
github-actions bot pushed a commit to rust-lang/rustc-dev-guide that referenced this pull request Jul 24, 2025
@bors
Auto merge of #144269 - jieyouxu:rollup-137ysl2, r=jieyouxu
7a77909 
Rollup of 14 pull requests

Successful merges:

 - rust-lang/rust#142097 (gpu offload host code generation)
 - rust-lang/rust#143430 (Lower extra lifetimes before normal generic params.)
 - rust-lang/rust#143768 (Constify Try, From, TryFrom and relevant traits)
 - rust-lang/rust#143816 (Implement `check` for compiletest and RA using tool macro)
 - rust-lang/rust#143985 (rustc_public: de-StableMIR-ize)
 - rust-lang/rust#144027 (clippy: make tests work in stage 1)
 - rust-lang/rust#144080 (Mitigate `#[align]` name resolution ambiguity regression with a rename)
 - rust-lang/rust#144176 (Add approval blocking labels for new bors)
 - rust-lang/rust#144187 (fix handling of base address for TypeId allocations)
 - rust-lang/rust#144212 (Remove the ptr_unique lang item)
 - rust-lang/rust#144243 (Subtree update of `rust-analyzer`)
 - rust-lang/rust#144246 (Don't use another main test file as auxiliary)
 - rust-lang/rust#144251 (rustc-dev-guide subtree update)
 - rust-lang/rust#144254 (opt-dist: make `artifact-dir` an absolute path for `opt-dist local`)

r? `@ghost`
`@rustbot` modify labels: rollup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oli-obk oli-obk oli-obk left review comments

Assignees

@oli-obk oli-obk

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.90.0
Development

Successfully merging this pull request may close these issues.
7 participants
@Randl @rustbot @rust-log-analyzer @bors @oli-obk @jieyouxu @davidtwco