Add some pre-codegen MIR tests for debug mode #144875
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because the follow-up commits will affect it, and the goal is to show how.
rustbot
added
S-waiting-on-review
scottmcm
commented
Aug 4, 2025
| } | ||
|
|
||
| bb3: { | ||
| _0 = <Option<u32> as FromResidual<Option<Infallible>>>::from_residual(const Option::<Infallible>::None) -> [return: bb4, unwind unreachable]; |
There was a problem hiding this comment.
This is particularly unfortunate because it's really just _0 = None, so the call is about as wasteful as is possible.
|
R=me once ci passes |
|
@bors r=cjgillot |
bors
added
S-waiting-on-bors
Zalathar
added a commit
to Zalathar/rust
that referenced
this pull request
Aug 4, 2025
Add some pre-codegen MIR tests for debug mode No functional changes; just some tests. I made these for rust-lang#144483, but that's going in a different direction, so I wanted to propose we just add them to help see the impact of other related changes in the future. r? mir
This was referenced Aug 4, 2025
rust-timer
added a commit
that referenced
this pull request
Aug 4, 2025
Rollup merge of #144875 - scottmcm:more-mir-tests, r=cjgillot Add some pre-codegen MIR tests for debug mode No functional changes; just some tests. I made these for #144483, but that's going in a different direction, so I wanted to propose we just add them to help see the impact of other related changes in the future. r? mir
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No functional changes; just some tests.
I made these for #144483, but that's going in a different direction, so I wanted to propose we just add them to help see the impact of other related changes in the future.
r? mir