Skip to content

std: move thread into sys #145177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

std: move thread into sys #145177

wants to merge 3 commits into from

Conversation

joboet
Copy link
Member

@joboet joboet commented Aug 9, 2025

Part of #117276.

@rustbot
Copy link
Collaborator

rustbot commented Aug 9, 2025

r? @ChrisDenton

rustbot has assigned @ChrisDenton.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added O-hermit Operating System: Hermit O-SGX Target: SGX O-solid Operating System: SOLID O-unix Operating system: Unix-like O-wasi Operating system: Wasi, Webassembly System Interface O-wasm Target: WASM (WebAssembly), http://webassembly.org/ O-windows Operating system: Windows S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Aug 9, 2025
@joboet joboet mentioned this pull request Aug 9, 2025
Open
25 tasks
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rustbot
Copy link
Collaborator

rustbot commented Aug 9, 2025

The Miri subtree was changed

cc @rust-lang/miri

@bors
Copy link
Collaborator

bors commented Aug 15, 2025

☔ The latest upstream changes (presumably #145450) made this pull request unmergeable. Please resolve the merge conflicts.

@ChrisDenton
Copy link
Member

Sorry for the delay, I'm not keeping on top of my review queue right now so I'll assign someone else.

r? libs

@rustbot rustbot assigned ibraheemdev and unassigned ChrisDenton Aug 23, 2025
@rustbot
Copy link
Collaborator

rustbot commented Aug 29, 2025

This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@joboet
Copy link
Member Author

joboet commented Aug 29, 2025

I've split out the renaming part into a separate commit in order to simplify the diff. Unfortunately, the UNIX one is still rather large due to the amount of code movement. https://semanticdiff.com/ makes it nice and simple, but unfortunately requires signing in so I can't share a link (maybe someone knows of a better alternative?).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ibraheemdev ibraheemdev

Labels
O-hermit Operating System: Hermit O-SGX Target: SGX O-solid Operating System: SOLID O-unix Operating system: Unix-like O-wasi Operating system: Wasi, Webassembly System Interface O-wasm Target: WASM (WebAssembly), http://webassembly.org/ O-windows Operating system: Windows S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@joboet @rustbot @rust-log-analyzer @bors @ChrisDenton @ibraheemdev