Skip to content

Conversation

GuillaumeGomez
Copy link
Member

@rustbot rustbot added A-CI Area: Our Github Actions CI A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Sep 10, 2025
@GuillaumeGomez GuillaumeGomez changed the title Run rust tests with GCC backend Run tests with GCC backend Sep 10, 2025
@Kobzol
Copy link
Member

Kobzol commented Sep 10, 2025

We can also specify the doc_url of the job (

doc_url: https://rustc-dev-guide.rust-lang.org/tests/rust-for-linux.html
) to this: https://rustc-dev-guide.rust-lang.org/tests/codegen-backend-tests/cg_gcc.html

@GuillaumeGomez GuillaumeGomez force-pushed the run-test-with-gcc-backend branch from e2d0466 to 2c2dac0 Compare September 10, 2025 16:32
@rust-log-analyzer

This comment has been minimized.

@GuillaumeGomez GuillaumeGomez force-pushed the run-test-with-gcc-backend branch 2 times, most recently from dfd72e4 to bbdbe70 Compare September 10, 2025 17:53
@rust-log-analyzer

This comment has been minimized.

@GuillaumeGomez GuillaumeGomez force-pushed the run-test-with-gcc-backend branch 2 times, most recently from 6bcf347 to 3a3bcf7 Compare September 10, 2025 18:24
@rust-log-analyzer

This comment has been minimized.

@GuillaumeGomez GuillaumeGomez force-pushed the run-test-with-gcc-backend branch from 3a3bcf7 to 0efa10e Compare September 10, 2025 19:32
@GuillaumeGomez
Copy link
Member Author

Error in ui tests:

2025-09-10T20:29:55.1757480Z -	error: couldn't load codegen backend /checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/codegen-backends/librustc_codegen_gcc-1.91.0-nightly.so: libgccjit.so.0: cannot open shared object file: No such file or directory
2025-09-10T20:29:55.1758929Z +	error: couldn't load codegen backend $BUILD_DIR/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/codegen-backends/librustc_codegen_gcc-1.91.0-nightly.so: libgccjit.so.0: cannot open shared object file: No such file or directory

Seems like something went wrong with the build/install of libgccjit. Any idea @Kobzol? I thought libgccjit was built with bootstrap if download-ci-gcc was set to false but maybe I misunderstood something.

@tgross35
Copy link
Contributor

Is the .so actually in the load path? For some reason the GCC backend works differently than clif for me locally and I often find I need to manually append LD_LIBRARY_PATH, wonder if it could be something similar here.

@GuillaumeGomez
Copy link
Member Author

Arf, it's the usual case of "it works locally for me". :-/

Gonna try to investigate if it's something wrong with paths.

@GuillaumeGomez
Copy link
Member Author

Seems like we don't copy the .so files when we build gcc unlike when we download it.

Zalathar added a commit to Zalathar/rust that referenced this pull request Sep 12, 2025
…eGomez

Fix `libgccjit` symlink when we build GCC locally

Unblocks rust-lang#146414.

r? `@GuillaumeGomez`
Zalathar added a commit to Zalathar/rust that referenced this pull request Sep 12, 2025
…eGomez

Fix `libgccjit` symlink when we build GCC locally

Unblocks rust-lang#146414.

r? ``@GuillaumeGomez``
Zalathar added a commit to Zalathar/rust that referenced this pull request Sep 12, 2025
…eGomez

Fix `libgccjit` symlink when we build GCC locally

Unblocks rust-lang#146414.

r? ```@GuillaumeGomez```
rust-timer added a commit that referenced this pull request Sep 12, 2025
Rollup merge of #146449 - Kobzol:gcc-fix-symlink, r=GuillaumeGomez

Fix `libgccjit` symlink when we build GCC locally

Unblocks #146414.

r? ```@GuillaumeGomez```
@GuillaumeGomez GuillaumeGomez force-pushed the run-test-with-gcc-backend branch from 0efa10e to 7d861fe Compare September 12, 2025 16:01
@rustbot

This comment has been minimized.

github-actions bot pushed a commit to rust-lang/miri that referenced this pull request Sep 13, 2025
Fix `libgccjit` symlink when we build GCC locally

Unblocks rust-lang/rust#146414.

r? ```@GuillaumeGomez```
@rust-bors
Copy link

rust-bors bot commented Oct 13, 2025

Unknown argument "aarch64-gnu". Run @bors2 help to see available commands.

@GuillaumeGomez
Copy link
Member Author

@bors try jobs=aarch64-gnu

rust-bors bot added a commit that referenced this pull request Oct 13, 2025
…try>

Add a CI job that runs a subset of UI tests with the GCC backend

try-job: aarch64-gnu
@rust-bors

This comment has been minimized.

@GuillaumeGomez
Copy link
Member Author

So I didn't think of testing without the GCC backend. ^^'

@rust-bors
Copy link

rust-bors bot commented Oct 13, 2025

☀️ Try build successful (CI)
Build commit: 19c765a (19c765a48d5ae3d58ecdca5b3b0e078e980ced2e, parent: ed1d94311e7ed53eabb5667ef577802d88d1aaee)

@GuillaumeGomez
Copy link
Member Author

Let's try again. :')

@bors r=Kobzol p=6

@bors
Copy link
Collaborator

bors commented Oct 13, 2025

📌 Commit 9d15d66 has been approved by Kobzol

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 13, 2025
bors added a commit that referenced this pull request Oct 13, 2025
…obzol

Add a CI job that runs a subset of UI tests with the GCC backend

Part of rust-lang/compiler-team#891.

r? `@Kobzol`
@bors
Copy link
Collaborator

bors commented Oct 13, 2025

⌛ Testing commit 9d15d66 with merge 3b4f330...

@bors
Copy link
Collaborator

bors commented Oct 14, 2025

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Oct 14, 2025
@GuillaumeGomez
Copy link
Member Author

Hum weird. I can't access the logs. Oh well.

@bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 14, 2025
@bors
Copy link
Collaborator

bors commented Oct 14, 2025

⌛ Testing commit 9d15d66 with merge 2f7620a...

@bors
Copy link
Collaborator

bors commented Oct 14, 2025

☀️ Test successful - checks-actions
Approved by: Kobzol
Pushing 2f7620a to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Oct 14, 2025
@bors bors merged commit 2f7620a into rust-lang:master Oct 14, 2025
13 checks passed
@rustbot rustbot added this to the 1.92.0 milestone Oct 14, 2025
@GuillaumeGomez GuillaumeGomez deleted the run-test-with-gcc-backend branch October 14, 2025 12:32
Copy link
Contributor

What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing fb24b04 (parent) -> 2f7620a (this PR)

Test differences

Show 2 test diffs

2 doctest diffs were found. These are ignored, as they are noisy.

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 2f7620a5ccfea7d59d1f500e2a2e59cf1c867a1b --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. aarch64-apple: 13328.0s -> 8761.6s (-34.3%)
  2. dist-aarch64-linux: 8676.9s -> 6288.1s (-27.5%)
  3. x86_64-rust-for-linux: 3142.5s -> 2657.1s (-15.4%)
  4. aarch64-gnu-debug: 4477.2s -> 3854.3s (-13.9%)
  5. aarch64-gnu-llvm-20-1: 3666.5s -> 3196.9s (-12.8%)
  6. aarch64-gnu-llvm-20-2: 2411.6s -> 2122.3s (-12.0%)
  7. dist-aarch64-apple: 7848.9s -> 7065.3s (-10.0%)
  8. dist-x86_64-musl: 8299.2s -> 7502.6s (-9.6%)
  9. dist-loongarch64-linux: 5195.3s -> 5635.7s (8.5%)
  10. arm-android: 6158.9s -> 5657.5s (-8.1%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (2f7620a): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 474.864s -> 475.635s (0.16%)
Artifact size: 388.45 MiB -> 388.48 MiB (0.01%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-CI Area: Our Github Actions CI A-testsuite Area: The testsuite used to check the correctness of rustc merged-by-bors This PR was explicitly merged by bors. PG-exploit-mitigations Project group: Exploit mitigations S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants