-
Notifications
You must be signed in to change notification settings - Fork 14k
1.91.0 release notes #148013
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1.91.0 release notes #148013
Conversation
|
Hi relnotes-interest-group, this issue/PR could use some help in reviewing / cc @alex-semenyuk @jieyouxu @joshtriplett @Kobzol @lcnr @traviscross |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
| To get `.crate` tarballs as final artifacts, use `cargo package`. | ||
| In the next version, this change will apply regardless of `build.build-dir`. | ||
| [#15910](https://github.com/rust-lang/cargo/pull/15910) | ||
| - Adjust Cargo messages to match rustc diagnostic style. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this a compatibility note?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Per discussion on Zulip (I think you were in the thread), this may cause people to want to alter their editor/terminal's color schemes. I definitely did.
I'm open to dropping it or moving it to the Cargo section, but that's my rationale.
|
Does #147959 need a release notes entry? |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
548849c to
53bc9cc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Corrected my own suggestions; apologies for the erroneous original wording!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, looks good to me modulo a few nits
b8e8051 to
f28ed4c
Compare
Co-authored-by: Kevin Reid <kpreid@switchb.org>
|
@bors r+ rollup |
This imports #147010 into a PR in preparation for the release next week. It also imports a subset of the Cargo release notes (cc @rust-lang/cargo).
r? @rust-lang/release
@TriageBot ping relnotes-interest-group