Skip to content

Conversation

@ZuseZ4
Copy link
Member

@ZuseZ4 ZuseZ4 commented Nov 7, 2025

The recommended way to build the offload project changed.
While already at it, testing how much overhead we get from building (or shipping) the two runtimes.

r? @Kobzol

@rustbot
Copy link
Collaborator

rustbot commented Nov 7, 2025

This PR changes how LLVM is built. Consider updating src/bootstrap/download-ci-llvm-stamp.

@rustbot rustbot added A-CI Area: Our Github Actions CI A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Nov 7, 2025
@ZuseZ4
Copy link
Member Author

ZuseZ4 commented Nov 7, 2025

@bors2 try @rust-timer queue

(@Kobzol feel free to change if you want to see something else).

@rust-timer

This comment has been minimized.

@rust-bors

This comment has been minimized.

rust-bors bot added a commit that referenced this pull request Nov 7, 2025
@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Nov 7, 2025
@rust-log-analyzer

This comment has been minimized.

@rust-bors
Copy link

rust-bors bot commented Nov 7, 2025

💔 Test for 7069335 failed: CI. Failed jobs:

@rust-log-analyzer

This comment has been minimized.

@ZuseZ4
Copy link
Member Author

ZuseZ4 commented Nov 7, 2025

@bors2 try @rust-timer queue

@rust-timer

This comment has been minimized.

rust-bors bot added a commit that referenced this pull request Nov 7, 2025
@rust-bors

This comment has been minimized.

@rust-log-analyzer

This comment has been minimized.

@rust-bors
Copy link

rust-bors bot commented Nov 7, 2025

💔 Test for 31000c9 failed: CI. Failed jobs:

@ZuseZ4
Copy link
Member Author

ZuseZ4 commented Nov 8, 2025

@bors2 try @rust-timer queue

@rust-timer

This comment has been minimized.

@rust-bors

This comment has been minimized.

rust-bors bot added a commit that referenced this pull request Nov 8, 2025
@rust-log-analyzer

This comment has been minimized.

@rust-bors
Copy link

rust-bors bot commented Nov 8, 2025

💔 Test for de7bdfa failed: CI. Failed jobs:

@ZuseZ4
Copy link
Member Author

ZuseZ4 commented Nov 14, 2025

@bors2 try @rust-timer queue

@rust-timer

This comment has been minimized.

@rust-bors

This comment has been minimized.

@rustbot
Copy link
Collaborator

rustbot commented Dec 16, 2025

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@ZuseZ4
Copy link
Member Author

ZuseZ4 commented Dec 16, 2025

@bors try

@rust-bors

This comment has been minimized.

rust-bors bot added a commit that referenced this pull request Dec 16, 2025
@rust-log-analyzer
Copy link
Collaborator

The job pr-check-2 failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)
[RUSTC-TIMING] build_helper test:false 0.705
error: useless use of `format!`
    --> src/bootstrap/src/core/build_steps/compile.rs:2308:33
     |
2308 |                 let libenzyme = format!("libLLVMOffload");
     |                                 ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"libLLVMOffload".to_string()`
     |
     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
     = note: `-D clippy::useless-format` implied by `-D warnings`
     = help: to override `-D warnings` add `#[allow(clippy::useless_format)]`

error: useless use of `format!`
    --> src/bootstrap/src/core/build_steps/compile.rs:2317:31
     |
2317 |                     let omp = format!("libomp");
     |                               ^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"libomp".to_string()`
     |
     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format

error: useless use of `format!`
    --> src/bootstrap/src/core/build_steps/compile.rs:2324:31
     |
2324 |                     let tgt = format!("libomptarget");
     |                               ^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"libomptarget".to_string()`
     |
     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format

error: useless use of `format!`
    --> src/bootstrap/src/core/build_steps/compile.rs:2335:34
     |
2335 |                     let device = format!("libompdevice.a");
     |                                  ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"libompdevice.a".to_string()`
     |
     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format

error: the borrowed expression implements the required traits
    --> src/bootstrap/src/core/build_steps/compile.rs:2337:55
     |
2337 |                         let dst_tgt_dir = libdir.join(&tgt);
     |                                                       ^^^^ help: change this to: `tgt`
     |
     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
     = note: `-D clippy::needless-borrows-for-generic-args` implied by `-D warnings`
     = help: to override `-D warnings` add `#[allow(clippy::needless_borrows_for_generic_args)]`

error: the borrowed expression implements the required traits
    --> src/bootstrap/src/core/build_steps/compile.rs:2338:69
     |
2338 |                         let target_tgt_dst_dir = target_libdir.join(&tgt);
     |                                                                     ^^^^ help: change this to: `tgt`
     |
     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args

[RUSTC-TIMING] bootstrap test:false 9.886
error: could not compile `bootstrap` (lib) due to 6 previous errors

@rust-bors
Copy link

rust-bors bot commented Dec 16, 2025

☀️ Try build successful (CI)
Build commit: 4df11ec (4df11ecebe9814b078b13ccddd761d7c00933a49, parent: 61cc47e367d7be91e13bcd01e4e96e0e233d4f6d)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-CI Area: Our Github Actions CI A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants