Skip to content

Conversation

@weihanglo
Copy link
Member

13 commits in 2d4fa139552ebdd5f091a1401ed03f7dc62cb43f..5c0343317ce45d2ec17ecf41eaa473a02d73e29c
2025-11-12 15:56:06 +0000 to 2025-11-18 19:05:44 +0000

@weihanglo weihanglo self-assigned this Nov 19, 2025
@rustbot
Copy link
Collaborator

rustbot commented Nov 19, 2025

Some changes occurred in src/tools/cargo

cc @ehuss

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 19, 2025
@rustbot
Copy link
Collaborator

rustbot commented Nov 19, 2025

⚠️ Warning ⚠️

@weihanglo
Copy link
Member Author

@bors r+ rollup=never p=1

@bors
Copy link
Collaborator

bors commented Nov 19, 2025

📌 Commit 96d760c has been approved by weihanglo

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 19, 2025
bors added a commit that referenced this pull request Nov 19, 2025
Update cargo submodule

13 commits in 2d4fa139552ebdd5f091a1401ed03f7dc62cb43f..5c0343317ce45d2ec17ecf41eaa473a02d73e29c
2025-11-12 15:56:06 +0000 to 2025-11-18 19:05:44 +0000
- feat: emit a warning when both `package.publish` and `--index` are specified (rust-lang/cargo#16268)
- docs(cargo-yank): clarify yank behavior with leaked credentials (rust-lang/cargo#16274)
- feat(generate-lockfile): Add unstable --publish-time flag  (rust-lang/cargo#16265)
- Do not lock the artifact-dir for check builds (rust-lang/cargo#16230)
- fix(fingerprint): force update mtime of cargo-check artifacts (rust-lang/cargo#16262)
- fix(manifest): Point out when a key belongs to config (rust-lang/cargo#16256)
- Use raw false during cfg test (rust-lang/cargo#16261)
- Suppress metadata warnings for non–crates.io publishable packages (rust-lang/cargo#16241)
- feat(tree): Support long forms for --format variables (rust-lang/cargo#16204)
- fix(config): Fallback to non-canonical path for workspace-path-hash (rust-lang/cargo#16248)
- fix: update mtime for generated files after unpacking (rust-lang/cargo#16250)
- feat(cli): Add support for completing `--config` values in Bash (rust-lang/cargo#16245)
- feat: Add a typos CI job (rust-lang/cargo#16122)
@bors
Copy link
Collaborator

bors commented Nov 19, 2025

⌛ Testing commit 96d760c with merge 392f5ec...

@bors
Copy link
Collaborator

bors commented Nov 19, 2025

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Nov 19, 2025
@rust-log-analyzer
Copy link
Collaborator

A job failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)

@ehuss
Copy link
Contributor

ehuss commented Nov 19, 2025

@bors retry
Could not resolve host: github.com

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 19, 2025
@bors
Copy link
Collaborator

bors commented Nov 19, 2025

⌛ Testing commit 96d760c with merge c1f6e19...

bors added a commit that referenced this pull request Nov 19, 2025
Update cargo submodule

13 commits in 2d4fa139552ebdd5f091a1401ed03f7dc62cb43f..5c0343317ce45d2ec17ecf41eaa473a02d73e29c
2025-11-12 15:56:06 +0000 to 2025-11-18 19:05:44 +0000
- feat: emit a warning when both `package.publish` and `--index` are specified (rust-lang/cargo#16268)
- docs(cargo-yank): clarify yank behavior with leaked credentials (rust-lang/cargo#16274)
- feat(generate-lockfile): Add unstable --publish-time flag  (rust-lang/cargo#16265)
- Do not lock the artifact-dir for check builds (rust-lang/cargo#16230)
- fix(fingerprint): force update mtime of cargo-check artifacts (rust-lang/cargo#16262)
- fix(manifest): Point out when a key belongs to config (rust-lang/cargo#16256)
- Use raw false during cfg test (rust-lang/cargo#16261)
- Suppress metadata warnings for non–crates.io publishable packages (rust-lang/cargo#16241)
- feat(tree): Support long forms for --format variables (rust-lang/cargo#16204)
- fix(config): Fallback to non-canonical path for workspace-path-hash (rust-lang/cargo#16248)
- fix: update mtime for generated files after unpacking (rust-lang/cargo#16250)
- feat(cli): Add support for completing `--config` values in Bash (rust-lang/cargo#16245)
- feat: Add a typos CI job (rust-lang/cargo#16122)
@tgross35
Copy link
Contributor

@bors retry

Apparently a runner hasn't yet picked up the job, 5 hours in https://github.com/rust-lang/rust/actions/runs/19506679894/job/55834821771

@bors
Copy link
Collaborator

bors commented Nov 19, 2025

⌛ Testing commit 96d760c with merge d2f8873...

@bors
Copy link
Collaborator

bors commented Nov 20, 2025

☀️ Test successful - checks-actions
Approved by: weihanglo
Pushing d2f8873 to main...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Nov 20, 2025
@bors bors merged commit d2f8873 into rust-lang:main Nov 20, 2025
12 checks passed
@rustbot rustbot added this to the 1.93.0 milestone Nov 20, 2025
@github-actions
Copy link
Contributor

What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 07bdbae (parent) -> d2f8873 (this PR)

Test differences

Show 18 test diffs

Stage 2

  • check::check_build_should_not_lock_artifact_dir: [missing] -> pass (J0)
  • check::check_build_should_not_output_files_to_artifact_dir: [missing] -> pass (J0)
  • freshness::incremental_build_script_execution_got_new_mtime_and_cargo_check: [missing] -> pass (J0)
  • freshness_checksum::incremental_build_script_execution_got_new_mtime_and_cargo_check: [missing] -> ignore (requires -Zchecksum-hash-algorithm) (J0)
  • generate_lockfile::publish_time: [missing] -> pass (J0)
  • generate_lockfile::publish_time_feature_gated: [missing] -> pass (J0)
  • generate_lockfile::publish_time_no_candidates: [missing] -> pass (J0)
  • package::publish_to_alt_registry_warns: [missing] -> pass (J0)
  • package::publish_to_crates_io_warns: [missing] -> pass (J0)
  • publish::publish_when_both_publish_and_index_specified: [missing] -> pass (J0)
  • registry::deterministic_mtime: [missing] -> pass (J0)
  • vendor::deterministic_mtime: [missing] -> pass (J0)
  • script::cargo::memfd_script: [missing] -> ignore (-Zscript is unstable) (J1)

Additionally, 5 doctest diffs were found. These are ignored, as they are noisy.

Job group index

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard d2f887349fe3ea079a4f89b020ce6df1993e1e06 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. aarch64-apple: 9872.8s -> 7464.4s (-24.4%)
  2. x86_64-gnu-llvm-20: 2904.8s -> 2449.8s (-15.7%)
  3. aarch64-gnu-debug: 4455.8s -> 3787.1s (-15.0%)
  4. x86_64-gnu-gcc: 3580.7s -> 3072.0s (-14.2%)
  5. x86_64-msvc-ext3: 6027.1s -> 6847.0s (+13.6%)
  6. x86_64-rust-for-linux: 2995.7s -> 2630.7s (-12.2%)
  7. x86_64-gnu-llvm-21-1: 3522.7s -> 3142.7s (-10.8%)
  8. i686-gnu-nopt-1: 8192.2s -> 7439.7s (-9.2%)
  9. x86_64-gnu-llvm-21-2: 6209.6s -> 5674.0s (-8.6%)
  10. pr-check-1: 1927.5s -> 1766.0s (-8.4%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants