Skip to content

fix: clarify that fs::rename on unix accepts targets that don't exist #149267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sftse wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix: clarify that fs::rename on unix accepts targets that don't exist #149267

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7c5108f
fix: clarify that fs::rename on unix accepts targets that don't exist
sftse Nov 24, 2025
8689119
Update library/std/src/fs.rs
sftse Nov 28, 2025
c5f8215
Update library/std/src/fs.rs
sftse Nov 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions library/std/src/fs.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2666,8 +2666,8 @@ pub fn symlink_metadata<P: AsRef<Path>>(path: P) -> io::Result<Metadata> {
/// and the `MoveFileExW` or `SetFileInformationByHandle` function on Windows.
///
/// Because of this, the behavior when both `from` and `to` exist differs. On
/// Unix, if `from` is a directory, `to` must also be an (empty) directory. If
/// `from` is not a directory, `to` must also be not a directory. The behavior
/// Unix, if `from` is a directory, `to` must be an empty directory or non-existent. If
/// `from` is not a directory, `to` must also not be a directory. The behavior
/// on Windows is the same on Windows 10 1607 and higher if `FileRenameInfoEx`
/// is supported by the filesystem; otherwise, `from` can be anything, but
/// `to` must *not* be a directory.
Expand Down
Loading