Skip to content

Fix span note for question mark expression #149442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
chenyukang wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix span note for question mark expression #149442

chenyukang wants to merge 1 commit into from
+68 −17

Conversation

@chenyukang
Copy link
Member

@chenyukang chenyukang commented Nov 29, 2025 •
edited by rustbot
Loading

Fixes #144304

Seems it's better to fix the note instead of modifying the span to cover the whole expression.

r? @estebank

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Nov 29, 2025
@chenyukang chenyukang force-pushed the yukang-fix-mark-span-note-144304 branch from 25479ea to 7a9e0df Compare November 29, 2025 02:58
@estebank
Copy link
Contributor

estebank commented Dec 3, 2025

@bors r+

@bors
Copy link
Collaborator

bors commented Dec 3, 2025

📌 Commit 7a9e0df has been approved by estebank

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 3, 2025
Zalathar added a commit to Zalathar/rust that referenced this pull request Dec 4, 2025
@Zalathar
Rollup merge of rust-lang#149442 - chenyukang:yukang-fix-mark-span-no…
7ca63d0 
…te-144304, r=estebank

Fix span note for question mark expression

Fixes rust-lang#144304

Seems it's better to fix the note instead of modifying the span to cover the whole expression.

r? ``@estebank``
@Zalathar Zalathar mentioned this pull request Dec 4, 2025
Closed
@matthiaskrgr
Copy link
Member

matthiaskrgr commented Dec 4, 2025

@bors r-
https://triage.rust-lang.org/gha-logs/rust-lang/rust/57103201357

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Dec 4, 2025
@Zalathar
Copy link
Member

Zalathar commented Dec 4, 2025

Failed in rollup: #149628 (comment)

@chenyukang chenyukang force-pushed the yukang-fix-mark-span-note-144304 branch from 7a9e0df to d0bd4df Compare December 13, 2025 04:54
@chenyukang
Copy link
Member Author

chenyukang commented Dec 13, 2025

@bors try jobs=armhf-gnu

@rust-bors

This comment has been minimized.

Sign in to view
rust-bors bot added a commit that referenced this pull request Dec 13, 2025
@rust-bors
Auto merge of #149442 - chenyukang:yukang-fix-mark-span-note-144304, …
82bb8d7 
…r=<try>

Fix span note for question mark expression

try-job: armhf-gnu
@rust-bors
Copy link

rust-bors bot commented Dec 13, 2025

☀️ Try build successful (CI)
Build commit: 82bb8d7 (82bb8d75dc5252396b7f00c6a8e47c2a54df6925, parent: dc47a69ed94bc88b10b7d500cceacf29b87bcbbe)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@estebank estebank

Labels

S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

"this can't be annotated with ?" on expressions not directly annotated with ?

6 participants

@chenyukang @estebank @bors @matthiaskrgr @Zalathar @rustbot