std: small `sys` refactor #149930

joboet · 2025-12-12T20:39:21Z

The large number of files changed just results from the need to update a lot of imports. Actually this PR only:

combines the two definitions of RawOsError in sys::pal into one in sys::io
moves FULL_BACKTRACE_DEFAULT from sys::pal to sys::backtrace
moves the FromInner/IntoInner/... traits into sys (in preparation for removing sys_common entirely)

rustbot · 2025-12-12T20:39:26Z

rustbot has assigned @ChrisDenton.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

ChrisDenton · 2025-12-13T08:27:33Z

lgtm

@bors r+

bors · 2025-12-13T08:27:37Z

📌 Commit 5d83454 has been approved by ChrisDenton

It is now in the queue for this repository.

joboet · 2025-12-13T12:36:34Z

@bors rollup=iffy
(this touches quite a lot of platforms)

…Denton std: small `sys` refactor Part of rust-lang#117276 The large number of files changed just results from the need to update a lot of imports. Actually this PR only: * combines the two definitions of `RawOsError` in `sys::pal` into one in `sys::io` * moves `FULL_BACKTRACE_DEFAULT` from `sys::pal` to `sys::backtrace` * moves the `FromInner`/`IntoInner`/... traits into `sys` (in preparation for removing `sys_common` entirely)

…uwer Rollup of 5 pull requests Successful merges: - #148755 (Constify `DropGuard::dismiss` and trait impls) - #148825 (Add SystemTime::{MIN, MAX}) - #149894 (Update to mdbook 0.5) - #149930 (std: small `sys` refactor) - #149949 (Cleanup of attribute parsing errors) r? `@ghost` `@rustbot` modify labels: rollup

JonathanBrouwer · 2025-12-13T18:19:40Z

@bors r-
#149953 (comment)

std: small `sys` refactor try-job: dist-various-*

rust-bors · 2025-12-13T23:26:12Z

☀️ Try build successful (CI)
Build commit: ee1bc49 (ee1bc493a89cee2bf25e8b346659d23da7128dbd, parent: 430d8297c712ca7e8a4866d7ddccf1b71ba5d4d3)

joboet · 2025-12-13T23:32:47Z

@bors r=@ChrisDenton

bors · 2025-12-13T23:32:49Z

📌 Commit 2d27400 has been approved by ChrisDenton

It is now in the queue for this repository.

bors · 2025-12-15T08:28:49Z

☔ The latest upstream changes (presumably #149999) made this pull request unmergeable. Please resolve the merge conflicts.

... and remove the `#[doc(hidden)]` in favour of making them `pub(crate)`.

rustbot · 2025-12-15T13:02:31Z

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

joboet · 2025-12-15T14:37:30Z

@bors r=@ChrisDenton

bors · 2025-12-15T14:37:34Z

📌 Commit 33409da has been approved by ChrisDenton

It is now in the queue for this repository.

bors · 2025-12-15T18:46:51Z

⌛ Testing commit 33409da with merge 21ff67d...

bors · 2025-12-15T21:58:34Z

☀️ Test successful - checks-actions
Approved by: ChrisDenton
Pushing 21ff67d to main...

github-actions · 2025-12-15T22:01:31Z

What is this?

This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 0160933 (parent) -> 21ff67d (this PR)

Test differences

Show 1174 test diffs

1174 doctest diffs were found. These are ignored, as they are noisy.

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 21ff67df15329dd7548ccba54b6c6ae9a562124f --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

dist-apple-various: 4006.3s -> 4748.7s (+18.5%)
aarch64-msvc-1: 6577.6s -> 7770.8s (+18.1%)
aarch64-gnu-llvm-20-2: 2828.4s -> 3158.8s (+11.7%)
pr-check-2: 2349.8s -> 2611.9s (+11.2%)
dist-aarch64-llvm-mingw: 5810.2s -> 6423.4s (+10.6%)
x86_64-mingw-1: 9641.6s -> 10499.6s (+8.9%)
x86_64-gnu-miri: 4646.3s -> 4248.6s (-8.6%)
tidy: 167.3s -> 154.6s (-7.6%)
x86_64-gnu-llvm-21-2: 5188.5s -> 5569.3s (+7.3%)
x86_64-msvc-2: 9362.7s -> 8676.3s (-7.3%)

How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

rust-timer · 2025-12-15T22:40:18Z

Finished benchmarking commit (21ff67d): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

Results (primary -8.2%, secondary -5.2%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-8.2%	[-8.2%, -8.2%]	1
Improvements ✅ (secondary)	-5.2%	[-5.2%, -5.2%]	1
All ❌✅ (primary)	-8.2%	[-8.2%, -8.2%]	1

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 480.115s -> 479.832s (-0.06%)
Artifact size: 390.24 MiB -> 390.26 MiB (0.00%)

rustbot assigned ChrisDenton Dec 12, 2025

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 13, 2025

JonathanBrouwer mentioned this pull request Dec 13, 2025

Rollup of 5 pull requests #149953

Closed

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Dec 13, 2025

joboet force-pushed the small-sys-refactor branch from 5d83454 to a3df118 Compare December 13, 2025 19:48

rust-bors bot added a commit that referenced this pull request Dec 13, 2025

Auto merge of #149930 - joboet:small-sys-refactor, r=<try>

ee1bc49

std: small `sys` refactor try-job: dist-various-*

This comment has been minimized.

Sign in to view

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Dec 13, 2025

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Dec 15, 2025

joboet added 4 commits December 15, 2025 13:48

std: move RawOsError to sys::io

aa73de4

std: move FULL_BACKTRACE_DEFAULT to sys::backtrace

854df94

std: move FromInner etc. to sys

19acd4f

... and remove the `#[doc(hidden)]` in favour of making them `pub(crate)`.

std: update references to FromInner etc.

33409da

joboet force-pushed the small-sys-refactor branch from 2d27400 to 33409da Compare December 15, 2025 13:02

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Dec 15, 2025

bors added the merged-by-bors This PR was explicitly merged by bors. label Dec 15, 2025

bors merged commit 21ff67d into rust-lang:main Dec 15, 2025
12 checks passed

rustbot added this to the 1.94.0 milestone Dec 15, 2025

This was referenced Dec 15, 2025

Unify OsStringExt/OsStrExt traits across platforms #148050

Open

Share Timespec between Unix and Hermit #148847

Open

crate::io::Result → io::Result in most places #149778

Open

Uh oh!

std: small sys refactor #149930

std: small sys refactor #149930

Conversation

joboet commented Dec 12, 2025 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Dec 12, 2025

Uh oh!

ChrisDenton commented Dec 13, 2025

Uh oh!

bors commented Dec 13, 2025

Uh oh!

joboet commented Dec 13, 2025

Uh oh!

JonathanBrouwer commented Dec 13, 2025

Uh oh!

This comment has been minimized.

rust-bors bot commented Dec 13, 2025

Uh oh!

joboet commented Dec 13, 2025

Uh oh!

bors commented Dec 13, 2025

Uh oh!

bors commented Dec 15, 2025

Uh oh!

rustbot commented Dec 15, 2025

Uh oh!

joboet commented Dec 15, 2025

Uh oh!

bors commented Dec 15, 2025

Uh oh!

bors commented Dec 15, 2025

Uh oh!

bors commented Dec 15, 2025

Uh oh!

Uh oh!

github-actions bot commented Dec 15, 2025

Test differences

Job duration changes

Uh oh!

rust-timer commented Dec 15, 2025

Overall result: no relevant changes - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

std: small `sys` refactor #149930

std: small `sys` refactor #149930

joboet commented Dec 12, 2025 •

edited by rustbot

Loading