Check ConstArgHasType goals even when not wfchecking
#150322
Open
+541
−73
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
changes to the core type system |
rustbot
added
S-waiting-on-review
BoxyUwU
commented
Dec 23, 2025
| enter_wf_checking_ctxt_inner(tcx, body_def_id, !tcx.features().trivial_bounds(), f) | ||
| } | ||
|
|
||
| pub(super) fn enter_wf_checking_ctxt_without_checking_global_bounds<'tcx, F>( |
Member
Author
There was a problem hiding this comment.
it seems suboptimal to me that we implicitly check things about the where clauses of an item just from creating a wfcx. ideally this would happen as part of actually checking the where clauses or something?
Member
Author
|
@bors try |
rust-bors bot
added a commit
that referenced
this pull request
Dec 23, 2025
Check `ConstArgHasType` goals even when not wfchecking
This comment has been minimized.
This comment has been minimized.
Member
Author
|
needs a crater run + fcp |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
💔 Test for d15b493 failed: CI. Failed jobs:
|
BoxyUwU
force-pushed
the
check_const_types_without_wfck
branch
from
ef323a1 to
1b22adb
Compare
Member
Author
|
crazy, completely flipped one of the like two conditions in this PR by accident @bors try |
This comment has been minimized.
This comment has been minimized.
rust-bors bot
added a commit
that referenced
this pull request
Dec 24, 2025
Check `ConstArgHasType` goals even when not wfchecking
BoxyUwU
commented
Dec 24, 2025
| debug!(?self.out); | ||
| } | ||
|
|
||
| #[instrument(level = "debug", skip(self))] |
Member
Author
|
@craterbot check |
Collaborator
|
👌 Experiment ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more |
craterbot
added
S-waiting-on-crater
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #149774
r? types