Unknown -> Unsupported compression algorithm by Mark-Simulacrum · Pull Request #150630 · rust-lang/rust

Mark-Simulacrum · 2026-01-02T22:29:36Z

Both zstd and zlib are known compression algorithms, they just may not be supported by the backend. We shouldn't mislead users into e.g. thinking they made a typo.

cc #120953

rustbot · 2026-01-24T20:53:58Z

r? @davidtwco

rustbot has assigned @davidtwco.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

davidtwco

r=me after rebasing

View changes since this review

rustbot · 2026-03-21T19:44:28Z

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

Mark-Simulacrum · 2026-03-22T11:58:08Z

@bors r=davidtwco

rust-bors · 2026-03-22T11:58:12Z

📌 Commit 62605ef has been approved by davidtwco

It is now in the queue for this repository.

…on-warn, r=davidtwco Unknown -> Unsupported compression algorithm Both zstd and zlib are *known* compression algorithms, they just may not be supported by the backend. We shouldn't mislead users into e.g. thinking they made a typo. cc rust-lang#120953

compiler/rustc_codegen_llvm/src/errors.rs

JonathanBrouwer · 2026-03-22T12:19:36Z

@bors r-
Unapproving to give time to resolve the discussion

rust-bors · 2026-03-22T12:19:41Z

This pull request was unapproved.

This PR was contained in a rollup (#154209), which was unapproved.

Both zstd and zlib are *known* compression algorithms, they just may not be supported by the backend. We shouldn't mislead users into e.g. thinking they made a typo.

JonathanBrouwer · 2026-03-22T17:50:41Z

@bors r+ rollup

rust-bors · 2026-03-22T17:50:44Z

📌 Commit 6458ca5 has been approved by JonathanBrouwer

It is now in the queue for this repository.

…on-warn, r=JonathanBrouwer Unknown -> Unsupported compression algorithm Both zstd and zlib are *known* compression algorithms, they just may not be supported by the backend. We shouldn't mislead users into e.g. thinking they made a typo. cc rust-lang#120953

…uwer Rollup of 22 pull requests Successful merges: - #122668 (Add APIs for dealing with titlecase) - #152543 (privacy: Fix type privacy holes in RPITITs) - #153107 (Optimize BTreeMap::append() using CursorMut) - #153312 (Packages as namespaces part 1) - #153534 (Remove a flaky `got_timeout` assert from two channel tests) - #153718 (Fix environ on FreeBSD with cdylib targets that use -Wl,--no-undefined .) - #153857 (Rename `target.abi` to `target.cfg_abi` and enum-ify llvm_abiname) - #153880 (Lifted intersperse and intersperse_with Fused transformation and updated documentation + tests) - #153931 (remove usages of to-be-deprecated numeric constants) - #150630 (Unknown -> Unsupported compression algorithm) - #153491 (Move `freeze_*` methods to `OpenOptionsExt2`) - #153582 (Simplify find_attr! for HirId usage) - #153623 (std: move `sys::pal::os` to `sys::paths`) - #153647 (docs(fs): Clarify That File::lock Coordinates Across Processes) - #153936 (Skip stack_start_aligned for immediate-abort) - #154011 (implement `BinaryHeap::as_mut_slice`) - #154167 (ui/lto: move and rename two tests from issues/) - #154174 (allow `incomplete_features` in most UI tests) - #154175 (Add new alias for Guillaume Gomez email address) - #154182 (diagnostics: avoid ICE for undeclared generic parameter in impl) - #154188 (Update the tracking issue for #[diagnostic::on_move]) - #154201 (Use enums to clarify `DepNodeColorMap` color marking )

…uwer Rollup of 21 pull requests Successful merges: - #152543 (privacy: Fix type privacy holes in RPITITs) - #153107 (Optimize BTreeMap::append() using CursorMut) - #153312 (Packages as namespaces part 1) - #153534 (Remove a flaky `got_timeout` assert from two channel tests) - #153718 (Fix environ on FreeBSD with cdylib targets that use -Wl,--no-undefined .) - #153857 (Rename `target.abi` to `target.cfg_abi` and enum-ify llvm_abiname) - #153880 (Lifted intersperse and intersperse_with Fused transformation and updated documentation + tests) - #153931 (remove usages of to-be-deprecated numeric constants) - #150630 (Unknown -> Unsupported compression algorithm) - #153491 (Move `freeze_*` methods to `OpenOptionsExt2`) - #153582 (Simplify find_attr! for HirId usage) - #153623 (std: move `sys::pal::os` to `sys::paths`) - #153647 (docs(fs): Clarify That File::lock Coordinates Across Processes) - #153936 (Skip stack_start_aligned for immediate-abort) - #154011 (implement `BinaryHeap::as_mut_slice`) - #154167 (ui/lto: move and rename two tests from issues/) - #154174 (allow `incomplete_features` in most UI tests) - #154175 (Add new alias for Guillaume Gomez email address) - #154182 (diagnostics: avoid ICE for undeclared generic parameter in impl) - #154188 (Update the tracking issue for #[diagnostic::on_move]) - #154201 (Use enums to clarify `DepNodeColorMap` color marking )

…uwer Rollup of 21 pull requests Successful merges: - rust-lang/rust#152543 (privacy: Fix type privacy holes in RPITITs) - rust-lang/rust#153107 (Optimize BTreeMap::append() using CursorMut) - rust-lang/rust#153312 (Packages as namespaces part 1) - rust-lang/rust#153534 (Remove a flaky `got_timeout` assert from two channel tests) - rust-lang/rust#153718 (Fix environ on FreeBSD with cdylib targets that use -Wl,--no-undefined .) - rust-lang/rust#153857 (Rename `target.abi` to `target.cfg_abi` and enum-ify llvm_abiname) - rust-lang/rust#153880 (Lifted intersperse and intersperse_with Fused transformation and updated documentation + tests) - rust-lang/rust#153931 (remove usages of to-be-deprecated numeric constants) - rust-lang/rust#150630 (Unknown -> Unsupported compression algorithm) - rust-lang/rust#153491 (Move `freeze_*` methods to `OpenOptionsExt2`) - rust-lang/rust#153582 (Simplify find_attr! for HirId usage) - rust-lang/rust#153623 (std: move `sys::pal::os` to `sys::paths`) - rust-lang/rust#153647 (docs(fs): Clarify That File::lock Coordinates Across Processes) - rust-lang/rust#153936 (Skip stack_start_aligned for immediate-abort) - rust-lang/rust#154011 (implement `BinaryHeap::as_mut_slice`) - rust-lang/rust#154167 (ui/lto: move and rename two tests from issues/) - rust-lang/rust#154174 (allow `incomplete_features` in most UI tests) - rust-lang/rust#154175 (Add new alias for Guillaume Gomez email address) - rust-lang/rust#154182 (diagnostics: avoid ICE for undeclared generic parameter in impl) - rust-lang/rust#154188 (Update the tracking issue for #[diagnostic::on_move]) - rust-lang/rust#154201 (Use enums to clarify `DepNodeColorMap` color marking )

This comment has been minimized.

Sign in to view

hkBst approved these changes Jan 3, 2026

View reviewed changes

Mark-Simulacrum force-pushed the rephrase-compression-warn branch from a42131d to 7dc36ad Compare January 24, 2026 18:30

Mark-Simulacrum marked this pull request as ready for review January 24, 2026 20:53

rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 24, 2026

rustbot assigned davidtwco Jan 24, 2026

rustbot removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Jan 24, 2026

This comment has been minimized.

Sign in to view

davidtwco approved these changes Feb 5, 2026

View reviewed changes

davidtwco added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 5, 2026

Mark-Simulacrum force-pushed the rephrase-compression-warn branch from 7dc36ad to 62605ef Compare March 21, 2026 19:44

rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 22, 2026

JonathanBrouwer mentioned this pull request Mar 22, 2026

Rollup of 4 pull requests #154209

Closed

Zalathar reviewed Mar 22, 2026

View reviewed changes

compiler/rustc_codegen_llvm/src/errors.rs Show resolved Hide resolved

rust-bors bot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 22, 2026

Unknown -> Unsupported compression algorithm

6458ca5

Both zstd and zlib are *known* compression algorithms, they just may not be supported by the backend. We shouldn't mislead users into e.g. thinking they made a typo.

Mark-Simulacrum force-pushed the rephrase-compression-warn branch from 62605ef to 6458ca5 Compare March 22, 2026 12:28

rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 22, 2026

JonathanBrouwer mentioned this pull request Mar 22, 2026

Rollup of 10 pull requests #154222

Closed

JonathanBrouwer mentioned this pull request Mar 22, 2026

Rollup of 23 pull requests #154226

Closed

JonathanBrouwer mentioned this pull request Mar 22, 2026

Rollup of 22 pull requests #154227

Closed

JonathanBrouwer mentioned this pull request Mar 23, 2026

Rollup of 21 pull requests #154255

Merged

rust-bors bot merged commit a87d694 into rust-lang:main Mar 23, 2026
11 checks passed

rustbot added this to the 1.96.0 milestone Mar 23, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Unknown -> Unsupported compression algorithm#150630

Unknown -> Unsupported compression algorithm#150630
rust-bors[bot] merged 1 commit intorust-lang:mainfrom
Mark-Simulacrum:rephrase-compression-warn

Mark-Simulacrum commented Jan 2, 2026

Uh oh!

This comment has been minimized.

rustbot commented Jan 24, 2026

Uh oh!

This comment has been minimized.

davidtwco left a comment •

edited by rustbot

Loading

Uh oh!

rustbot commented Mar 21, 2026

Uh oh!

Mark-Simulacrum commented Mar 22, 2026

Uh oh!

rust-bors bot commented Mar 22, 2026

Uh oh!

Uh oh!

JonathanBrouwer commented Mar 22, 2026 •

edited

Loading

Uh oh!

rust-bors bot commented Mar 22, 2026

Uh oh!

JonathanBrouwer commented Mar 22, 2026

Uh oh!

rust-bors bot commented Mar 22, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Uh oh!

Conversation

Mark-Simulacrum commented Jan 2, 2026

Uh oh!

This comment has been minimized.

rustbot commented Jan 24, 2026

Uh oh!

This comment has been minimized.

davidtwco left a comment • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rustbot commented Mar 21, 2026

Uh oh!

Mark-Simulacrum commented Mar 22, 2026

Uh oh!

rust-bors bot commented Mar 22, 2026

Uh oh!

Uh oh!

JonathanBrouwer commented Mar 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rust-bors bot commented Mar 22, 2026

Uh oh!

JonathanBrouwer commented Mar 22, 2026

Uh oh!

rust-bors bot commented Mar 22, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

davidtwco left a comment •

edited by rustbot

Loading

JonathanBrouwer commented Mar 22, 2026 •

edited

Loading