Conversation
|
These commits modify the If this was unintentional then you should revert the changes before this PR is merged. |
|
Mind waiting until tomorrow? I should have 0.2.180 out by then, which will include a handful of fixes on smaller targets (unbreaking uclibc) |
|
Sure, no problem. Should I close this PR or just update it when the release is there? |
|
You can leave it open, I'll ping once the release is out |
f581a0d to
a45ec88
Compare
This comment has been minimized.
This comment has been minimized.
|
Wow you're on top of things, I was just about to ping here |
|
Just got an Email from the rustbot regarding the new libc release and updated the PR. |
library/std/Cargo.toml
Outdated
|
|
||
| [target.'cfg(not(all(windows, target_env = "msvc")))'.dependencies] | ||
| libc = { version = "0.2.178", default-features = false, features = [ | ||
| libc = { version = "0.2.179", default-features = false, features = [ |
There was a problem hiding this comment.
This isn't actually using the very latest (0.2.180)
There was a problem hiding this comment.
yes, I did some errors locally with the git commands. Should be correct now.
a45ec88 to
47c5f58
Compare
|
@bors r+ |
Update libc to v0.2.180 Follow-up of rust-lang#150484. This PR updates libc to include the latest patches to make rtems target (and probably others) compile again.
Rollup of 12 pull requests Successful merges: - #149961 (tidy: add if-installed prefix condition to extra checks system) - #150475 (std: sys: fs: uefi: Implement initial File) - #150533 (std: sys: fs: uefi: Implement remove_dir_all) - #150549 (fix missing_panics_doc in `std::os::fd::owned`) - #150699 (MGCA: Support literals as direct const arguments) - #150721 (Deprecated doc intra link) - #150752 (Update libc to v0.2.180) - #150802 (Minor cleanups to fn_abi_new_uncached) - #150803 (compiler-builtins subtree update) - #150809 (Update `literal-escaper` version to `0.0.7`) - #150811 (Store defids instead of symbol names in the aliases list) - #150825 (Query associated_item_def_ids when needed) r? @ghost
Update libc to v0.2.180 Follow-up of rust-lang#150484. This PR updates libc to include the latest patches to make rtems target (and probably others) compile again.
|
@bors try jobs=dist-ohos-x86_64 |
This comment has been minimized.
This comment has been minimized.
Update libc to v0.2.180 try-job: dist-ohos-x86_64
Update libc to v0.2.180 Follow-up of rust-lang#150484. This PR updates libc to include the latest patches to make rtems target (and probably others) compile again.
This comment has been minimized.
This comment has been minimized.
be07ade to
2f8137f
Compare
This comment has been minimized.
This comment has been minimized.
|
Ohos maintainers @Amanieu @cceerczw what is the size of If it's correct then also up to you whether libc should switch back to 32-bit time_t on 32-bit ohos with mild ecosystem breakage like shown here, or stick with 64-bit bit. |
|
As far as I can tell OHOS has always had 64-bit time_t. |
|
I'm hoping to take advantage of the libc update once it lands. So to that end, I'd like to help do whatever I can to work out the blocker(s) for this PR.
Is this just waiting for a decision from the relevant owner(s) or is there something I can do to test/configure/investigate/fix the issue? |
|
Since the old timespec definition didn't match and the current one is correct, std should be updated here. @thesummer could you do that? I.e. use a zeroed |
2f8137f to
85805c3
Compare
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
|
Done. |
|
ah, sorry. Missed the rest or your comment, regarding the std. |
This create conflict if the timespec of a target has additional fields. Use libc::timespec::default() instead
|
Ok, done. Let's see if I found all the timespec initalizers. At least |
…gross35 Update libc to v0.2.183 Follow-up of rust-lang#150484. This PR updates libc to include the latest patches to make rtems target (and probably others) compile again.
…uwer Rollup of 9 pull requests Successful merges: - #150752 (Update libc to v0.2.183) - #153380 (stabilize new RangeFrom type and iterator) - #153834 (Merge `fabsf16/32/64/128` into `fabs::<F>`) - #154043 (simd_fmin/fmax: make semantics and name consistent with scalar intrinsics) - #154494 (triagebot: add reminder for bumping CI LLVM stamp) - #153374 (Fix LegacyKeyValueFormat report from docker build: dist-x86_64) - #154320 (`trim_prefix` for paths) - #154453 (Fix ice in rustdoc of private reexport) - #154515 (Notify stdarch maintainers on changes in std_detect)
|
This pull request was unapproved. This PR was contained in a rollup (#154519), which was unapproved. |
| use crate::time::Duration; | ||
|
|
There was a problem hiding this comment.
Ah, looks like an accidental removal
View all comments
Follow-up of #150484.
This PR updates libc to include the latest patches to make rtems target (and probably others) compile again.