Skip to content

Update libc to v0.2.183#150752

Open
thesummer wants to merge 2 commits intorust-lang:mainfrom
thesummer:update-libc-0.2.179
Open

Update libc to v0.2.183#150752
thesummer wants to merge 2 commits intorust-lang:mainfrom
thesummer:update-libc-0.2.179

Conversation

@thesummer
Copy link
Copy Markdown
Contributor

@thesummer thesummer commented Jan 7, 2026

View all comments

Follow-up of #150484.
This PR updates libc to include the latest patches to make rtems target (and probably others) compile again.

@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented Jan 7, 2026

These commits modify the library/Cargo.lock file. Unintentional changes to library/Cargo.lock can be introduced when switching branches and rebasing PRs.

If this was unintentional then you should revert the changes before this PR is merged.
Otherwise, you can ignore this comment.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jan 7, 2026
@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented Jan 7, 2026

r? @tgross35

rustbot has assigned @tgross35.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@tgross35
Copy link
Copy Markdown
Contributor

tgross35 commented Jan 7, 2026

Mind waiting until tomorrow? I should have 0.2.180 out by then, which will include a handful of fixes on smaller targets (unbreaking uclibc)

@thesummer
Copy link
Copy Markdown
Contributor Author

Sure, no problem. Should I close this PR or just update it when the release is there?

@tgross35
Copy link
Copy Markdown
Contributor

tgross35 commented Jan 7, 2026

You can leave it open, I'll ping once the release is out

@thesummer thesummer changed the title Update libc to v0.2.179 Update libc to v0.2.180 Jan 8, 2026
@thesummer thesummer force-pushed the update-libc-0.2.179 branch from f581a0d to a45ec88 Compare January 8, 2026 12:31
@rustbot

This comment has been minimized.

@tgross35
Copy link
Copy Markdown
Contributor

tgross35 commented Jan 8, 2026

Wow you're on top of things, I was just about to ping here

@thesummer
Copy link
Copy Markdown
Contributor Author

Just got an Email from the rustbot regarding the new libc release and updated the PR.


[target.'cfg(not(all(windows, target_env = "msvc")))'.dependencies]
libc = { version = "0.2.178", default-features = false, features = [
libc = { version = "0.2.179", default-features = false, features = [
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't actually using the very latest (0.2.180)

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, I did some errors locally with the git commands. Should be correct now.

@thesummer thesummer force-pushed the update-libc-0.2.179 branch from a45ec88 to 47c5f58 Compare January 8, 2026 12:36
Copy link
Copy Markdown
Contributor

@tgross35 tgross35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM once CI passes

View changes since this review

@tgross35
Copy link
Copy Markdown
Contributor

tgross35 commented Jan 8, 2026

@bors r+

@rust-bors rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 8, 2026
@rust-bors
Copy link
Copy Markdown
Contributor

rust-bors bot commented Jan 8, 2026

📌 Commit 47c5f58 has been approved by tgross35

It is now in the queue for this repository.

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jan 8, 2026
Update libc to v0.2.180

Follow-up of rust-lang#150484.
This PR updates libc to include the latest patches to make rtems target (and probably others) compile again.
rust-bors bot added a commit that referenced this pull request Jan 8, 2026
Rollup of 12 pull requests

Successful merges:

 - #149961 (tidy: add if-installed prefix condition to extra checks system)
 - #150475 (std: sys: fs: uefi: Implement initial File)
 - #150533 (std: sys: fs: uefi: Implement remove_dir_all)
 - #150549 (fix missing_panics_doc in `std::os::fd::owned`)
 - #150699 (MGCA: Support literals as direct const arguments)
 - #150721 (Deprecated doc intra link)
 - #150752 (Update libc to v0.2.180)
 - #150802 (Minor cleanups to fn_abi_new_uncached)
 - #150803 (compiler-builtins subtree update)
 - #150809 (Update `literal-escaper` version to `0.0.7`)
 - #150811 (Store defids instead of symbol names in the aliases list)
 - #150825 (Query associated_item_def_ids when needed)

r? @ghost
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jan 8, 2026
Update libc to v0.2.180

Follow-up of rust-lang#150484.
This PR updates libc to include the latest patches to make rtems target (and probably others) compile again.
@matthiaskrgr
Copy link
Copy Markdown
Member

@bors try jobs=dist-ohos-x86_64

@rust-bors

This comment has been minimized.

rust-bors bot added a commit that referenced this pull request Jan 8, 2026
Update libc to v0.2.180

try-job: dist-ohos-x86_64
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jan 8, 2026
Update libc to v0.2.180

Follow-up of rust-lang#150484.
This PR updates libc to include the latest patches to make rtems target (and probably others) compile again.
@rust-log-analyzer

This comment has been minimized.

@thesummer thesummer force-pushed the update-libc-0.2.179 branch 2 times, most recently from be07ade to 2f8137f Compare February 13, 2026 09:47
@rustbot

This comment has been minimized.

@tgross35
Copy link
Copy Markdown
Contributor

Ohos maintainers @Amanieu @cceerczw what is the size of time_t on 32-bit ohos? It's listed as musl 1.2+ only in libc https://github.com/rust-lang/libc/blob/c12def367b38ce2dbfbfb8873786a60be3c31105/build.rs#L113-L116 so it's now getting 64-bit time_t with the most recent releases. This wasn't really intentional but I'm wondering which is correct here, and if things might have been broken.

If it's correct then also up to you whether libc should switch back to 32-bit time_t on 32-bit ohos with mild ecosystem breakage like shown here, or stick with 64-bit bit.

@Amanieu
Copy link
Copy Markdown
Member

Amanieu commented Feb 14, 2026

As far as I can tell OHOS has always had 64-bit time_t.

@androm3da
Copy link
Copy Markdown
Contributor

I'm hoping to take advantage of the libc update once it lands. So to that end, I'd like to help do whatever I can to work out the blocker(s) for this PR.

If it's correct then also up to you whether libc should switch back to 32-bit time_t on 32-bit ohos with mild ecosystem breakage like shown here, or stick with 64-bit bit.

Is this just waiting for a decision from the relevant owner(s) or is there something I can do to test/configure/investigate/fix the issue?

@tgross35
Copy link
Copy Markdown
Contributor

Since the old timespec definition didn't match and the current one is correct, std should be updated here. @thesummer could you do that? I.e. use a zeroed libc::timespec then write the fields. (If you bump to 0.2.183 you can use the Default impl and save an unsafe block).

@thesummer thesummer force-pushed the update-libc-0.2.179 branch from 2f8137f to 85805c3 Compare March 28, 2026 12:25
@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented Mar 28, 2026

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@thesummer
Copy link
Copy Markdown
Contributor Author

Done.
@tgross35 could you please reapprove? Let's see if the merge pipeline works now. 🤞

@thesummer
Copy link
Copy Markdown
Contributor Author

ah, sorry. Missed the rest or your comment, regarding the std.

This create conflict if the timespec of a target has additional fields.
Use libc::timespec::default() instead
@rustbot rustbot added the O-unix Operating system: Unix-like label Mar 28, 2026
@thesummer
Copy link
Copy Markdown
Contributor Author

Ok, done. Let's see if I found all the timespec initalizers. At least ./x.py check library --target armv7-unknown-linux-ohos returned without errors afterwards.

@tgross35 tgross35 changed the title Update libc to v0.2.181 Update libc to v0.2.183 Mar 28, 2026
Copy link
Copy Markdown
Contributor

@tgross35 tgross35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the followup

@bors r+ rollup=iffy

View changes since this review

@rust-bors
Copy link
Copy Markdown
Contributor

rust-bors bot commented Mar 28, 2026

📌 Commit e5124ce has been approved by tgross35

It is now in the queue for this repository.

@rust-bors rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 28, 2026
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Mar 28, 2026
…gross35

Update libc to v0.2.183

Follow-up of rust-lang#150484.
This PR updates libc to include the latest patches to make rtems target (and probably others) compile again.
rust-bors bot pushed a commit that referenced this pull request Mar 28, 2026
…uwer

Rollup of 9 pull requests

Successful merges:

 - #150752 (Update libc to v0.2.183)
 - #153380 (stabilize new RangeFrom type and iterator)
 - #153834 (Merge `fabsf16/32/64/128` into `fabs::<F>`)
 - #154043 (simd_fmin/fmax: make semantics and name consistent with scalar intrinsics)
 - #154494 (triagebot: add reminder for bumping CI LLVM stamp)
 - #153374 (Fix LegacyKeyValueFormat report from docker build: dist-x86_64)
 - #154320 (`trim_prefix` for paths)
 - #154453 (Fix ice in rustdoc of private reexport)
 - #154515 (Notify stdarch maintainers on changes in std_detect)
@GuillaumeGomez
Copy link
Copy Markdown
Member

Failed in #154519.

@bors r-

@rust-bors rust-bors bot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 28, 2026
@rust-bors
Copy link
Copy Markdown
Contributor

rust-bors bot commented Mar 28, 2026

This pull request was unapproved.

This PR was contained in a rollup (#154519), which was unapproved.

Comment on lines -1 to -2
use crate::time::Duration;

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, looks like an accidental removal

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

O-unix Operating system: Unix-like S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants