-
-
Notifications
You must be signed in to change notification settings - Fork 14.7k
Reorganisation of UI Tests #153962
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
rishi-techo-14
wants to merge
5
commits into
rust-lang:main
Choose a base branch
from
rishi-techo-14:ui-tests-reorg-v2
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Reorganisation of UI Tests #153962
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
c21a343
Move several tests from tests/ui/issues to appropriate subdirectories
rishi-techo-14 841599c
Rename moved UI tests to descriptive names
rishi-techo-14 00cc866
Add issue links and descriptions to UI test
rishi-techo-14 6611b41
Cleaned up 11 tests
rishi-techo-14 42250a2
Reorganize 11 tests: simply names and clean comments
rishi-techo-14 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
2 changes: 2 additions & 0 deletions
2
tests/ui/issues/issue-2590.rs → ...-move-out-of-borrowed-field-issue-2590.rs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,5 @@ | ||
| // https://github.com/rust-lang/rust/issues/2590 | ||
|
|
||
| struct Parser { | ||
| tokens: Vec<isize> , | ||
| } | ||
|
|
||
14 changes: 14 additions & 0 deletions
14
tests/ui/borrowck/cannot-move-out-of-borrowed-field-issue-2590.stderr
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| error[E0507]: cannot move out of `self.tokens` which is behind a shared reference | ||
| --> $DIR/cannot-move-out-of-borrowed-field-issue-2590.rs:13:9 | ||
| | | ||
| LL | self.tokens | ||
| | ^^^^^^^^^^^ move occurs because `self.tokens` has type `Vec<isize>`, which does not implement the `Copy` trait | ||
| | | ||
| help: consider cloning the value if the performance cost is acceptable | ||
| | | ||
| LL | self.tokens.clone() | ||
| | ++++++++ | ||
|
|
||
| error: aborting due to 1 previous error | ||
|
|
||
| For more information about this error, try `rustc --explain E0507`. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| // https://github.com/rust-lang/rust/issues/2590 | ||
|
|
||
| struct Parser { | ||
| tokens: Vec<isize> , | ||
| } | ||
|
|
||
| trait Parse { | ||
| fn parse(&self) -> Vec<isize> ; | ||
| } | ||
|
|
||
| impl Parse for Parser { | ||
| fn parse(&self) -> Vec<isize> { | ||
| self.tokens //~ ERROR cannot move out | ||
| } | ||
| } | ||
|
|
||
| fn main() {} | ||
2 changes: 1 addition & 1 deletion
2
tests/ui/issues/issue-2590.stderr → .../cannot-move-out-of-borrowed-field.stderr
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 2 additions & 0 deletions
2
tests/ui/issues/issue-4335.rs → ...ove-out-of-borrowed-content-in-closure.rs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,5 @@ | ||
| // https://github.com/rust-lang/rust/issues/4335 | ||
|
|
||
| #![feature(fn_traits)] | ||
|
|
||
| fn id<T>(t: T) -> T { t } | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 2 additions & 0 deletions
2
tests/ui/issues/issue-3021-b.rs → ...i/closures/capture-dynamic-environment.rs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,5 @@ | ||
| // https://github.com/rust-lang/rust/issues/3021 | ||
|
|
||
| fn siphash(k0 : u64) { | ||
|
|
||
| struct SipHash { | ||
|
|
||
2 changes: 1 addition & 1 deletion
2
tests/ui/issues/issue-3021-b.stderr → ...osures/capture-dynamic-environment.stderr
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 2 additions & 0 deletions
2
tests/ui/issues/issue-17252.rs → ...s/ui/consts/const-eval-cycle-detection.rs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 changes: 6 additions & 6 deletions
12
tests/ui/issues/issue-17252.stderr → .../consts/const-eval-cycle-detection.stderr
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 2 additions & 0 deletions
2
tests/ui/issues/issue-2150.rs → tests/ui/lint/unreachable-code-in-loop.rs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 changes: 2 additions & 2 deletions
4
tests/ui/issues/issue-2150.stderr → ...s/ui/lint/unreachable-code-in-loop.stderr
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 2 additions & 0 deletions
2
tests/ui/issues/issue-4972.rs → ...n/box-pattern-trait-object-deref-error.rs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,5 @@ | ||
| // https://github.com/rust-lang/rust/issues/4972 | ||
|
|
||
| #![feature(box_patterns)] | ||
|
|
||
| trait MyTrait { | ||
|
|
||
2 changes: 1 addition & 1 deletion
2
tests/ui/issues/issue-4972.stderr → ...x-pattern-trait-object-deref-error.stderr
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 change: 1 addition & 0 deletions
1
tests/ui/issues/issue-5100.rs → ...n/pattern-mismatched-types-diagnostics.rs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,5 @@ | ||
| //@ dont-require-annotations: NOTE | ||
| // https://github.com/rust-lang/rust/issues/5100 | ||
|
|
||
| #![feature(box_patterns)] | ||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 2 additions & 0 deletions
2
tests/ui/issues/issue-17800.rs → ...uple-variant-written-as-struct-pattern.rs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,5 @@ | ||
| // https://github.com/rust-lang/rust/issues/17800 | ||
|
|
||
| enum MyOption<T> { | ||
| MySome(T), | ||
| MyNone, | ||
|
|
||
2 changes: 1 addition & 1 deletion
2
tests/ui/issues/issue-17800.stderr → ...-variant-written-as-struct-pattern.stderr
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 2 additions & 0 deletions
2
tests/ui/issues/issue-3702-2.rs → ...aits/method-resolution-multiple-traits.rs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,5 @@ | ||
| // https://github.com/rust-lang/rust/issues/3702 | ||
|
|
||
| pub trait ToPrimitive { | ||
| fn to_int(&self) -> isize { 0 } | ||
| } | ||
|
|
||
6 changes: 3 additions & 3 deletions
6
tests/ui/issues/issue-3702-2.stderr → .../method-resolution-multiple-traits.stderr
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 2 additions & 0 deletions
2
tests/ui/issues/issue-4265.rs → ...k/duplicate-method-definitions-in-impl.rs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,5 @@ | ||
| // https://github.com/rust-lang/rust/issues/4265 | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This should not be moved to |
||
|
|
||
| struct Foo { | ||
| baz: usize | ||
| } | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 2 additions & 0 deletions
2
tests/ui/issues/issue-4736.rs → ...k/tuple-struct-field-constructor-error.rs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,5 @@ | ||
| // https://github.com/rust-lang/rust/issues/4736 | ||
|
|
||
| struct NonCopyable(()); | ||
|
|
||
| fn main() { | ||
|
|
||
2 changes: 1 addition & 1 deletion
2
tests/ui/issues/issue-4736.stderr → ...ple-struct-field-constructor-error.stderr
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This test was added twice: as
tests/ui/borrowck/cannot-move-out-of-borrowed-field-issue-2590.rsand astests/ui/borrowck/cannot-move-out-of-borrowed-field.rs.