Skip to content

[libcore] Disable doc(auto_cfg) for integers trait impls#154311

Merged
rust-bors[bot] merged 1 commit intorust-lang:mainfrom
GuillaumeGomez:fix-integer-doc-cfg
Mar 25, 2026
Merged

[libcore] Disable doc(auto_cfg) for integers trait impls#154311
rust-bors[bot] merged 1 commit intorust-lang:mainfrom
GuillaumeGomez:fix-integer-doc-cfg

Conversation

@GuillaumeGomez
Copy link
Copy Markdown
Member

@GuillaumeGomez GuillaumeGomez commented Mar 24, 2026 •
edited by tgross35
Loading

Fixes #153655.

Thanks to #153964, doc(auto_cfg) finally works as expected on impls. So now this fix works:

image

cc @eggyal

@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented Mar 24, 2026

Some changes occurred in integer formatting

cc @tgross35

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Mar 24, 2026
@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented Mar 24, 2026

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: @scottmcm, libs
  • @scottmcm, libs expanded to 8 candidates
  • Random selection from Mark-Simulacrum, scottmcm

@GuillaumeGomez GuillaumeGomez changed the title Disable doc(auto_cfg) for integers trait impls [libcore] Disable doc(auto_cfg) for integers trait impls Mar 24, 2026
eggyal
eggyal approved these changes Mar 24, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@eggyal eggyal left a comment •
edited by rustbot
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

View changes since this review

tgross35
tgross35 approved these changes Mar 24, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@tgross35 tgross35 left a comment •
edited by rustbot
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a "Closes #151512" wince that is no longer needed.

@bors r=eggyal,tgross35 rollup

View changes since this review

@rust-bors
Copy link
Copy Markdown
Contributor

rust-bors bot commented Mar 24, 2026

📌 Commit 24295bf has been approved by eggyal,tgross35

It is now in the queue for this repository.

⚠️ The following reviewer(s) could not be found: eggyal

@rust-bors rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 24, 2026
@tgross35
Copy link
Copy Markdown
Contributor

tgross35 commented Mar 24, 2026

Added a "Closes #151512" wince that is no longer needed.

I take that back, this only handles the traits. Removed.

@tgross35 tgross35 assigned tgross35 and unassigned Mark-Simulacrum Mar 24, 2026
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Mar 24, 2026
@JonathanBrouwer
Rollup merge of rust-lang#154311 - GuillaumeGomez:fix-integer-doc-cfg…
9b03a8a 
…, r=eggyal,tgross35

[libcore] Disable `doc(auto_cfg)` for integers trait impls

Fixes rust-lang#153655.

Thanks to rust-lang#153964, `doc(auto_cfg)` finally works as expected on impls. So now this fix works:

<img width="1000" height="806" alt="image" src="https://github.com/user-attachments/assets/f37da375-c2eb-4a7b-abf2-1fdd3a73e2bb" />

cc @eggyal
This was referenced Mar 24, 2026
Closed
Merged
rust-bors bot pushed a commit that referenced this pull request Mar 24, 2026
@bors
Auto merge of #154339 - JonathanBrouwer:rollup-FPeeGxJ, r=JonathanBro…
8a70352 
…uwer

Rollup of 3 pull requests

Successful merges:

 - #154311 ([libcore] Disable `doc(auto_cfg)` for integers trait impls)
 - #154331 (allow `incomplete_features` in all ui tests)
 - #154336 (Remove more BuiltinLintDiag variants - part 3)
@rust-bors rust-bors bot merged commit f9f6c97 into rust-lang:main Mar 25, 2026
11 checks passed
@rustbot rustbot added this to the 1.96.0 milestone Mar 25, 2026
github-actions bot pushed a commit to rust-lang/miri that referenced this pull request Mar 25, 2026
@bors
Auto merge of #154339 - JonathanBrouwer:rollup-FPeeGxJ, r=JonathanBro…
92c2876 
…uwer

Rollup of 3 pull requests

Successful merges:

 - rust-lang/rust#154311 ([libcore] Disable `doc(auto_cfg)` for integers trait impls)
 - rust-lang/rust#154331 (allow `incomplete_features` in all ui tests)
 - rust-lang/rust#154336 (Remove more BuiltinLintDiag variants - part 3)
@GuillaumeGomez GuillaumeGomez deleted the fix-integer-doc-cfg branch March 25, 2026 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tgross35 tgross35 tgross35 approved these changes

+1 more reviewer

@eggyal eggyal eggyal approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@tgross35 tgross35

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.96.0

Development

Successfully merging this pull request may close these issues.

rustdoc reports wrong config conditions for impl LowerExp for integers

5 participants

@GuillaumeGomez @rustbot @tgross35 @eggyal @Mark-Simulacrum