debuginfo: emit DW_TAG_call_site entries on optimized builds#154532
debuginfo: emit DW_TAG_call_site entries on optimized builds#154532resrever wants to merge 1 commit intorust-lang:mainfrom
Conversation
|
@bors try @rust-timer queue |
This comment has been minimized.
This comment has been minimized.
debuginfo: emit DW_TAG_call_site entries on optimized builds
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Finished benchmarking commit (1959f8b): comparison URL. Overall result: ❌ regressions - please read the text belowBenchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf. Next Steps: If you can justify the regressions found in this try perf run, please do so in sufficient writing along with @bors rollup=never Instruction countOur most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
Max RSS (memory usage)This benchmark run did not return any relevant results for this metric. CyclesResults (primary -2.4%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeResults (primary 1.4%, secondary 1.8%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Bootstrap: 492.806s -> 486.147s (-1.35%) |
|
As expected, ripgrep is showing an increase because it is generating debug symbols with optimization. I did not anticipate the helloworld regression, but after some digging it looks like |
This is a follow-up to #154200, which was reverted in #154468. The perf metrics showed an average increase of ~2% in binary size and 0.5% compile-time, which is expected due to the space and processing of the DW_TAG_call_site entries.
What this PR does different is gate it behind optimized builds. DW_TAG_call_site is only useful on debug symbols with optimized builds anyway, because unoptimized builds have clear call sites with no tail calls. This behavior also aligns with Clang.
Only one binary in the perf suite - ripgrep - uses debug+optimized builds, so the performance impact is expected to remain, but with that cost comes the benefit of improved debuggability.
r? dingxiangfei2009