Skip to content

Rollup of 4 pull requests#154535

Merged
rust-bors[bot] merged 10 commits intorust-lang:mainfrom
JonathanBrouwer:rollup-jU7CiZw
Mar 29, 2026
Merged

Rollup of 4 pull requests#154535
rust-bors[bot] merged 10 commits intorust-lang:mainfrom
JonathanBrouwer:rollup-jU7CiZw

Conversation

@JonathanBrouwer
Copy link
Copy Markdown
Contributor

Successful merges:

r? @ghost

Create a similar rollup

Lars-Schumann and others added 10 commits March 9, 2026 23:26
…-dead

Fix Vec::const_make_global for 0 capacity and ZST's

fixes rust-lang#153158
Don't fuse in `MapWindows`

cc rust-lang#87155

Fusing makes the iterator larger, slower, more complicated, and less useful. Users who need fusing behavior can always use `.fuse()`, but there is no way to get non-fusing behavior from the fused version.

@rustbot label A-iterators
…ottmcm

Constify comparisons and `Clone` for `core::mem::Alignment`

As suggested in rust-lang#153261 (comment)
…nTitor

Add doc links to `ExtractIf` of `BTree{Set,Map}` and `LinkedList`

There were links for `Hash{Set,Map}` and `Vec{,Deque}` versions, but not these three.
@rust-bors rust-bors bot added the rollup A PR which is a rollup label Mar 29, 2026
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Mar 29, 2026
@JonathanBrouwer
Copy link
Copy Markdown
Contributor Author

@bors r+ rollup=never p=5

@rust-bors
Copy link
Copy Markdown
Contributor

rust-bors bot commented Mar 29, 2026

📌 Commit b7ea4b7 has been approved by JonathanBrouwer

It is now in the queue for this repository.

@rust-bors rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 29, 2026
@rust-bors

This comment has been minimized.

@rust-bors rust-bors bot added merged-by-bors This PR was explicitly merged by bors. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 29, 2026
@rust-bors
Copy link
Copy Markdown
Contributor

rust-bors bot commented Mar 29, 2026

☀️ Test successful - CI
Approved by: JonathanBrouwer
Duration: 3h 14m 11s
Pushing 584d32e to main...

@rust-bors rust-bors bot merged commit 584d32e into rust-lang:main Mar 29, 2026
12 checks passed
@rustbot rustbot added this to the 1.96.0 milestone Mar 29, 2026
@rust-timer
Copy link
Copy Markdown
Collaborator

📌 Perf builds for each rolled up PR:

PR# Message Perf Build Sha
#153632 Fix Vec::const_make_global for 0 capacity and ZST's 43c7f8dbf7337075f9b9a03ef100f719826030b2 (link)
#154190 Don't fuse in MapWindows 166a6cb073e6ea4a3a6b649ed170698af6f7bf18 (link)
#154512 Constify comparisons and Clone for core::mem::Alignment b19a8f58a0306b0a5fab1c0b711b3493c23387b8 (link)
#154520 Add doc links to ExtractIf of BTree{Set,Map} and `Linke… 4ddf9dd12cb7f4250277968897e5d0e2543fef66 (link)

previous master: 148adf223e

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

@github-actions
Copy link
Copy Markdown
Contributor

What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 148adf2 (parent) -> 584d32e (this PR)

Test differences

Show 834 test diffs

Stage 1

  • iter::adapters::map_windows::test_unfused: [missing] -> pass (J0)
  • vec::const_make_global_empty_or_zst_regression: [missing] -> pass (J0)

Stage 2

  • iter::adapters::map_windows::test_unfused: [missing] -> pass (J1)
  • vec::const_make_global_empty_or_zst_regression: [missing] -> pass (J1)

Additionally, 830 doctest diffs were found. These are ignored, as they are noisy.

Job group index

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 584d32e3ee7a2051c9ec1338d259ed8ef16380ca --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. aarch64-apple: 3h 13m -> 2h 19m (-27.7%)
  2. optional-x86_64-gnu-parallel-frontend: 2h 44m -> 2h 17m (-16.3%)
  3. pr-check-1: 32m 43s -> 27m 26s (-16.2%)
  4. x86_64-gnu-llvm-22-1: 1h 13m -> 1h 3m (-14.1%)
  5. dist-aarch64-msvc: 1h 58m -> 1h 42m (-13.7%)
  6. x86_64-gnu-tools: 1h 3m -> 55m 54s (-12.6%)
  7. dist-aarch64-linux: 1h 43m -> 1h 55m (+11.6%)
  8. x86_64-rust-for-linux: 51m 51s -> 46m 3s (-11.2%)
  9. i686-gnu-2: 1h 42m -> 1h 30m (-11.1%)
  10. pr-check-2: 42m 11s -> 37m 37s (-10.8%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@rust-timer
Copy link
Copy Markdown
Collaborator

Finished benchmarking commit (584d32e): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

Results (primary -2.4%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-2.4% [-2.4%, -2.4%] 1
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) -2.4% [-2.4%, -2.4%] 1

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 492.806s -> 484.385s (-1.71%)
Artifact size: 394.85 MiB -> 394.81 MiB (-0.01%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merged-by-bors This PR was explicitly merged by bors. rollup A PR which is a rollup T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants