Add regression test for mono item collection ICE with generic_const_exprs#154547
Open
jeanibarz wants to merge 1 commit intorust-lang:mainfrom
Open
Add regression test for mono item collection ICE with generic_const_exprs#154547jeanibarz wants to merge 1 commit intorust-lang:mainfrom
jeanibarz wants to merge 1 commit intorust-lang:mainfrom
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
rustbot
added
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
jeanibarz
force-pushed
the
fix/add-test-149035
branch
from
16a45fb to
5c589b8
Compare
This comment has been minimized.
This comment has been minimized.
jeanibarz
force-pushed
the
fix/add-test-149035
branch
from
5c589b8 to
3ef77ce
Compare
Author
|
r? rust-lang/compiler |
This comment has been minimized.
This comment has been minimized.
jeanibarz
force-pushed
the
fix/add-test-149035
branch
2 times, most recently
from
745fe6a to
6982ce5
Compare
…xprs Exercises -Clink-dead-code=true with generic_const_exprs and min_generic_const_args, which previously caused an ICE in mono item collection.
jeanibarz
force-pushed
the
fix/add-test-149035
branch
from
6982ce5 to
68ea4d5
Compare
jeanibarz
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Regression test for #149035.
The ICE in mono item collection with
-Clink-dead-code=truewas fixed by #152129 but didn't get a test. Adapted the reproducer to usetype constsince const handling changed after the issue was filed.Closes #149035