Rollup of 7 pull requests by tgross35 · Pull Request #154611 · rust-lang/rust

tgross35 · 2026-03-30T23:14:51Z

Successful merges:

compiler-builtins: Clean up features #142659 (compiler-builtins: Clean up features)
Avoid ICE when param-env normalization leaves unresolved inference variables #153574 (Avoid ICE when param-env normalization leaves unresolved inference variables)
Fix EII function aliases eliminated by LTO #153648 (Fix EII function aliases eliminated by LTO)
Fix regression when dealing with generics/values with unresolved inference #153790 (Fix regression when dealing with generics/values with unresolved inference)
Lex lifetimes as identifiers, recover from emoji and emit appropriate error #153893 (Lex lifetimes as identifiers, recover from emoji and emit appropriate error)
refactor: move doc(rust_logo) check to parser #153980 (refactor: move doc(rust_logo) check to parser)
Skip suggestions pointing to macro def for assert_eq #154551 (Skip suggestions pointing to macro def for assert_eq)

…smute_obligation_for_reporting`

Lex and parse emoji in lifetimes, and disallow them in the parser with a hard error. Allow emoji to start a lifetime name even if they are not XID_Start. ``` error: lifetimes cannot contain emoji --> $DIR/emoji-in-lifetime.rs:1:22 | LL | fn bad_lifetime_name<'🐛🐛🐛family👨👩👧👦>( | ^^^^^^^^^^^^^^^^^^^^^ ```

avoid ICE on invalid param-env normalization remove 120033 crash test fix comments use rustc_no_implicit_bounds set #![allow(incomplete_features)]

Remove the `compiler-builtins` feature from default because it prevents testing via the default `cargo test` command. It made more sense as a default when `compiler-builtins` was a dependency that some crates added via crates.io, but is no longer needed. The `rustc-dep-of-std` feature is also removed since it doesn't do anything beyond what the `compiler-builtins` feature already does.

compiler-builtins: Clean up features Remove the `compiler-builtins` feature from default because it prevents testing via the default `cargo test` command. It made more sense as a default when `compiler-builtins` was a dependency that some crates added via crates.io, but is no longer needed. The `rustc-dep-of-std` feature is also removed since it doesn't do anything beyond what the `compiler-builtins` feature already does.

…-normalization-ice, r=lcnr Avoid ICE when param-env normalization leaves unresolved inference variables Fixes rust-lang#153354 Because the impl is already ill-formed, those variables are not fully constrained, so zfully_resolve` fails. We previously treated that as an immediate compiler bug with `span_bug!`, which caused an ICE on invalid input.

…donszelmann,bjorn3 Fix EII function aliases eliminated by LTO Add EII function aliases to `llvm.compiler.used` so that LLVM's LTO passes do not eliminate them. Fixes rust-lang#153645 Tracking issue: rust-lang#125418

@jdonszelmann

…r=jdonszelmann Fix regression when dealing with generics/values with unresolved inference Follow up for rust-lang#151703, fixing regression caused in rollup rust-lang#152825 Forgot to handle generics & unresolved inference variables (as in `get_safe_transmute_error_and_reason`) in my previous PR. This followup checks for them before trying to normalize. I am not completely sure its right approach to have this check cloned but as `select_transmute_obligation_for_reporting` fn just chooses obligation and doesn't actually return an error, this check shouldn't be removed from `get_safe_transmute_error_and_reasnon`. If there is any better solution, let me kmow. Fixes: rust-lang#153755 r? @jdonszelmann

…lmann,Veykril Lex lifetimes as identifiers, recover from emoji and emit appropriate error Lex and parse emoji in lifetimes by using the identifier logic, and disallow them in the parser with a hard error. Allow emoji to start a lifetime name even if they are not XID_Start. ``` error: identifiers cannot contain emoji: `'🐛🐛🐛family👨👩👧👦` --> $DIR/emoji-in-lifetime.rs:1:22 | LL | fn bad_lifetime_name<'🐛🐛🐛family👨👩👧👦>( | ^^^^^^^^^^^^^^^^^^^^^ ``` Address rust-lang#141081 (but we could provide more information in the diagnostic, pointing at the specific chars, providing a link to the reference on identifiers and/or some other extra information).

…o, r=jdonszelmann refactor: move doc(rust_logo) check to parser Reducing `check_attr.rs` size by moving the `#[doc(rust_logo)]` feature gate into `DocParser`.

…t-ne-suggestion-span, r=JohnTitor Skip suggestions pointing to macro def for assert_eq Fixes rust-lang#146204 It's better to suggest: ```console help: consider borrowing here --> src/main.rs:3:16 | 3| assert_ne!(&buf, b"----"); | + ``` but i don't want to give a too heuristic but not general enough fix, let suppress them.

tgross35 · 2026-03-30T23:15:00Z

@bors r+ rollup=never p=5

rust-bors · 2026-03-30T23:15:03Z

📌 Commit a28a275 has been approved by tgross35

It is now in the queue for this repository.

Rollup of 7 pull requests Successful merges: - #142659 (compiler-builtins: Clean up features) - #153574 (Avoid ICE when param-env normalization leaves unresolved inference variables) - #153648 (Fix EII function aliases eliminated by LTO) - #153790 (Fix regression when dealing with generics/values with unresolved inference) - #153893 (Lex lifetimes as identifiers, recover from emoji and emit appropriate error) - #153980 (refactor: move doc(rust_logo) check to parser) - #154551 (Skip suggestions pointing to macro def for assert_eq)

rust-bors · 2026-03-31T01:13:46Z

💔 Test for d60aa38 failed: CI. Failed job:

auto - x86_64-gnu-llvm-21-1 (web logs, enhanced plaintext logs)

tgross35 · 2026-03-31T01:18:18Z

@bors retry

Spurious cache issue

rust-log-analyzer · 2026-03-31T01:18:47Z

The job x86_64-gnu-llvm-21-1 failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)

[TIMING:start] compile::Sysroot { compiler: Compiler { stage: 0, host: x86_64-unknown-linux-gnu, forced_compiler: false }, force_recompile: false }
[TIMING:end] compile::Sysroot { compiler: Compiler { stage: 0, host: x86_64-unknown-linux-gnu, forced_compiler: false }, force_recompile: false } -- 0.000
[TIMING:end] builder::Libdir { compiler: Compiler { stage: 0, host: x86_64-unknown-linux-gnu, forced_compiler: false }, target: x86_64-unknown-linux-gnu } -- 0.000
##[group]Building stage1 tidy (stage0 -> stage1, x86_64-unknown-linux-gnu)
error: process didn't exit successfully: `sccache /checkout/obj/build/bootstrap/debug/rustc -vV` (exit status: 2)
--- stderr
sccache: error: Timed out waiting for server startup. Maybe the remote service is unreachable?
Run with SCCACHE_LOG=debug SCCACHE_NO_DAEMON=1 to get more information

Bootstrap failed while executing `--stage 2 test --skip tests --skip coverage-map --skip coverage-run --skip library --skip tidyselftest`
Build completed unsuccessfully in 0:00:17
  local time: Tue Mar 31 01:13:08 UTC 2026
  network time: Tue, 31 Mar 2026 01:13:08 GMT

Zalathar · 2026-03-31T02:29:35Z

Given that the last rollup timed out, and there are a few more rollup=never PRs in the queue, it might be prudent to replace this rollup with a larger one.

tgross35 · 2026-03-31T02:35:55Z

I don't follow that logic given we don't know for certain the failure in #154588 was spurious? It probably is but if not, absorbing PRs from that one could cause another rollup to fail.

There are only two rollup=never PRs in the queue aside from this one and the one being tested.

Rollup of 7 pull requests Successful merges: - #142659 (compiler-builtins: Clean up features) - #153574 (Avoid ICE when param-env normalization leaves unresolved inference variables) - #153648 (Fix EII function aliases eliminated by LTO) - #153790 (Fix regression when dealing with generics/values with unresolved inference) - #153893 (Lex lifetimes as identifiers, recover from emoji and emit appropriate error) - #153980 (refactor: move doc(rust_logo) check to parser) - #154551 (Skip suggestions pointing to macro def for assert_eq)

rust-log-analyzer · 2026-03-31T05:15:56Z

The job dist-ohos-armv7 failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)

258 |                 rustc_lexer::TokenKind::Lifetime { invalid, starts_with_number } => {
    |                                                           ++++++++++++++++++++
help: if you don't care about this missing field, you can explicitly ignore it
    |
258 |                 rustc_lexer::TokenKind::Lifetime { invalid, starts_with_number: _ } => {
    |                                                           +++++++++++++++++++++++
help: or always ignore missing fields here
    |
258 |                 rustc_lexer::TokenKind::Lifetime { invalid, .. } => {
    |                                                           ++++

rust-bors · 2026-03-31T05:16:30Z

💔 Test for 35ee928 failed: CI. Failed job:

auto - dist-ohos-armv7 (web logs, enhanced plaintext logs)

rust-bors · 2026-03-31T05:32:07Z

PR #153893, which is a member of this rollup, was unapproved.

AsakuraMizu and others added 20 commits March 11, 2026 20:41

fix: add EII function aliases to exported symbols

d81cc68

add generic & unresolved inference variables handling in `select_tran…

fd45124

…smute_obligation_for_reporting`

refactor: move doc(rust_logo) check to parser

69d9576

refactor: reuse doc attr helper for rust_logo

48987fd

Unify lifetime and identifier parsing

dfdc525

Use bad_unicode_identifiers for lifetimes

702197a

Fix rust-analyzer

ea749ea

remove whitespace

956917d

fix test

4f1676d

add self-referential param-env normalization regression

d29c489

avoid ICE on invalid param-env normalization remove 120033 crash test fix comments use rustc_no_implicit_bounds set #![allow(incomplete_features)]

Skip suggestions pointing to extern macro def for assert_eq

6518de3

Rollup merge of rust-lang#153980 - mehdiakiki:pr-check_attrs-rust_log…

f5f76ab

…o, r=jdonszelmann refactor: move doc(rust_logo) check to parser Reducing `check_attr.rs` size by moving the `#[doc(rust_logo)]` feature gate into `DocParser`.

rust-bors bot added the rollup A PR which is a rollup label Mar 30, 2026

rust-bors bot added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Mar 30, 2026

rust-bors bot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 30, 2026

This comment has been minimized.

Sign in to view

rust-bors bot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 31, 2026

rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 31, 2026

This comment has been minimized.

Sign in to view

rust-bors bot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 31, 2026

Zalathar mentioned this pull request Mar 31, 2026

Lex lifetimes as identifiers, recover from emoji and emit appropriate error #153893

Open

rust-bors bot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 31, 2026

tgross35 closed this Mar 31, 2026

rustbot removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Mar 31, 2026

tgross35 deleted the rollup-I9ve7BM branch March 31, 2026 05:32

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Rollup of 7 pull requests#154611

Rollup of 7 pull requests#154611
tgross35 wants to merge 20 commits intorust-lang:mainfrom
tgross35:rollup-I9ve7BM

tgross35 commented Mar 30, 2026

Uh oh!

tgross35 commented Mar 30, 2026

Uh oh!

rust-bors bot commented Mar 30, 2026

Uh oh!

This comment has been minimized.

rust-bors bot commented Mar 31, 2026

Uh oh!

tgross35 commented Mar 31, 2026

Uh oh!

rust-log-analyzer commented Mar 31, 2026

Uh oh!

Zalathar commented Mar 31, 2026

Uh oh!

tgross35 commented Mar 31, 2026

Uh oh!

This comment has been minimized.

rust-log-analyzer commented Mar 31, 2026

Uh oh!

rust-bors bot commented Mar 31, 2026

Uh oh!

rust-bors bot commented Mar 31, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

Uh oh!

Conversation

tgross35 commented Mar 30, 2026

Uh oh!

tgross35 commented Mar 30, 2026

Uh oh!

rust-bors bot commented Mar 30, 2026

Uh oh!

This comment has been minimized.

rust-bors bot commented Mar 31, 2026

Uh oh!

tgross35 commented Mar 31, 2026

Uh oh!

rust-log-analyzer commented Mar 31, 2026

Uh oh!

Zalathar commented Mar 31, 2026

Uh oh!

tgross35 commented Mar 31, 2026

Uh oh!

This comment has been minimized.

rust-log-analyzer commented Mar 31, 2026

Uh oh!

rust-bors bot commented Mar 31, 2026

Uh oh!

rust-bors bot commented Mar 31, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants