Closed
Conversation
These seem to have been missed when the PR originally merged.
avoid ICE on invalid param-env normalization remove 120033 crash test fix comments use rustc_no_implicit_bounds set #![allow(incomplete_features)]
Remove the `compiler-builtins` feature from default because it prevents testing via the default `cargo test` command. It made more sense as a default when `compiler-builtins` was a dependency that some crates added via crates.io, but is no longer needed. The `rustc-dep-of-std` feature is also removed since it doesn't do anything beyond what the `compiler-builtins` feature already does.
compiler-builtins: Clean up features Remove the `compiler-builtins` feature from default because it prevents testing via the default `cargo test` command. It made more sense as a default when `compiler-builtins` was a dependency that some crates added via crates.io, but is no longer needed. The `rustc-dep-of-std` feature is also removed since it doesn't do anything beyond what the `compiler-builtins` feature already does.
Mark method receivers in builtin derives as being from the derive. Another small annoyance while working on clippy. This was clearly using the root context on purpose, but it also has no reason to do so. All the uses of the receiver are generated by the macros so they can just use the marked context rather than the root.
…-normalization-ice, r=lcnr Avoid ICE when param-env normalization leaves unresolved inference variables Fixes rust-lang#153354 Because the impl is already ill-formed, those variables are not fully constrained, so zfully_resolve` fails. We previously treated that as an immediate compiler bug with `span_bug!`, which caused an ICE on invalid input.
…o, r=jdonszelmann refactor: move doc(rust_logo) check to parser Reducing `check_attr.rs` size by moving the `#[doc(rust_logo)]` feature gate into `DocParser`.
…t-ne-suggestion-span, r=JohnTitor Skip suggestions pointing to macro def for assert_eq Fixes rust-lang#146204 It's better to suggest: ```console help: consider borrowing here --> src/main.rs:3:16 | 3| assert_ne!(&buf, b"----"); | + ``` but i don't want to give a too heuristic but not general enough fix, let suppress them.
delete several `ui/consts` tests * `tests/ui/consts/const.rs`: meaningless * `tests/ui/consts/const-bound.rs`: has nothing to do with const bounds or const at all (anymore?) * `tests/ui/consts/const-enum-tuplestruct2.rs`, `tests/ui/consts/const-enum-tuple2.rs`, `tests/ui/consts/const-enum-tuple.rs`: duplicates of `tests/ui/consts/const-enum-tuplestruct.rs` r? @Kivooeo
…youxu Update `mir-opt` 64-bit panic-abort tests for `Alignment` rename These seem to have been missed when the PR originally merged. cc rust-lang#154004, @GrigorenkoPV
Add a test for a now fixed ICE with `offset_of!()` Adds a test for rust-lang#125805, which was an ICE with `offset_of!()` on a field with the type of a trait object missing `dyn` and a required lifetime parameter. Closes rust-lang#125805.
rustbot
added
A-attributes
Contributor
Author
|
@bors r+ rollup=never p=5 |
rustbot
added
T-compiler
Contributor
rust-bors
bot
added
S-waiting-on-bors
Collaborator
|
The job Click to see the possible cause of the failure (guessed by this bot) |
Contributor
Author
|
@bors r- I have no clue, @JonathanBrouwer any ideas about that failure? Rollups are all yours, they're not going my way today :) |
rust-bors
bot
added
S-waiting-on-author
rustbot
removed
the
S-waiting-on-author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
ui/conststests #154574 (delete severalui/conststests)mir-opt64-bit panic-abort tests forAlignmentrename #154577 (Updatemir-opt64-bit panic-abort tests forAlignmentrename)offset_of!()#154612 (Add a test for a now fixed ICE withoffset_of!())r? @ghost
Create a similar rollup