Skip to content

Misc refactorings to rustc_codegen_ssa #58846

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 18 commits into from
Mar 30, 2019
Merged

Misc refactorings to rustc_codegen_ssa #58846

merged 18 commits into from
Mar 30, 2019

Conversation

bjorn3
Copy link
Member

@bjorn3 bjorn3 commented Mar 1, 2019

Unlike #56636 this doesn't split BuilderMethods into a lot of traits. That makes this PR twice as small and the split turned out to not be very useful anyway.

r? @eddyb

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 1, 2019
@bjorn3 bjorn3 mentioned this pull request Mar 4, 2019
Closed
@bors
Copy link
Collaborator

bors commented Mar 17, 2019

☔ The latest upstream changes (presumably #59178) made this pull request unmergeable. Please resolve the merge conflicts.

@oli-obk
Copy link
Contributor

oli-obk commented Mar 28, 2019

r? @oli-obk

@rust-highfive rust-highfive assigned oli-obk and unassigned eddyb Mar 28, 2019
@eddyb
Copy link
Member

eddyb commented Mar 28, 2019

Sorry about the delays, please ping me in IRC/Discord PMs (or Zulip, but its UI/UX make it harder to use), if I don't see notifications, I'm still digging myself out of the backlog, but I am around!

eddyb
eddyb reviewed Mar 28, 2019
View reviewed changes
eddyb
eddyb reviewed Mar 28, 2019
View reviewed changes
src/librustc_codegen_llvm/builder.rs
cg_elem: OperandRef<'tcx, &'ll Value>,
count: u64,
dest: PlaceRef<'tcx, &'ll Value>,
) -> Self {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is neat!

@eddyb
Copy link
Member

eddyb commented Mar 28, 2019

r=me with the comment fixed

bjorn3 added 18 commits March 29, 2019 17:06
@bjorn3
Don't use c_uint in cg_ssa
2b688a9
@bjorn3
eval_mir_constant doesn't need a builder param
a0c2ca1
@bjorn3
Use Builder instead of CodegenCx for OperandRef and LocalRef
83e80a7
@bjorn3
Add a comment
fe88440
@bjorn3
Misc
a005633
@bjorn3
Remove const_{fat_ptr,array,vector,bytes} from cg_ssa
a3fa116
@bjorn3
Remove const_{cstr,str_slice,get_elt,get_real} and is_const_real meth…
7b94195 
…ods from cg_ssa

This introduces the static_panic_msg trait method to StaticBuilderMethods.
@bjorn3
Remove param_substs from FunctionCx
f1fe925
@bjorn3
Remove internal mutability from source_locations_enabled
ab8f152
@bjorn3
[WIP] Make some debug info methods take &mut FunctionDebugContext
794ecd9 
declare_local still takes &FunctionDebugContext, because of borrowck errors
@bjorn3
Remove a lot of methods from BuilderMethods
bcab497
@bjorn3
Move get_param and set_value_name
7de0b1d
@bjorn3
Remove scalar_lltypes from cg_ssa
b0ee1f7
@bjorn3
Remove a lot of methods from *TypeMethods
0e166bb
@bjorn3
Remove type_variadic_func and typ_array from cg_ssa
b71c429
@bjorn3
Remove inline_asm_call from cg_ssa
b2e6194 
`count_insn` is no longer called for inline asm, because it is private to builder.rs
@bjorn3
Add a method for emiting a switch.
56842b2
@bjorn3
Use ExactSizeIterator + TrustedLen instead of num_cases arg for switch
35705de
@bjorn3 bjorn3 force-pushed the misc_cg_ssa_refactor branch from 5e303dd to 35705de Compare March 29, 2019 16:24
@bjorn3
Copy link
Member Author

bjorn3 commented Mar 29, 2019

Rebased and fixed comment.

@eddyb
Copy link
Member

eddyb commented Mar 29, 2019

@bors r+

@bors
Copy link
Collaborator

bors commented Mar 29, 2019

📌 Commit 35705de has been approved by eddyb

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 29, 2019
@bors
Copy link
Collaborator

bors commented Mar 29, 2019

⌛ Testing commit 35705de with merge 2671421...

bors added a commit that referenced this pull request Mar 29, 2019
@bors
Auto merge of #58846 - bjorn3:misc_cg_ssa_refactor, r=eddyb
2671421 
Misc refactorings to rustc_codegen_ssa

Unlike #56636 this doesn't split `BuilderMethods` into a lot of traits. That makes this PR twice as small and the split turned out to not be very useful anyway.

r? @eddyb
@bors
Copy link
Collaborator

bors commented Mar 30, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: eddyb
Pushing 2671421 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Mar 30, 2019
@bors bors merged commit 35705de into rust-lang:master Mar 30, 2019
@bors bors mentioned this pull request Mar 30, 2019
Closed
@bjorn3 bjorn3 deleted the misc_cg_ssa_refactor branch March 30, 2019 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@eddyb eddyb eddyb left review comments

Reviewers whose approvals may not affect merge requirements
Assignees

@oli-obk oli-obk

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bjorn3 @bors @oli-obk @eddyb @rust-highfive