Skip to content

A few miscellaneous comment fixes and a tiny code clarification. #78177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Dec 4, 2020
Merged

A few miscellaneous comment fixes and a tiny code clarification. #78177

merged 4 commits into from
Dec 4, 2020

Conversation

benjaminp
Copy link
Contributor

No description provided.

@rust-highfive
Copy link
Contributor

r? @ecstatic-morse

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 21, 2020
jonas-schievink
jonas-schievink reviewed Oct 21, 2020
View reviewed changes
@crlf0710
Copy link
Member

Ping from triage: @benjaminp Hi, would you mind rebasing the changes?

@crlf0710 crlf0710 added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 13, 2020
@camelid camelid added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. C-cleanup Category: PRs that clean code up or issues documenting cleanup. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Dec 4, 2020
@camelid
Copy link
Member

camelid commented Dec 4, 2020

r? @jyn514 since I know you want to push these sorts of PRs along :)

jyn514
jyn514 reviewed Dec 4, 2020
View reviewed changes
Copy link
Member

@jyn514 jyn514 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was fun to review 😄

@benjaminp benjaminp force-pushed the cleanups branch 2 times, most recently from 6dc8eac to e728dad Compare December 4, 2020 05:36
camelid
camelid reviewed Dec 4, 2020
View reviewed changes
@jyn514
Copy link
Member

jyn514 commented Dec 4, 2020

@bors r+ rollup

Great catch on all of these!

@bors
Copy link
Collaborator

bors commented Dec 4, 2020

📌 Commit 504f136 has been approved by jyn514

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 4, 2020
@bors
Copy link
Collaborator

bors commented Dec 4, 2020

⌛ Testing commit 504f136 with merge e622543...

@bors
Copy link
Collaborator

bors commented Dec 4, 2020

☀️ Test successful - checks-actions
Approved by: jyn514
Pushing e622543 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Dec 4, 2020
@bors bors merged commit e622543 into rust-lang:master Dec 4, 2020
@rustbot rustbot added this to the 1.50.0 milestone Dec 4, 2020
@benjaminp benjaminp deleted the cleanups branch December 4, 2020 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@camelid camelid camelid left review comments

+2 more reviewers

@jonas-schievink jonas-schievink jonas-schievink left review comments

@jyn514 jyn514 jyn514 left review comments

Reviewers whose approvals may not affect merge requirements
Assignees

@jyn514 jyn514

Labels
C-cleanup Category: PRs that clean code up or issues documenting cleanup. merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.50.0
Development

Successfully merging this pull request may close these issues.
9 participants
@benjaminp @rust-highfive @crlf0710 @camelid @jyn514 @bors @jonas-schievink @ecstatic-morse @rustbot