Skip to content

Conversation

jackh726
Copy link
Member

@jackh726 jackh726 commented Jun 4, 2022

Fixed regression introduced in #97023

r? @compiler-errors

cc @cjgillot

@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Jun 4, 2022
@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 4, 2022
@compiler-errors
Copy link
Member

Thanks! Maybe @cjgillot has more opinions on this code, but this works for now -- locally tested it!

@bors r+

@bors
Copy link
Collaborator

bors commented Jun 4, 2022

📌 Commit efd26539a61431261b21bc32cccf3f037300cf36 has been approved by compiler-errors

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 4, 2022
@rust-log-analyzer

This comment has been minimized.

@compiler-errors
Copy link
Member

@bors r- pls format then r=me

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jun 4, 2022
@jackh726 jackh726 force-pushed the verbose-pretty-printing-fix branch from efd2653 to dd38fec Compare June 4, 2022 21:32
@jackh726
Copy link
Member Author

jackh726 commented Jun 4, 2022

@bors r=compiler-errors

@bors
Copy link
Collaborator

bors commented Jun 4, 2022

📌 Commit dd38fec has been approved by compiler-errors

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 4, 2022
bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 4, 2022
…askrgr

Rollup of 6 pull requests

Successful merges:

 - rust-lang#97609 (Iterate over `maybe_unused_trait_imports` when checking dead trait imports)
 - rust-lang#97688 (test const_copy to make sure bytewise pointer copies are working)
 - rust-lang#97707 (Improve soundness of rustc_data_structures)
 - rust-lang#97731 (Add regresion test for rust-lang#87142)
 - rust-lang#97735 (Don't generate "Impls on Foreign Types" for std)
 - rust-lang#97737 (Fix pretty printing named bound regions under -Zverbose)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 1794309 into rust-lang:master Jun 5, 2022
@rustbot rustbot added this to the 1.63.0 milestone Jun 5, 2022
@jackh726 jackh726 deleted the verbose-pretty-printing-fix branch June 5, 2022 03:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants