Skip to content

Conversation

compiler-errors
Copy link
Member

I'm still trying to get the hang of this, so it doesn't migrate all of rustc_const_eval. Working on that later.

r? @davidtwco

@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Jun 29, 2022
@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 29, 2022
@compiler-errors compiler-errors force-pushed the rustc-const-eval-session-diagnostic-1 branch from 4605a17 to 4dd984c Compare June 29, 2022 07:07
Copy link
Member

@davidtwco davidtwco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, a couple small comments.

@bors

This comment was marked as resolved.

@compiler-errors compiler-errors force-pushed the rustc-const-eval-session-diagnostic-1 branch from 4dd984c to 2058333 Compare July 8, 2022 03:52
@compiler-errors
Copy link
Member Author

@rustbot ready :)

@rustbot

This comment was marked as resolved.

@compiler-errors
Copy link
Member Author

lmao

@rustbot ready

@davidtwco
Copy link
Member

@bors r+

@bors
Copy link
Collaborator

bors commented Jul 8, 2022

📌 Commit 2058333 has been approved by davidtwco

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 8, 2022
bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 8, 2022
Rollup of 4 pull requests

Successful merges:

 - rust-lang#98533 (Add a `-Zdump-drop-tracking-cfg` debugging flag)
 - rust-lang#98654 (An optimization for `pest-2.1.3`)
 - rust-lang#98657 (Migrate some diagnostics from `rustc_const_eval` to `SessionDiagnostic`)
 - rust-lang#98794 (Highlight conflicting param-env candidates)

Failed merges:

 - rust-lang#98957 ( don't allow ZST in ScalarInt )

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit dbae830 into rust-lang:master Jul 8, 2022
@rustbot rustbot added this to the 1.64.0 milestone Jul 8, 2022
@davidtwco davidtwco added the A-translation Area: Translation infrastructure, and migrating existing diagnostics to SessionDiagnostic label Aug 17, 2022
@compiler-errors compiler-errors deleted the rustc-const-eval-session-diagnostic-1 branch August 11, 2023 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-translation Area: Translation infrastructure, and migrating existing diagnostics to SessionDiagnostic S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants