Fix outdated feature gating examples in stabilization guide (fixes #2401) #2552
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR. If you have write access, feel free to merge this PR if it does not need reviews. You can request a review using |
rustbot
added
the
S-waiting-on-review
ali90h
changed the title
|
r? @jieyouxu |
jieyouxu
requested changes
Aug 25, 2025
There was a problem hiding this comment.
Test Plan
- Verified documentation builds without errors
The example would not build.
- Checked that examples align with actual compiler implementation
It does not align.
Please do not generate a verbose PR description which does not contain useful information, yet is still wrong.
| @@ -79,25 +79,25 @@ Also, remove those strings from any tests (e.g. under `tests/`). If there are te | |||
| Most importantly, remove the code which flags an error if the feature-gate is not present (since the feature is now considered stable). If the feature can be detected because it employs some new syntax, then a common place for that code to be is in `compiler/rustc_ast_passes/src/feature_gate.rs`. For example, you might see code like this: | |||
|
|
|||
| ```rust,ignore | |||
| gate_all!(pub_restricted, "`pub(restricted)` syntax is experimental"); | |||
| gate_feature_post!(box_patterns, span, "box pattern syntax is experimental"); | |||
There was a problem hiding this comment.
This is what the original issue was about, that this is no longer a thing.
|
|
||
| ```rust,ignore | ||
| if self.tcx.sess.features.borrow().pub_restricted { /* XXX */ } | ||
| if self.tcx.sess.features.borrow().box_patterns { /* XXX */ } |
rustbot
added
S-waiting-on-author
|
Also you don't need to include a list of changes files in your PR descriptions. This is freely accessible information to anyone looking at your PR already by clicking on the "files changed" tab. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changes Made
Test Plan
Fixes #2401
Files Changed: