Skip to content

Conversation

Jamesbarford
Copy link
Contributor

  • Fixes the ordering of the queue.
  • Fix formatting of errors, we now return a hashtable; I've formatted it to be error_name: error\n.
  • Fix createdAt being used in the Completed At column (not sure if the column name is the one that needed changing or the value).

From the refactor we have lost the ability to have the parent that will be benchmarked appear "above the waterline".

Copy link
Member

@Kobzol Kobzol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While you're at it, could you please copy-paste and adapt the way we show errors on the current status page? There is a clickable button that expands the errors if there are any. Without such a button, the page layout will probably look terrible if we just dump the error content directly into the table.

@Jamesbarford
Copy link
Contributor Author

While you're at it, could you please copy-paste and adapt the way we show errors on the current status page? There is a clickable button that expands the errors if there are any. Without such a button, the page layout will probably look terrible if we just dump the error content directly into the table.

Yup, I arbitrarily copy pasted a block of SQL but we can see the button and the expanded row;
image

@@ -97,6 +98,21 @@ function formatStatus(status: BenchmarkRequestStatus): string {
}
}

function hasErrors(errors: Dict<string>) {
// This is a bit odd but if the error object has values the loop will be
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You already use Object.keys(errors).length in getErrorsLength, you can use the same here :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

6913885 👍

Copy link
Member

@Kobzol Kobzol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Kobzol Kobzol merged commit fb22792 into rust-lang:master Sep 3, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants