feat(config): warn user if auto-install is enabled #4454
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rami3l
commented
Aug 24, 2025
| @@ -53,15 +53,15 @@ pub(crate) struct Toolchain<'a> { | |||
| impl<'a> Toolchain<'a> { | |||
| pub(crate) async fn from_local( | |||
| name: LocalToolchainName, | |||
| install_if_missing: bool, | |||
| install_if_missing: impl Fn() -> anyhow::Result<bool>, | |||
There was a problem hiding this comment.
This change is made so that the self.should_auto_install() call is postponed to L64, and that the false positive in L60 can be suppressed.
rami3l
force-pushed
the
feat/warn-auto-install
branch
4 times, most recently
from
e1dec08 to
e504752
Compare
rami3l
force-pushed
the
feat/warn-auto-install
branch
3 times, most recently
from
b1d9725 to
8d25c01
Compare
This also ensures that every test case relying on the `RUSTUP_AUTO_INSTALL` config option is explicitly setting it.
rami3l
force-pushed
the
feat/warn-auto-install
branch
from
8d25c01 to
fedd51c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4445.