-
Notifications
You must be signed in to change notification settings - Fork 1k
use "tuple" instead of "triple" for target names #4658
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
ChrisDenton
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's good to use consistent terminology across the project so I personally think this is a good idea. But I'll wait to see if other team members are on board.
|
I'd like a little more "proof" than a single PR making targeted changes. Is there a Zulip thread with discussion or an issue somewhere? |
djc
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, I read the PR conversation -- seems fine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! However, I would like to know if this migration is complete. Have you found any type names in this repo to be migrated as well, for example?
|
there is a whole bunch of "triple" in the code, some public... are there api users outside of rustup of anything in rustup |
@tshepang I think rustup's API doesn't have any stability guarantees so you are free to break them as long as they are coherent, right here or in a subsequent update, as you like it. |
|
am happy to do it in a future pr |
Looks spurious. Retrying... |
These are changes I expect would not break anything.
For context, main Rust repo has started moving to new terminology.