Skip to content

Remove std_detect dev dependency in core_arch #1843

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 7, 2025

Conversation

Kobzol
Copy link
Member

@Kobzol Kobzol commented Jul 4, 2025

Instead of core_arch loading the is_XYZ_feature_enabled macros from the local std_detect crate, they are loaded from ::std::arch instead. This means that nothing in this repository will depend on std_detect anymore (except for tests, these will be ported later). The downside is that core_arch will need to wait for nightly std bumps to see changes in the detection macros, but I assume that should be rare.

This is one of the steps required to move std_detect fully into rust-lang/rust.

@Kobzol Kobzol force-pushed the remove-std-detect branch 3 times, most recently from f4326f0 to 0c1ef86 Compare July 4, 2025 08:01
@Kobzol Kobzol changed the title Remove std-detect dev dependency in core_arch Remove std_detect dev dependency in core_arch Jul 4, 2025
@Kobzol Kobzol marked this pull request as ready for review July 4, 2025 08:38
@rustbot
Copy link
Collaborator

rustbot commented Jul 4, 2025

r? @Amanieu

rustbot has assigned @Amanieu.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Copy link
Contributor

@folkertdev folkertdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes to the detection macros should just happen in r-l/r then, right? At least when adding new target features that nicer anyway (in that case today we must wait for a nightly bump). It's only internal logic changes (which, as you say, are rare) that would get bitten by this, but then it should be easy enough to move such a PR over to r-l/r

@Kobzol Kobzol force-pushed the remove-std-detect branch from 0c1ef86 to f3eeedc Compare July 5, 2025 19:04
@Kobzol Kobzol force-pushed the remove-std-detect branch from f3eeedc to ff54a88 Compare July 5, 2025 19:04
@Kobzol
Copy link
Member Author

Kobzol commented Jul 5, 2025

changes to the detection macros should just happen in r-l/r then, right?

Yes. Hopefully the whole of std_detect will more into r-l/r soon-ish (rust-lang/rust#143412).

@Amanieu Amanieu added this pull request to the merge queue Jul 7, 2025
Merged via the queue into rust-lang:master with commit a34360b Jul 7, 2025
61 checks passed
@Kobzol Kobzol deleted the remove-std-detect branch July 8, 2025 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants