`intrinsic-test`: Adding x86 behavioural testing. #1894

madhav-madhusoodanan · 2025-08-03T13:31:06Z

Context

This is a redo of PR #1814, since a lot of details have changed with PRs #1863, #1862, #1861, #1852.

crates/intrinsic-test/src/x86/intrinsic.rs

crates/intrinsic-test/src/x86/mod.rs

folkertdev · 2025-08-05T10:36:48Z

crates/intrinsic-test/src/x86/types.rs

+                match str::parse::<u32>(etype_processed.as_str()) {
+                    Ok(value) => data.bit_len = Some(value),
+                    Err(_) => {
+                        data.bit_len = match data.kind() {
+                            TypeKind::Char(_) => Some(8),
+                            TypeKind::BFloat => Some(16),
+                            TypeKind::Int(_) => Some(32),
+                            TypeKind::Float => Some(32),
+                            _ => None,
+                        };
+                    }
+                }


why are only some type kinds covered here? Maybe this could be a method on TypeKind?

crates/intrinsic-test/src/x86/compile.rs

folkertdev

you should rebase on top of the upstream master branch instead of merging it in. That keeps the git history clean.

folkertdev · 2025-08-05T22:48:30Z

ci/run.sh

+    x86_64-unknown-linux-gnu*)
+        CPPFLAGS="${TEST_CPPFLAGS}" RUSTFLAGS="${HOST_RUSTFLAGS}" RUST_LOG=warn \
+            cargo run "${INTRINSIC_TEST}" "${PROFILE}"  \
+            --bin intrinsic-test -- intrinsics_data/x86-intel.xml \
+            --runner "${TEST_RUNNER}" \
+            --cppcompiler "${TEST_CXX_COMPILER}" \
+            --target "${TARGET}"
+        ;;


we'll have to see how to do this exactly, but we want to split these out of the main CI job to speed it up

madhav-madhusoodanan · 2025-09-05T08:19:24Z

Seems like the CI run at this point failed due to this error. I'll retry shortly:

#6 39.45   Could not connect to archive.ubuntu.com:80 (185.125.190.82), connection timed out Could not connect to archive.ubuntu.com:80 (185.125.190.83), connection timed out Could not connect to archive.ubuntu.com:80 (91.189.91.83), connection timed out Could not connect to archive.ubuntu.com:80 (185.125.190.81), connection timed out Could not connect to archive.ubuntu.com:80 (91.189.91.81), connection timed out Could not connect to archive.ubuntu.com:80 (185.125.190.36), connection timed out Could not connect to archive.ubuntu.com:80 (185.125.190.39), connection timed out Could not connect to archive.ubuntu.com:80 (91.189.91.82), connection timed out
#6 39.45   Unable to connect to archive.ubuntu.com:80:
#6 39.45 Fetched 126 kB in 39s (3208 B/s)
#6 39.45 Reading package lists...
#6 39.46 W: Failed to fetch http://archive.ubuntu.com/ubuntu/dists/questing/InRelease  Unable to connect to archive.ubuntu.com:80:
#6 39.46 W: Failed to fetch http://archive.ubuntu.com/ubuntu/dists/questing-updates/InRelease  Unable to connect to archive.ubuntu.com:80:
#6 39.46 W: Failed to fetch http://archive.ubuntu.com/ubuntu/dists/questing-backports/InRelease  Unable to connect to archive.ubuntu.com:80:
#6 39.46 W: Some index files failed to download. They have been ignored, or old ones used instead.

Notes: 1. chunk_info has been moved to `common/mod.rs` since it will be needed for all architectures

struct

parameters/return value of an intrinsic

Mask-based

updates

folkertdev · 2025-09-10T16:31:59Z

Can you rebase this (and remove the merge commits) sometime? That would make it a lot easier to see what has actually changed.

Also, why do you push to then have CI fail? Running this locally is a lot faster than having CI do it, because you can skip the earlier steps and run just the intrinsic tests.

folkertdev

oh, wait, it probably is up to date? it's just that xml file is enormous. that's crazy. Should we like, try to trim that down?

folkertdev · 2025-09-10T16:34:58Z

crates/intrinsic-test/src/x86/mod.rs

+    fn compare_outputs(&self) -> bool {
+        if self.cli_options.toolchain.is_some() {
+            let intrinsics_name_list = self
+                .intrinsics
+                .iter()
+                .map(|i| i.name.clone())
+                .collect::<Vec<_>>();
+
+            compare_outputs(
+                &intrinsics_name_list,
+                &self.cli_options.runner,
+                &self.cli_options.target,
+            )
+        } else {
+            true
+        }


this function is already defined by the trait, so it can be removed here.

madhav-madhusoodanan · 2025-09-10T19:15:00Z

@folkertdev I've been syncing using the below command whenever I'm updating from master:

git rebase master

Am I doing it correctly?

madhav-madhusoodanan · 2025-09-10T19:17:13Z

About the XML file specification, may I ask what "trim down" means?

folkertdev · 2025-09-10T19:17:24Z

depends a bit on your git setup, but it seems to work allright. I was just confused by the enormous number of lines changed, but that's all due to that XML file.

folkertdev · 2025-09-10T19:20:07Z

What i mean is, could we process that XML file into a smaller XML file that only stores what we need? That would reduce the size of the repo (not sure how big that file is, maybe it compresses well?) and the speed of the intrinsic tests.

There are risks too, e.g. what we generate could go out of date with the official XML file. So maybe it's fine this way.

madhav-madhusoodanan · 2025-09-10T19:26:57Z

Ahh, makes sense.

I think it might be best to keep the source of truth as unchanged as possible, since there is no direct way to obtain the sources sometimes.

For example, the XML file originally existed in the stdarch-verify crate, and I've had to check it by manually downloading the x86 reference (which comes in a folder containing HTML, CSS and JS files) at the link called Download: Offline Intel® Intrinsics Guide in the Intel intrinsics reference site

The entire XML data can be found stored as a hardcoded string that is assigned to a variable in a JS file.

folkertdev · 2025-09-10T19:28:11Z

Eww cursed. Allright, that's fine then

rustbot assigned folkertdev Aug 3, 2025

madhav-madhusoodanan commented Aug 3, 2025

View reviewed changes

crates/intrinsic-test/src/x86/intrinsic.rs Outdated Show resolved Hide resolved

madhav-madhusoodanan force-pushed the intrinsic-test-x86-addition branch 2 times, most recently from 41db5a8 to 5fc0f3b Compare August 5, 2025 10:16

folkertdev reviewed Aug 5, 2025

View reviewed changes

madhav-madhusoodanan force-pushed the intrinsic-test-x86-addition branch from 9e28106 to 111cd5d Compare August 5, 2025 16:22

folkertdev reviewed Aug 5, 2025

View reviewed changes

madhav-madhusoodanan force-pushed the intrinsic-test-x86-addition branch from f3f87f2 to 2ec747c Compare August 9, 2025 12:20

madhav-madhusoodanan force-pushed the intrinsic-test-x86-addition branch from 2ec747c to a8313d0 Compare September 5, 2025 08:16

madhav-madhusoodanan force-pushed the intrinsic-test-x86-addition branch 9 times, most recently from a119be1 to 0f3900b Compare September 8, 2025 19:25

madhav-madhusoodanan added 11 commits September 10, 2025 00:10

feat: added the skeleton structure of the x86 module

1eee9ed

feat: added the XML intrinsic parser for x86

07f20f4

feat: updated intrinsics creation

191614a

feat: update building C code for x86 architecture.

a952d3b

Notes: 1. chunk_info has been moved to `common/mod.rs` since it will be needed for all architectures

fix: code cleanup

417f729

chore: added Regex crate, updated the structure of X86IntrinsicType

4c19bd2

struct

feat: implemented build_rust_file of x86 module

3e3bf65

feat: implemented compare_outputs of x86 module

3e95708

feat: implement print_result_c for Intrinsic<X86IntrinsicType>

fbb8214

feat: Added x86 to CI pipeline

6c69404

fix: update arch flags being sent to the x86 compilation command

0d62fe4

madhav-madhusoodanan added 10 commits September 10, 2025 00:11

fix: set default value for varname and type fields of the

bd48f59

parameters/return value of an intrinsic

fix: correcting semantical logic for setting vec_len

8a69c61

fix: more support for Mask types

83bc235

fix: remove unused imports

76359ef

feat: implemented print_result_c in the case the target type is

0c803aa

Mask-based

feat: implemented get_lane_function for x86

a7dac63

chore: update c_prefix for mask and print_result_c for vector type

68b2b2c

feat: handled extraction for 64-bit vector elements

1951ed0

feat: add 8x8 case for get_lane_function for 64-bit vector

9726455

debug: printing self incase print_result_c fails.

1a07650

madhav-madhusoodanan force-pushed the intrinsic-test-x86-addition branch 3 times, most recently from 76f386e to 126a3ce Compare September 10, 2025 05:51

chore: update x86 module, removed intrinsicDefinition trait, formatting

e79129a

updates

madhav-madhusoodanan force-pushed the intrinsic-test-x86-addition branch from 126a3ce to e79129a Compare September 10, 2025 05:58

folkertdev reviewed Sep 10, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

`intrinsic-test`: Adding x86 behavioural testing. #1894

`intrinsic-test`: Adding x86 behavioural testing. #1894

Uh oh!

madhav-madhusoodanan commented Aug 3, 2025

Uh oh!

Uh oh!

Uh oh!

folkertdev Aug 5, 2025

Uh oh!

Uh oh!

folkertdev left a comment

Uh oh!

folkertdev Aug 5, 2025

Uh oh!

madhav-madhusoodanan commented Sep 5, 2025

Uh oh!

folkertdev commented Sep 10, 2025

Uh oh!

folkertdev left a comment

Uh oh!

folkertdev Sep 10, 2025

Uh oh!

madhav-madhusoodanan commented Sep 10, 2025

Uh oh!

madhav-madhusoodanan commented Sep 10, 2025

Uh oh!

folkertdev commented Sep 10, 2025

Uh oh!

folkertdev commented Sep 10, 2025

Uh oh!

madhav-madhusoodanan commented Sep 10, 2025 •

edited

Loading

Uh oh!

folkertdev commented Sep 10, 2025

Uh oh!

Uh oh!

intrinsic-test: Adding x86 behavioural testing. #1894

Are you sure you want to change the base?

intrinsic-test: Adding x86 behavioural testing. #1894

Uh oh!

Conversation

madhav-madhusoodanan commented Aug 3, 2025

Context

Uh oh!

Uh oh!

Uh oh!

folkertdev Aug 5, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

folkertdev left a comment

Choose a reason for hiding this comment

Uh oh!

folkertdev Aug 5, 2025

Choose a reason for hiding this comment

Uh oh!

madhav-madhusoodanan commented Sep 5, 2025

Uh oh!

folkertdev commented Sep 10, 2025

Uh oh!

folkertdev left a comment

Choose a reason for hiding this comment

Uh oh!

folkertdev Sep 10, 2025

Choose a reason for hiding this comment

Uh oh!

madhav-madhusoodanan commented Sep 10, 2025

Uh oh!

madhav-madhusoodanan commented Sep 10, 2025

Uh oh!

folkertdev commented Sep 10, 2025

Uh oh!

folkertdev commented Sep 10, 2025

Uh oh!

madhav-madhusoodanan commented Sep 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

folkertdev commented Sep 10, 2025

Uh oh!

Uh oh!

`intrinsic-test`: Adding x86 behavioural testing. #1894

`intrinsic-test`: Adding x86 behavioural testing. #1894

madhav-madhusoodanan commented Sep 10, 2025 •

edited

Loading