Skip to content

chore : validate no duplicate team members #1918 #2032

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

chore : validate no duplicate team members #1918 #2032

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bc36284
chore : validate no duplicate team members #1918
vivekjami Oct 22, 2025
5cb4a4c
chore: add explicitmember check
vivekjami Oct 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion src/validate.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -220,9 +220,22 @@ fn validate_team_leads(data: &Data, errors: &mut Vec<String>) {
});
}

/// Ensure team members are people
/// Ensure team members are real people and not duplicated
fn validate_team_members(data: &Data, errors: &mut Vec<String>) {
wrapper(data.teams(), errors, |team, errors| {
// Check for duplicate members in explicit_members
let mut seen = HashSet::new();
for member in team.explicit_members() {
if !seen.insert(&member.github) {
bail!(
"person `{}` is duplicated in team `{}`",
member.github,
team.name()
);
}
}

// Existing validation: ensure members are real people
wrapper(team.members(data)?.iter(), errors, |member, _| {
if data.person(member).is_none() {
bail!(
Expand Down
Loading