Skip to content

Conversation

@Kobzol
Copy link
Member

@Kobzol Kobzol commented Dec 5, 2025

It would be nice to do a dry-run of this, to ensure that we won't be deleting TP configs unexpectedly.

@github-actions
Copy link

github-actions bot commented Dec 5, 2025

Dry-run check results

[WARN  sync_team] sync-team is running in dry mode, no changes will be applied.
[INFO  sync_team] synchronizing crates-io
[INFO  sync_team] synchronizing github
[INFO  sync_team] 💻 Repo Diffs:
    📝 Editing repo 'rust-lang/flate2-rs':
      Environments:
        ❌ Delete: copilot

@Kobzol Kobzol marked this pull request as draft December 6, 2025 17:43
@Kobzol
Copy link
Member Author

Kobzol commented Dec 6, 2025

Marking as draft, I should implement support for paging first.

@Kobzol Kobzol marked this pull request as ready for review December 6, 2025 18:22
@Kobzol
Copy link
Member Author

Kobzol commented Dec 6, 2025

Ok, implemented now.

@jieyouxu jieyouxu added needs-infra-admin-review This change requires one of the `infra-admins` to review. S-waiting-on-review Status: waiting on review from a team/WG/PG lead, an infra-admin, and/or a team-repo-admin. labels Dec 7, 2025
To avoid N+1 queries to fetch crate information.
@marcoieni
Copy link
Member

@Kobzol
Copy link
Member Author

Kobzol commented Dec 10, 2025

That is because the dry run is always using the workflow from main (and that doesn't have the env. var. set). So it cannot really work. Do you want me to land setting the env. var. in the dry run in a separate PR, so we can merge it first to make the dry run work?

Kobzol added a commit to Kobzol/team that referenced this pull request Dec 10, 2025
So that it is propagated to `main` and we can do a dry-run for rust-lang#2160.
@Kobzol
Copy link
Member Author

Kobzol commented Dec 10, 2025

#2172

@marcoieni marcoieni added this pull request to the merge queue Dec 10, 2025
Merged via the queue into rust-lang:main with commit 162e7ad Dec 10, 2025
6 checks passed
@Kobzol Kobzol deleted the remove-unused-trusted-publishing branch December 10, 2025 21:32
@Kobzol
Copy link
Member Author

Kobzol commented Dec 10, 2025

image

Looks like two TP configs weren't in team, I'll add them back.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-infra-admin-review This change requires one of the `infra-admins` to review. S-waiting-on-review Status: waiting on review from a team/WG/PG lead, an infra-admin, and/or a team-repo-admin.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants