Skip to content

Don't raise reviewer already assigned when there are multiple assignees #2290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Urgau merged 1 commit into from
Feb 17, 2026
Merged

Don't raise reviewer already assigned when there are multiple assignees #2290

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion src/handlers/assign.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -328,7 +328,7 @@ async fn set_assignee(
IssueData::load(&mut db, issue, PREVIOUS_REVIEWERS_KEY).await?;

// Don't re-assign if already assigned, e.g. on comment edit
if issue.contain_assignee(&reviewer.name) {
if issue.contain_assignee(&reviewer.name) && issue.assignees.len() == 1 {
log::trace!(
"ignoring assign PR {} to {}, already assigned",
issue.global_id(),
Expand Down Expand Up @@ -709,6 +709,13 @@ pub(super) async fn handle_command(
.await
{
Ok(assignee) => assignee,
Err(FindReviewerError::ReviewerAlreadyAssigned { username })
if issue.contain_assignee(&event.user().login) =>
{
// If one of the assignee tries to assign another already assigned user,
// let it pass, as it means they wanted to be removed from the assignee list.
Copy link
Copy Markdown
Member

@Kobzol Kobzol Feb 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What if there are three assignees (R1, R2, R3), and R1 sends r? R2, should it unassign R3? 😆

Copy link
Copy Markdown
Member Author

@Urgau Urgau Feb 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No idea, it's a border line situation. I could see it go both ways.

ReviewerSelection::new(username, Vec::new())
}
Err(e) => {
issue.post_comment(&ctx.github, &e.to_string()).await?;
return Ok(());
Expand Down