Skip to content

feat: add copy button on install link to improve Accessibility#2281

Merged
senekor merged 5 commits intorust-lang:mainfrom
Mr-Sunglasses:feat/copy-button
Apr 11, 2026
Merged

feat: add copy button on install link to improve Accessibility#2281
senekor merged 5 commits intorust-lang:mainfrom
Mr-Sunglasses:feat/copy-button

Conversation

@Mr-Sunglasses
Copy link
Copy Markdown
Contributor

fix: #2280

Add a copy button in installation command to make it more accessibility friendly.

Screen.Recording.2026-04-10.at.12.10.56.AM.mov

@Mr-Sunglasses Mr-Sunglasses requested a review from a team as a code owner April 9, 2026 18:42
@senekor
Copy link
Copy Markdown
Contributor

senekor commented Apr 9, 2026

Please revert the whitespace changes so this can be reviewed more easily.

@Mr-Sunglasses
Copy link
Copy Markdown
Contributor Author

Please revert the whitespace changes so this can be reviewed more easily.

Hey @senekor 👋🏻 , I've reverted the whitespace changes, thanks for the suggestion.

Copy link
Copy Markdown
Contributor

@senekor senekor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First pass, I'll have a closer look later.

This doesn't take translations into consideration, but those are on hold anyway, so there's not point in worrying about it now I guess.

I generally prefer styling be done via Tachyons instead of adding to the global app.scss file... but everything is nicely scoped to the pre-copy-wrap class, so might be fine.

View changes since this review

@Mr-Sunglasses Mr-Sunglasses requested a review from senekor April 9, 2026 20:03
@Mr-Sunglasses Mr-Sunglasses requested a review from senekor April 10, 2026 00:48
Copy link
Copy Markdown
Contributor

@senekor senekor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@senekor senekor merged commit 9441e36 into rust-lang:main Apr 11, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add copy button in Install link to improve Accessibility

2 participants