Render dedicated pages for launching-pad working groups#2283
Open
kaitersgonnakait wants to merge 1 commit intorust-lang:mainfrom
Open
Render dedicated pages for launching-pad working groups#2283kaitersgonnakait wants to merge 1 commit intorust-lang:mainfrom
kaitersgonnakait wants to merge 1 commit intorust-lang:mainfrom
Conversation
When the site was converted from a Rocket server to a static generator, render_governance only iterated over top-level teams from index_data(), silently dropping pages for working groups under launching-pad (e.g. /governance/wgs/wg-secure-code). The page_data logic to allow these was preserved but never called. Adds launching_pad_subteam_pages() to produce the missing IndexTeam entries and chains them into the render loop.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the site was converted from a Rocket server to a static generator, render_governance only iterated over top-level teams from index_data(), dropping pages for working groups under launching-pad (e.g. /governance/wgs/wg-secure-code). The page_data logic to preserve these URLs.
Adds launching_pad_subteam_pages() to produce the missing working group IndexTeam entries and chains them into the render loop.
By filtering by teams that are subteam-of = "launching-pad" and kind = "working-group", this creates the legacy pages for these working groups:
An alternate solution to add redirects to the new location of the teams on this page here: https://rust-lang.org/governance/teams/
Closes #2268