Skip to content

fix tail_file.rs: read from the ending not beginning #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jingangdidi wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix tail_file.rs: read from the ending not beginning #70

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7cacb3c
Update tail_file.rs: read from the ending not beginning
jingangdidi Dec 2, 2025
80aee19
fix: `tail_file` return the first n lines, not last n lines
jingangdidi Dec 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/fs_service/io/read.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@ impl FileSystemService {
let start_pos = if line_count <= n {
0 // Read from start if fewer than n lines
} else {
*newline_positions.get(line_count - n).unwrap_or(&0) + 1
*newline_positions.get(n).unwrap_or(&0) + 1
};

// Read forward from start_pos
Expand Down
2 changes: 1 addition & 1 deletion src/tools/tail_file.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ use crate::fs_service::FileSystemService;
pub struct TailFile {
/// The path of the file to get information for.
pub path: String,
/// The number of lines to read from the beginning of the file.
/// The number of lines to read from the ending of the file.
pub lines: u64,
}

Expand Down