Skip to content

Add ln_1p and exp_m1 #131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Add ln_1p and exp_m1 #131

wants to merge 4 commits into from

Conversation

soumyasen1809
Copy link

Fixes issue #123

@soumyasen1809
Add complex ln_1p()
e27b987 
- Added a complex equivalent of the real function ln_1p()
@soumyasen1809
Added doc for ln_1p
7d3927c 
- Added doc with formula and test
for ln_1p()
@soumyasen1809
Add complex exp_m1()
29937ed 
- Added a complex equivalent of the real function exp_m1()
- Added doc with formula and test
for exp_m1
@soumyasen1809
Added ln_1p and exp_m1
9bd0dd4 
- Added tests for them
@soumyasen1809 soumyasen1809 mentioned this pull request Sep 19, 2024
Open
@Expander
Copy link

I propose to add a test for ln_1p() that checks that $\ln(1+z)=z$ for $z=\epsilon+i\epsilon$, where $\epsilon=$std::f64::EPSILON. In my opinion this test should pass within 1ulp.

@Expander
Copy link

julia has a reference implementation that can be found here:
https://github.com/JuliaLang/julia/blob/5ebc5b463ead44e98a3108a477084bdd591e3d8e/base/complex.jl#L748

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@soumyasen1809 @Expander