Make the RNG fall back to using an algorithm handle if BCryptGenRandom fails #330
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on rust-lang/rust#102044
Adresses #314, replaces #318
This doesn't have a fast-path to avoid
BCryptGenRandomif it is known to fail.Thus this is probably gonna get expensive for some users, I can add some fast-path though.
Right now I don't have a Windows machine to actually test it on (but CI should do that, I also have acess to a machine again next week).
I'm not 100% sure yet that it fixes the crashes we see on Firefox, but given the stdlib switched to a similar solution I have hopes.