Block buffer internals #36
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhardy
commented
Dec 10, 2025
Comment on lines
-191
to
223
| /// Generate a new set of results immediately, setting the index to the | ||
| /// given value. | ||
| /// Updates the index and buffer contents | ||
| /// | ||
| /// If `index == 0`, this marks the buffer as "empty", causing generation on | ||
| /// next use. | ||
| /// | ||
| /// If `index > 0`, this generates a new block immediately then sets the | ||
| /// index. | ||
| #[inline] | ||
| pub fn generate_and_set(&mut self, index: usize) { |
Member
Author
There was a problem hiding this comment.
This is a change of behaviour, but should only be observable if the caller uses generate_and_set(0) without immediately generating any output and cares that Generator::generate was not called. As such, I didn't bother mentioning this in the CHANGELOG.
I considered renaming it but decided not to.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGELOG.mdentrySummary
Remove
BlockRng::indexfield by storing it in the buffer.Add method
BlockRng::remaining_resultsand constructorreconstructto allow external serialization.Details
This replaces #30. Unlike in #24, I decided to let
remaining_resultsreturn a (variable length) slice, but with an upper bound on its length so that it is possible to serialize this as a fixed-length array (left to the serialization implementer; with text reprs like JSON a variable-length array is probably preferred).Removes the
indexfield as an optimization, as in #24.